From: Florian Zschocke <f.zschocke+git@gmail.com>
Date: Fri, 11 Nov 2022 17:53:57 +0000 (+0100)
Subject: fix: Fix jetty crashing when redirecting HTTP to HTTPS
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=609130e26c51739dc9a6d278b2006929546271e1;p=gitblit.git

fix: Fix jetty crashing when redirecting HTTP to HTTPS

Jetty 9.3 changed the `setHandler` on the ServletContextHandler to no
longer automatically detect SecurityHandler, SessionHandler, etc. It
simply passes on the setHandler request to the ContextHandler class
(with a warning logged). So make sure to explicitly use the method
`setSecurityHandler` to set the ContraintSecurityHandler responsible
for the http -> https redirection.
---

diff --git a/src/main/java/com/gitblit/GitBlitServer.java b/src/main/java/com/gitblit/GitBlitServer.java
index 63914121..ae01e8e0 100644
--- a/src/main/java/com/gitblit/GitBlitServer.java
+++ b/src/main/java/com/gitblit/GitBlitServer.java
@@ -453,7 +453,7 @@ public class GitBlitServer {
 			sh.setConstraintMappings(new ConstraintMapping[] { cm });
 
 			// Configure this context to use the Security Handler defined before
-			rootContext.setHandler(sh);
+			rootContext.setSecurityHandler(sh);
 		}
 
 		// Setup the Gitblit context