From: Jörn Zaefferer <joern.zaefferer@gmail.com>
Date: Tue, 10 Apr 2012 22:19:26 +0000 (+0200)
Subject: Position: Mini refactoring, avoids proxying using callback multiple times if more... 
X-Git-Tag: 1.9.0m8~87^2~30
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=623e8e68b4e396cd9a3cdb4985c9db343924c4ec;p=jquery-ui.git

Position: Mini refactoring, avoids proxying using callback multiple times if more then one element is positioned
---

diff --git a/ui/jquery.ui.position.js b/ui/jquery.ui.position.js
index cde99cdca..025d2c815 100644
--- a/ui/jquery.ui.position.js
+++ b/ui/jquery.ui.position.js
@@ -170,7 +170,7 @@ $.fn.position = function( options ) {
 					( rpercent.test( offsets.my[ 1 ] ) ? elem.outerHeight() / 100 : 1 )
 			],
 			collisionPosition,
-			using = options.using;
+			using;
 
 		if ( options.my[ 0 ] === "right" ) {
 			position.left -= elemWidth;
@@ -221,9 +221,9 @@ $.fn.position = function( options ) {
 			elem.bgiframe();
 		}
 
-		if ( using ) {
-			// we have to proxy, as jQuery.offset.setOffset throws away props other than left/top
-			options.using = function( props ) {
+		if ( options.using ) {
+			// adds feedback as second argument to using callback, if present
+			using = function( props ) {
 				var left = targetOffset.left - props.left,
 					right = (targetOffset.left + targetWidth) - (props.left + elemWidth),
 					top = targetOffset.top - props.top,
@@ -237,11 +237,11 @@ $.fn.position = function( options ) {
 				} else {
 					feedback.important = "vertical";
 				}
-				using.call( this, props, feedback );
+				options.using.call( this, props, feedback );
 			};
 		}
 
-		elem.offset( $.extend( position, { using: options.using } ) );
+		elem.offset( $.extend( position, { using: using } ) );
 	});
 };