From: stanislavh <stanislav.honcharov@sonarsource.com>
Date: Tue, 5 Dec 2023 10:07:07 +0000 (+0100)
Subject: SONAR-21132 Do not show CCT fields in edit dialog
X-Git-Tag: 10.4.0.87286~333
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=631ea82186d2093a77ac9d76129c742cddc72518;p=sonarqube.git

SONAR-21132 Do not show CCT fields in edit dialog

Co-authored-by: Benjamin Raymond <31401273+7PH@users.noreply.github.com>
---

diff --git a/server/sonar-web/src/main/js/apps/coding-rules/components/CustomRuleFormModal.tsx b/server/sonar-web/src/main/js/apps/coding-rules/components/CustomRuleFormModal.tsx
index de13a247820..dce99ab2ba7 100644
--- a/server/sonar-web/src/main/js/apps/coding-rules/components/CustomRuleFormModal.tsx
+++ b/server/sonar-web/src/main/js/apps/coding-rules/components/CustomRuleFormModal.tsx
@@ -307,26 +307,30 @@ export default function CustomRuleFormModal(props: Readonly<Props>) {
 
           {NameField}
           {KeyField}
-
-          <div className="sw-flex sw-justify-between sw-gap-6">
-            <CleanCodeCategoryField
-              value={ccCategory}
-              disabled={submitting}
-              onChange={setCCCategory}
-            />
-            <CleanCodeAttributeField
-              value={ccAttribute}
-              category={ccCategory}
-              disabled={submitting}
-              onChange={setCCAtribute}
-            />
-          </div>
-          <SoftwareQualitiesFields
-            error={hasError}
-            value={impacts}
-            onChange={setImpacts}
-            disabled={submitting}
-          />
+          {/* do not allow to change CCT fields of existing rule */}
+          {!customRule && !reactivating && (
+            <>
+              <div className="sw-flex sw-justify-between sw-gap-6">
+                <CleanCodeCategoryField
+                  value={ccCategory}
+                  disabled={submitting}
+                  onChange={setCCCategory}
+                />
+                <CleanCodeAttributeField
+                  value={ccAttribute}
+                  category={ccCategory}
+                  disabled={submitting}
+                  onChange={setCCAtribute}
+                />
+              </div>
+              <SoftwareQualitiesFields
+                error={hasError}
+                value={impacts}
+                onChange={setImpacts}
+                disabled={submitting}
+              />
+            </>
+          )}
           {StatusField}
           {DescriptionField}
           {templateParams.map(renderParameterField)}