From: Leif Åstrand <leif@vaadin.com>
Date: Mon, 30 Jul 2012 13:21:45 +0000 (+0000)
Subject: Avoid int parse error in VSplitPanel and clean up the code (#9154)
X-Git-Tag: 7.0.0.beta1~79^2~59
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=64c7bbb569d5194eb9c5c083726a8c96053368e8;p=vaadin-framework.git

Avoid int parse error in VSplitPanel and clean up the code (#9154)

svn changeset:24034/svn branch:6.8
---

diff --git a/src/com/vaadin/terminal/gwt/client/ui/VSplitPanel.java b/src/com/vaadin/terminal/gwt/client/ui/VSplitPanel.java
index 00d76e3a45..e8c9b87ce0 100644
--- a/src/com/vaadin/terminal/gwt/client/ui/VSplitPanel.java
+++ b/src/com/vaadin/terminal/gwt/client/ui/VSplitPanel.java
@@ -385,23 +385,22 @@ public class VSplitPanel extends ComplexPanel implements Container,
      * @return
      */
     private float convertToPercentage(String pos) {
-        float posAsFloat = 0;
-
-        if (pos.indexOf("px") > 0) {
-            int posAsInt = Integer.parseInt(pos.substring(0, pos.length() - 2));
+        if (pos.endsWith("px")) {
+            float pixelPosition = Float.parseFloat(pos.substring(0,
+                    pos.length() - 2));
             int offsetLength = orientation == ORIENTATION_HORIZONTAL ? getOffsetWidth()
                     : getOffsetHeight();
 
-            // 100% needs special handling
-            if (posAsInt + getSplitterSize() >= offsetLength) {
-                posAsInt = offsetLength;
+            // Take splitter size into account at the edge
+            if (pixelPosition + getSplitterSize() >= offsetLength) {
+                return 100;
             }
-            posAsFloat = ((float) posAsInt / (float) offsetLength * 100);
 
+            return pixelPosition / offsetLength * 100;
         } else {
-            posAsFloat = Float.parseFloat(pos.substring(0, pos.length() - 1));
+            assert pos.endsWith("%");
+            return Float.parseFloat(pos.substring(0, pos.length() - 1));
         }
-        return posAsFloat;
     }
 
     private String checkSplitPositionLimits(String pos) {