From: Artur Signell <artur@vaadin.com>
Date: Tue, 18 Jun 2013 19:00:14 +0000 (+0300)
Subject: Removed StringToNumberConverter (#12092)
X-Git-Tag: 7.2.0.beta1~108^2~116
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=6a97757139e6c544cf9d62328546eb96856e8df0;p=vaadin-framework.git

Removed StringToNumberConverter (#12092)

Change-Id: Iada5bb27eefef788143625c4d63a121f6c2589ea
---

diff --git a/server/src/com/vaadin/data/util/converter/DefaultConverterFactory.java b/server/src/com/vaadin/data/util/converter/DefaultConverterFactory.java
index bbd3945a37..3c365ecdff 100644
--- a/server/src/com/vaadin/data/util/converter/DefaultConverterFactory.java
+++ b/server/src/com/vaadin/data/util/converter/DefaultConverterFactory.java
@@ -103,8 +103,6 @@ public class DefaultConverterFactory implements ConverterFactory {
             return new StringToIntegerConverter();
         } else if (Boolean.class.isAssignableFrom(sourceType)) {
             return new StringToBooleanConverter();
-        } else if (Number.class.isAssignableFrom(sourceType)) {
-            return new StringToNumberConverter();
         } else if (Date.class.isAssignableFrom(sourceType)) {
             return new StringToDateConverter();
         } else {
diff --git a/server/src/com/vaadin/data/util/converter/StringToNumberConverter.java b/server/src/com/vaadin/data/util/converter/StringToNumberConverter.java
deleted file mode 100644
index 22df42403f..0000000000
--- a/server/src/com/vaadin/data/util/converter/StringToNumberConverter.java
+++ /dev/null
@@ -1,65 +0,0 @@
-/*
- * Copyright 2000-2013 Vaadin Ltd.
- * 
- * Licensed under the Apache License, Version 2.0 (the "License"); you may not
- * use this file except in compliance with the License. You may obtain a copy of
- * the License at
- * 
- * http://www.apache.org/licenses/LICENSE-2.0
- * 
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
- * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
- * License for the specific language governing permissions and limitations under
- * the License.
- */
-
-package com.vaadin.data.util.converter;
-
-import java.text.NumberFormat;
-import java.util.Locale;
-
-/**
- * A converter that converts from {@link Number} to {@link String} and back.
- * Uses the given locale and {@link NumberFormat} for formatting and parsing.
- * <p>
- * Override and overwrite {@link #getFormat(Locale)} to use a different format.
- * </p>
- * 
- * @author Vaadin Ltd
- * @since 7.0
- */
-public class StringToNumberConverter extends
-        AbstractStringToNumberConverter<Number> {
-
-    /*
-     * (non-Javadoc)
-     * 
-     * @see
-     * com.vaadin.data.util.converter.Converter#convertToModel(java.lang.Object,
-     * java.lang.Class, java.util.Locale)
-     */
-    @Override
-    public Number convertToModel(String value,
-            Class<? extends Number> targetType, Locale locale)
-            throws ConversionException {
-        if (targetType != getModelType()) {
-            throw new ConversionException("Converter only supports "
-                    + getModelType().getName() + " (targetType was "
-                    + targetType.getName() + ")");
-        }
-
-        return convertToNumber(value, targetType, locale);
-    }
-
-    /*
-     * (non-Javadoc)
-     * 
-     * @see com.vaadin.data.util.converter.Converter#getModelType()
-     */
-    @Override
-    public Class<Number> getModelType() {
-        return Number.class;
-    }
-
-}
diff --git a/server/tests/src/com/vaadin/tests/data/converter/TestStringToNumberConverter.java b/server/tests/src/com/vaadin/tests/data/converter/TestStringToNumberConverter.java
deleted file mode 100644
index 66fc4f6532..0000000000
--- a/server/tests/src/com/vaadin/tests/data/converter/TestStringToNumberConverter.java
+++ /dev/null
@@ -1,24 +0,0 @@
-package com.vaadin.tests.data.converter;
-
-import junit.framework.TestCase;
-
-import com.vaadin.data.util.converter.StringToNumberConverter;
-
-public class TestStringToNumberConverter extends TestCase {
-
-    StringToNumberConverter converter = new StringToNumberConverter();
-
-    public void testNullConversion() {
-        assertEquals(null, converter.convertToModel(null, Number.class, null));
-    }
-
-    public void testEmptyStringConversion() {
-        assertEquals(null, converter.convertToModel("", Number.class, null));
-    }
-
-    public void testValueConversion() {
-        assertEquals(Long.valueOf(10),
-                converter.convertToModel("10", Number.class, null));
-        assertEquals(10.5, converter.convertToModel("10.5", Number.class, null));
-    }
-}