From: Toshi MARUYAMA Date: Mon, 7 Oct 2019 11:45:22 +0000 (+0000) Subject: use "attr_writer" instead of "attr_accessor" for WikiPage#deleted_attachment_ids X-Git-Tag: 4.1.0~472 X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=6b5991b34e5b52f85a654497738fe58339809834;p=redmine.git use "attr_writer" instead of "attr_accessor" for WikiPage#deleted_attachment_ids WikiPage#deleted_attachment_ids is already defined in this class. git-svn-id: http://svn.redmine.org/redmine/trunk@18617 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 2392983c2..961f88754 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -493,10 +493,6 @@ Lint/DeprecatedClassMethods: - 'test/unit/attachment_test.rb' - 'test/unit/issue_import_test.rb' -Lint/DuplicateMethods: - Exclude: - - 'app/models/wiki_page.rb' - Lint/EmptyWhen: Exclude: - 'app/controllers/issues_controller.rb' diff --git a/app/models/wiki_page.rb b/app/models/wiki_page.rb index 50fbe83c8..ede750e80 100644 --- a/app/models/wiki_page.rb +++ b/app/models/wiki_page.rb @@ -41,7 +41,8 @@ class WikiPage < ActiveRecord::Base :permission => :view_wiki_pages, :project_key => "#{Wiki.table_name}.project_id" - attr_accessor :redirect_existing_links, :deleted_attachment_ids + attr_accessor :redirect_existing_links + attr_writer :deleted_attachment_ids validates_presence_of :title validates_format_of :title, :with => /\A[^,\.\/\?\;\|\s]*\z/