From: U-DESKTOP-GN2POE0\jared <jared.stofflet@gmail.com>
Date: Fri, 30 Dec 2016 03:36:32 +0000 (-0500)
Subject: Add aria labels to issue rule and filter buttons in issue list. This is required... 
X-Git-Tag: 6.3-RC1~248
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=6b5beb16675db71236ecf5a3b0c50dff8d7e52fc;p=sonarqube.git

Add aria labels to issue rule and filter buttons in issue list. This is required since these buttons do not have
text describing what they do so are announced as "button" when using Jaws screen reading software.
---

diff --git a/server/sonar-web/src/main/js/apps/issues/templates/issues-issue-filter.hbs b/server/sonar-web/src/main/js/apps/issues/templates/issues-issue-filter.hbs
index f7f1bd1b215..16a212ddd60 100644
--- a/server/sonar-web/src/main/js/apps/issues/templates/issues-issue-filter.hbs
+++ b/server/sonar-web/src/main/js/apps/issues/templates/issues-issue-filter.hbs
@@ -1,5 +1,6 @@
 <li class="issue-meta">
-  <button class="button-link issue-action issue-action-with-options js-issue-filter">
+  <button class="button-link issue-action issue-action-with-options js-issue-filter"
+          aria-label="{{t "issue.filter_similar_issues"}}">
     <i class="icon-filter icon-half-transparent"></i>&nbsp;<i class="icon-dropdown"></i>
   </button>
 </li>
diff --git a/server/sonar-web/src/main/js/components/issue/templates/issue.hbs b/server/sonar-web/src/main/js/components/issue/templates/issue.hbs
index 3f4975d1f27..a828ecf5e3e 100644
--- a/server/sonar-web/src/main/js/components/issue/templates/issue.hbs
+++ b/server/sonar-web/src/main/js/components/issue/templates/issue.hbs
@@ -5,7 +5,8 @@
       <td>
         <div class="issue-message">
           {{message}}&nbsp;
-          <button class="button-link js-issue-rule issue-rule icon-ellipsis-h"></button>
+          <button class="button-link js-issue-rule issue-rule icon-ellipsis-h"
+                  aria-label="{{t 'issue.rule_details'}}"></button>
         </div>
       </td>
 
diff --git a/sonar-core/src/main/resources/org/sonar/l10n/core.properties b/sonar-core/src/main/resources/org/sonar/l10n/core.properties
index d3b386694da..965682207f9 100644
--- a/sonar-core/src/main/resources/org/sonar/l10n/core.properties
+++ b/sonar-core/src/main/resources/org/sonar/l10n/core.properties
@@ -601,6 +601,7 @@ issue.comment.delete_confirm_title=Delete Comment
 issue.comment.delete_confirm_message=Do you want to delete this comment?
 issue.comment.delete_confirm_button=Delete
 issue.details=Details
+issue.rule_details=Rule Details
 issue.send_notifications=Send Notifications
 issue.transition=Transition
 issue.transition.confirm=Confirm