From: Pierre Ossman <ossman@cendio.se>
Date: Thu, 14 Jan 2021 12:07:56 +0000 (+0100)
Subject: Fix handling of bad update requests
X-Git-Tag: v1.11.90~77
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=6d1603c3da504f76a4f7364f89e683a8e1632fdc;p=tigervnc.git

Fix handling of bad update requests

We computed a safe area if a client gave us a bogus one, but we didn't
actually use it. Fix this properly and make sure we don't pass on bad
coordinates further.
---

diff --git a/common/rfb/VNCSConnectionST.cxx b/common/rfb/VNCSConnectionST.cxx
index 9b5ead9f..1db94cac 100644
--- a/common/rfb/VNCSConnectionST.cxx
+++ b/common/rfb/VNCSConnectionST.cxx
@@ -628,7 +628,7 @@ void VNCSConnectionST::framebufferUpdateRequest(const Rect& r,bool incremental)
 
   // Just update the requested region.
   // Framebuffer update will be sent a bit later, see processMessages().
-  Region reqRgn(r);
+  Region reqRgn(safeRect);
   if (!incremental || !continuousUpdates)
     requested.assign_union(reqRgn);