From: Sébastien Lesaint <sebastien.lesaint@sonarsource.com>
Date: Fri, 17 Aug 2018 07:41:21 +0000 (+0200)
Subject: SONAR-8368 fix quality flaws in AbstractTracker inner classes
X-Git-Tag: 7.5~542
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=77d6ef37a5bbae4621767025029b36bcc7db1532;p=sonarqube.git

SONAR-8368 fix quality flaws in AbstractTracker inner classes
---

diff --git a/sonar-core/src/main/java/org/sonar/core/issue/tracking/AbstractTracker.java b/sonar-core/src/main/java/org/sonar/core/issue/tracking/AbstractTracker.java
index feb29d55599..406edb821b4 100644
--- a/sonar-core/src/main/java/org/sonar/core/issue/tracking/AbstractTracker.java
+++ b/sonar-core/src/main/java/org/sonar/core/issue/tracking/AbstractTracker.java
@@ -113,10 +113,13 @@ public class AbstractTracker<RAW extends Trackable, BASE extends Trackable> {
     }
 
     @Override
-    public boolean equals(@Nonnull Object o) {
+    public boolean equals(Object o) {
       if (this == o) {
         return true;
       }
+      if (o == null || getClass() != o.getClass()) {
+        return false;
+      }
       LineAndLineHashAndMessage that = (LineAndLineHashAndMessage) o;
       // start with most discriminant field
       return Objects.equals(line, that.line)
@@ -143,10 +146,13 @@ public class AbstractTracker<RAW extends Trackable, BASE extends Trackable> {
     }
 
     @Override
-    public boolean equals(@Nonnull Object o) {
+    public boolean equals(Object o) {
       if (this == o) {
         return true;
       }
+      if (o == null || getClass() != o.getClass()) {
+        return false;
+      }
       LineHashAndMessageKey that = (LineHashAndMessageKey) o;
       // start with most discriminant field
       return lineHash.equals(that.lineHash)
@@ -172,10 +178,13 @@ public class AbstractTracker<RAW extends Trackable, BASE extends Trackable> {
     }
 
     @Override
-    public boolean equals(@Nonnull Object o) {
+    public boolean equals(Object o) {
       if (this == o) {
         return true;
       }
+      if (o == null || getClass() != o.getClass()) {
+        return false;
+      }
       LineAndMessageKey that = (LineAndMessageKey) o;
       // start with most discriminant field
       return Objects.equals(line, that.line)
@@ -199,10 +208,13 @@ public class AbstractTracker<RAW extends Trackable, BASE extends Trackable> {
     }
 
     @Override
-    public boolean equals(@Nonnull Object o) {
+    public boolean equals(Object o) {
       if (this == o) {
         return true;
       }
+      if (o == null || getClass() != o.getClass()) {
+        return false;
+      }
       LineHashKey that = (LineHashKey) o;
       // start with most discriminant field
       return lineHash.equals(that.lineHash)