From: Arthur Schiwon <blizzz@arthur-schiwon.de>
Date: Mon, 10 Aug 2020 15:34:11 +0000 (+0200)
Subject: use break not continue in switch to avoid warning
X-Git-Tag: v20.0.0beta1~98^2
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=7c07f0c7f36238c8080fc95c534a625a4f8e5fa8;p=nextcloud-server.git

use break not continue in switch to avoid warning

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
---

diff --git a/apps/user_ldap/lib/Group_LDAP.php b/apps/user_ldap/lib/Group_LDAP.php
index 199865e7623..6bf1bd31ba0 100644
--- a/apps/user_ldap/lib/Group_LDAP.php
+++ b/apps/user_ldap/lib/Group_LDAP.php
@@ -877,8 +877,8 @@ class Group_LDAP extends BackendUtility implements GroupInterface, IGroupLDAP, I
 						])
 					]);
 					$ldap_users = $this->access->fetchListOfUsers($filter, $attrs, 1);
-					if (count($ldap_users) < 1) {
-						continue;
+					if (empty($ldap_users)) {
+						break;
 					}
 					$groupUsers[] = $this->access->dn2username($ldap_users[0]['dn'][0]);
 					break;
@@ -886,13 +886,13 @@ class Group_LDAP extends BackendUtility implements GroupInterface, IGroupLDAP, I
 					//we got DNs, check if we need to filter by search or we can give back all of them
 					$uid = $this->access->dn2username($member);
 					if (!$uid) {
-						continue;
+						break;
 					}
 
 					$cacheKey = 'userExistsOnLDAP' . $uid;
 					$userExists = $this->access->connection->getFromCache($cacheKey);
 					if ($userExists === false) {
-						continue;
+						break;
 					}
 					if ($userExists === null || $search !== '') {
 						if (!$this->access->readAttribute($member,
@@ -904,7 +904,7 @@ class Group_LDAP extends BackendUtility implements GroupInterface, IGroupLDAP, I
 							if ($search === '') {
 								$this->access->connection->writeToCache($cacheKey, false);
 							}
-							continue;
+							break;
 						}
 						$this->access->connection->writeToCache($cacheKey, true);
 					}