From: Fabrice Bellingard <fabrice.bellingard@sonarsource.com>
Date: Mon, 3 Dec 2012 09:57:03 +0000 (+0100)
Subject: SONAR-37 Improve rendering
X-Git-Tag: 3.4~218
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=7caf0971833c0a1a4871efae6fa599f1488ce327;p=sonarqube.git

SONAR-37 Improve rendering
---

diff --git a/plugins/sonar-core-plugin/src/main/resources/org/sonar/l10n/core.properties b/plugins/sonar-core-plugin/src/main/resources/org/sonar/l10n/core.properties
index bb78ed8c5e9..092e3188251 100644
--- a/plugins/sonar-core-plugin/src/main/resources/org/sonar/l10n/core.properties
+++ b/plugins/sonar-core-plugin/src/main/resources/org/sonar/l10n/core.properties
@@ -521,7 +521,7 @@ reviews.filtered_by.to=To date
 
 comparison.compare=Compare
 comparison.add_metric=Add metric
-comparison.select_resource_to_compare=Select a resource to compare
+comparison.select_resource_to_compare=Select a resource
 comparison.select_version=Select a version
 comparison.remove_resource=Remove resource
 comparison.remove_metric=Remove metric
diff --git a/sonar-server/src/main/webapp/WEB-INF/app/views/comparison/index.html.erb b/sonar-server/src/main/webapp/WEB-INF/app/views/comparison/index.html.erb
index a3dc044f302..c1c45850c2d 100644
--- a/sonar-server/src/main/webapp/WEB-INF/app/views/comparison/index.html.erb
+++ b/sonar-server/src/main/webapp/WEB-INF/app/views/comparison/index.html.erb
@@ -73,26 +73,28 @@
       <table class="data">
         <thead>
         <th class="thin" style="vertical-align: bottom">
-          <%= metric_select_tag 'new_metric', @metric_to_choose, {
-            :allow_empty => true,
-            :select2_options => {'placeholder' => "'" + message('comparison.add_metric') + "'"}
-          } -%>
-          <script>
-            // we don't want this parameter to be submitted, so we set its name to ''
-            $j('#new_metric').attr('name', '');
-            $j('#new_metric').on("change", function (e) {
-              if (e.val != null) {
-                var currentMetrics = $j('#metrics').val();
-                if (currentMetrics.length > 0) {
-                  currentMetrics += ',';
+          <div id="metric_div">
+            <%= metric_select_tag 'new_metric', @metric_to_choose, {
+              :allow_empty => true,
+              :select2_options => {'placeholder' => "'" + message('comparison.add_metric') + "'"}
+            } -%>
+            <script>
+              // we don't want this parameter to be submitted, so we set its name to ''
+              $j('#new_metric').attr('name', '');
+              $j('#new_metric').on("change", function (e) {
+                if (e.val != null) {
+                  var currentMetrics = $j('#metrics').val();
+                  if (currentMetrics.length > 0) {
+                    currentMetrics += ',';
+                  }
+                  currentMetrics += e.val;
+                  $j('#metrics').val(currentMetrics);
+                  $j('#compare-form').submit();
                 }
-                currentMetrics += e.val;
-                $j('#metrics').val(currentMetrics);
-                $j('#compare-form').submit();
-              }
-            });
-          </script>
-        </th>
+              });
+            </script>
+          </th>
+        </div>
 
         <%
            last_index = @snapshots.size-1
@@ -132,34 +134,40 @@
         <% end %>
 
         <th style="padding-left: 20px; vertical-align: bottom">
-          <%= resource_select_tag 'new_resource', {
-            :resource_type_property => 'comparable',
-            :width => '250px',
-            :select2_options => {'placeholder' => "'" + message('comparison.select_resource_to_compare') + "'"}
-          } -%>
-          <script>
-            // we don't want this parameter to be submitted, so we set its name to ''
-            $j('#new_resource').attr('name', '');
-            $j('#new_resource').on("change", function (e) {
-              if (e.val != null) {
-                $j.ajax({
-                  type:'GET',
-                  url:'<%= ApplicationController.root_context -%>/comparison/versions?resource='
-                    + e.val + '&sids='
-                    + $j('#sids').val(),
-                  success:function (data) {
-                    $j('#new_version').html(data);
-                    $j('#new_version').select2({placeholder:'<%= message('comparison.select_version') -%>'});
-                    $j('#version_div').show();
-                    $j('#new_version').select2("focus");
-                  }
-                });
-              }
-            });
-            $j('#new_resource').select2("focus");
-          </script>
+          <div id="resource_div">
+            <%= resource_select_tag 'new_resource', {
+              :resource_type_property => 'comparable',
+              :width => '250px',
+              :select2_options => {'placeholder' => "'" + message('comparison.select_resource_to_compare') + "'"}
+            } -%>
+            <script>
+              // we don't want this parameter to be submitted, so we set its name to ''
+              $j('#new_resource').attr('name', '');
+              $j('#new_resource').on("change", function (e) {
+                if (e.val != null) {
+                  $j('#version_loading').show();
+                  $j.ajax({
+                    type:'GET',
+                    url:'<%= ApplicationController.root_context -%>/comparison/versions?resource='
+                      + e.val + '&sids='
+                      + $j('#sids').val(),
+                    success:function (data) {
+                      $j('#new_version').html(data);
+                      $j('#new_version').select2({placeholder:'<%= message('comparison.select_version') -%>'});
+                      $j('#version_loading').hide();
+                      $j('#version_div').show();
+                      $j('#new_version').select2("focus");
+                    }
+                  });
+                }
+              });
+              $j('#new_resource').select2("focus");
+            </script>
+          </div>
+          
+          <div id="version_loading" class="loading" style="height: 16px; margin-top: 5px; display: none"></div>
           
-          <span id="version_div" style="display: none">
+          <div id="version_div" style="margin-top: 5px; display: none">
             <select id="new_version">
             </select>
             <script>
@@ -175,7 +183,7 @@
                 }
               });
             </script>
-          </span>
+          </div>
         </th>
         </thead>