From: Oleg Gaidarenko Date: Tue, 17 Feb 2015 07:09:54 +0000 (+0300) Subject: Core: change jQuery.each and jQuery#each signatures X-Git-Tag: 3.0.0-alpha1+compat~109 X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=7cd9a363229c6ec1ceaa4debf49ee3eb20d97761;p=jquery.git Core: change jQuery.each and jQuery#each signatures (cherry-picked from 2380028ec4a6a77401b867a51de26a3cb8e8d311) Fixes gh-2090 Closes gh-2097 --- diff --git a/src/core.js b/src/core.js index 9eb2ac5fc..21a995f38 100644 --- a/src/core.js +++ b/src/core.js @@ -73,10 +73,8 @@ jQuery.fn = jQuery.prototype = { }, // Execute a callback for every element in the matched set. - // (You can seed the arguments with an array of args, but this is - // only used internally.) - each: function( callback, args ) { - return jQuery.each( this, callback, args ); + each: function( callback ) { + return jQuery.each( this, callback ); }, map: function( callback ) { @@ -295,40 +293,21 @@ jQuery.extend({ return elem.nodeName && elem.nodeName.toLowerCase() === name.toLowerCase(); }, - // args is for internal usage only - each: function( obj, callback, args ) { + each: function( obj, callback ) { var i = 0, length = obj.length, isArray = isArraylike( obj ); - if ( args ) { - if ( isArray ) { - for ( ; i < length; i++ ) { - if ( callback.apply( obj[ i ], args ) === false ) { - break; - } - } - } else { - for ( i in obj ) { - if ( callback.apply( obj[ i ], args ) === false ) { - break; - } + if ( isArray ) { + for ( ; i < length; i++ ) { + if ( callback.call( obj[ i ], i, obj[ i ] ) === false ) { + break; } } - - // A special, fast, case for the most common use of each } else { - if ( isArray ) { - for ( ; i < length; i++ ) { - if ( callback.call( obj[ i ], i, obj[ i ] ) === false ) { - break; - } - } - } else { - for ( i in obj ) { - if ( callback.call( obj[ i ], i, obj[ i ] ) === false ) { - break; - } + for ( i in obj ) { + if ( callback.call( obj[ i ], i, obj[ i ] ) === false ) { + break; } } }