From: David Gageot Date: Tue, 12 May 2015 08:42:31 +0000 (+0200) Subject: Useless code X-Git-Tag: 5.2-RC1~1981 X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=7d5701e0a327448484ccee968e12ae3d9162d407;p=sonarqube.git Useless code --- diff --git a/plugins/sonar-xoo-plugin/src/main/java/org/sonar/xoo/scm/XooBlameCommand.java b/plugins/sonar-xoo-plugin/src/main/java/org/sonar/xoo/scm/XooBlameCommand.java index b78deb2812c..0d1c978e0de 100644 --- a/plugins/sonar-xoo-plugin/src/main/java/org/sonar/xoo/scm/XooBlameCommand.java +++ b/plugins/sonar-xoo-plugin/src/main/java/org/sonar/xoo/scm/XooBlameCommand.java @@ -54,7 +54,7 @@ public class XooBlameCommand extends BlameCommand { try { List lines = FileUtils.readLines(scmDataFile, Charsets.UTF_8.name()); - List blame = new ArrayList(lines.size()); + List blame = new ArrayList<>(lines.size()); int lineNumber = 0; for (String line : lines) { lineNumber++; diff --git a/server/sonar-process-monitor/src/main/java/org/sonar/process/monitor/JavaCommand.java b/server/sonar-process-monitor/src/main/java/org/sonar/process/monitor/JavaCommand.java index d4b774cb851..baeb769d337 100644 --- a/server/sonar-process-monitor/src/main/java/org/sonar/process/monitor/JavaCommand.java +++ b/server/sonar-process-monitor/src/main/java/org/sonar/process/monitor/JavaCommand.java @@ -39,18 +39,18 @@ public class JavaCommand { private File workDir; // for example -Xmx1G - private final List javaOptions = new ArrayList(); + private final List javaOptions = new ArrayList<>(); // entry point private String className; // relative path to JAR files - private final List classpath = new ArrayList(); + private final List classpath = new ArrayList<>(); // program arguments (parameters of main(String[]) - private final Map arguments = new LinkedHashMap(); + private final Map arguments = new LinkedHashMap<>(); - private final Map envVariables = new HashMap(System.getenv()); + private final Map envVariables = new HashMap<>(System.getenv()); private File tempDir = null; diff --git a/server/sonar-process-monitor/src/main/java/org/sonar/process/monitor/JavaProcessLauncher.java b/server/sonar-process-monitor/src/main/java/org/sonar/process/monitor/JavaProcessLauncher.java index dd67a10489d..1e3ee06648e 100644 --- a/server/sonar-process-monitor/src/main/java/org/sonar/process/monitor/JavaProcessLauncher.java +++ b/server/sonar-process-monitor/src/main/java/org/sonar/process/monitor/JavaProcessLauncher.java @@ -64,7 +64,7 @@ public class JavaProcessLauncher { } private ProcessBuilder create(JavaCommand javaCommand) { - List commands = new ArrayList(); + List commands = new ArrayList<>(); commands.add(buildJavaPath()); commands.addAll(javaCommand.getJavaOptions()); // TODO warning - does it work if temp dir contains a whitespace ? diff --git a/server/sonar-process-monitor/src/main/java/org/sonar/process/monitor/Monitor.java b/server/sonar-process-monitor/src/main/java/org/sonar/process/monitor/Monitor.java index fd546b9df5d..df3d53518ee 100644 --- a/server/sonar-process-monitor/src/main/java/org/sonar/process/monitor/Monitor.java +++ b/server/sonar-process-monitor/src/main/java/org/sonar/process/monitor/Monitor.java @@ -30,7 +30,7 @@ import java.util.concurrent.CopyOnWriteArrayList; public class Monitor { - private final List processes = new CopyOnWriteArrayList(); + private final List processes = new CopyOnWriteArrayList<>(); private final TerminatorThread terminator; private final JavaProcessLauncher launcher; private final Lifecycle lifecycle = new Lifecycle(); @@ -39,7 +39,7 @@ public class Monitor { private Thread shutdownHook = new Thread(new MonitorShutdownHook(), "Monitor Shutdown Hook"); // used by awaitStop() to block until all processes are shutdown - private final List watcherThreads = new CopyOnWriteArrayList(); + private final List watcherThreads = new CopyOnWriteArrayList<>(); static int nextProcessId = 0; Monitor(JavaProcessLauncher launcher, SystemExit exit, TerminatorThread terminator) { diff --git a/server/sonar-process/src/main/java/org/sonar/process/Encryption.java b/server/sonar-process/src/main/java/org/sonar/process/Encryption.java index cca05e6c780..fe9d66ec08f 100644 --- a/server/sonar-process/src/main/java/org/sonar/process/Encryption.java +++ b/server/sonar-process/src/main/java/org/sonar/process/Encryption.java @@ -37,7 +37,7 @@ public final class Encryption { private static final String AES_ALGORITHM = "aes"; private final AesCipher aesCipher; - private final Map ciphers = new HashMap(); + private final Map ciphers = new HashMap<>(); private static final Pattern ENCRYPTED_PATTERN = Pattern.compile("\\{(.*?)\\}(.*)"); public Encryption(@Nullable String pathToSecretKey) { diff --git a/server/sonar-process/src/main/java/org/sonar/process/MinimumViableSystem.java b/server/sonar-process/src/main/java/org/sonar/process/MinimumViableSystem.java index 2389fa5aa18..fdbc7217611 100644 --- a/server/sonar-process/src/main/java/org/sonar/process/MinimumViableSystem.java +++ b/server/sonar-process/src/main/java/org/sonar/process/MinimumViableSystem.java @@ -29,7 +29,7 @@ import java.util.Map; public class MinimumViableSystem { - private final Map requiredJavaOptions = new HashMap(); + private final Map requiredJavaOptions = new HashMap<>(); public MinimumViableSystem setRequiredJavaOption(String propertyKey, String expectedValue) { requiredJavaOptions.put(propertyKey, expectedValue); diff --git a/server/sonar-search/src/main/java/org/sonar/search/script/ListUpdate.java b/server/sonar-search/src/main/java/org/sonar/search/script/ListUpdate.java index 587825f60f5..d93ae29b515 100644 --- a/server/sonar-search/src/main/java/org/sonar/search/script/ListUpdate.java +++ b/server/sonar-search/src/main/java/org/sonar/search/script/ListUpdate.java @@ -99,7 +99,7 @@ public class ListUpdate extends AbstractExecutableScript { if (fieldValue == null && value != null) { // 0. The field does not exist (this is a upsert then) - List values = new ArrayList(1); + List values = new ArrayList<>(1); values.add(value); source.put(field, values); } else if (!XContentMapValues.isArray(fieldValue) && value != null) { @@ -108,7 +108,7 @@ public class ListUpdate extends AbstractExecutableScript { if (XContentMapValues.nodeStringValue(currentFieldValue.get(idField), null).equals(idValue)) { source.put(field, value); } else { - List values = new ArrayList(2); + List values = new ArrayList<>(2); values.add(fieldValue); values.add(value); source.put(field, values); diff --git a/server/sonar-search/src/test/java/org/sonar/search/script/UpdateListScriptTest.java b/server/sonar-search/src/test/java/org/sonar/search/script/UpdateListScriptTest.java index 06c2c355c73..360f8a4d021 100644 --- a/server/sonar-search/src/test/java/org/sonar/search/script/UpdateListScriptTest.java +++ b/server/sonar-search/src/test/java/org/sonar/search/script/UpdateListScriptTest.java @@ -43,7 +43,7 @@ public class UpdateListScriptTest { @Test public void fail_missing_attributes_field() { - Map params = new HashMap(); + Map params = new HashMap<>(); // Missing everything try { @@ -105,11 +105,11 @@ public class UpdateListScriptTest { String listField = "listField"; Collection> mapFields; - Map source = new HashMap(); + Map source = new HashMap<>(); source.put("field1", "value1"); // 0 Create list when field does not exists - Map params = new HashMap(); + Map params = new HashMap<>(); params.put(ProcessProperties.ES_PLUGIN_LISTUPDATE_FIELD, listField); params.put(ProcessProperties.ES_PLUGIN_LISTUPDATE_ID_FIELD, "key"); params.put(ProcessProperties.ES_PLUGIN_LISTUPDATE_ID_VALUE, "1"); @@ -124,7 +124,7 @@ public class UpdateListScriptTest { assertThat(mapFields).hasSize(1); // Add item to existing list - params = new HashMap(); + params = new HashMap<>(); params.put(ProcessProperties.ES_PLUGIN_LISTUPDATE_FIELD, listField); params.put(ProcessProperties.ES_PLUGIN_LISTUPDATE_ID_FIELD, "key"); params.put(ProcessProperties.ES_PLUGIN_LISTUPDATE_ID_VALUE, "2"); @@ -136,7 +136,7 @@ public class UpdateListScriptTest { assertThat(mapFields).hasSize(2); // updated first item in list - params = new HashMap(); + params = new HashMap<>(); params.put(ProcessProperties.ES_PLUGIN_LISTUPDATE_FIELD, listField); params.put(ProcessProperties.ES_PLUGIN_LISTUPDATE_ID_FIELD, "key"); params.put(ProcessProperties.ES_PLUGIN_LISTUPDATE_ID_VALUE, "1"); @@ -148,7 +148,7 @@ public class UpdateListScriptTest { assertThat(mapFields).hasSize(2); // updated second item in list - params = new HashMap(); + params = new HashMap<>(); params.put(ProcessProperties.ES_PLUGIN_LISTUPDATE_FIELD, listField); params.put(ProcessProperties.ES_PLUGIN_LISTUPDATE_ID_FIELD, "key"); params.put(ProcessProperties.ES_PLUGIN_LISTUPDATE_ID_VALUE, "2"); @@ -160,7 +160,7 @@ public class UpdateListScriptTest { assertThat(mapFields).hasSize(2); // delete first item - params = new HashMap(); + params = new HashMap<>(); params.put(ProcessProperties.ES_PLUGIN_LISTUPDATE_FIELD, listField); params.put(ProcessProperties.ES_PLUGIN_LISTUPDATE_ID_FIELD, "key"); params.put(ProcessProperties.ES_PLUGIN_LISTUPDATE_ID_VALUE, "1"); @@ -173,7 +173,7 @@ public class UpdateListScriptTest { } private Map mapOf(String k, String v, String k1, String v1) { - Map map = new HashMap(); + Map map = new HashMap<>(); map.put(k, v); map.put(k1, v1); return map; diff --git a/server/sonar-server/src/main/java/org/sonar/server/db/BaseDao.java b/server/sonar-server/src/main/java/org/sonar/server/db/BaseDao.java index 1fe29ad23c4..e0875201856 100644 --- a/server/sonar-server/src/main/java/org/sonar/server/db/BaseDao.java +++ b/server/sonar-server/src/main/java/org/sonar/server/db/BaseDao.java @@ -251,7 +251,7 @@ public abstract class BaseDao, KEY extends Serializ try { doInsert(session, item); if (hasIndex()) { - session.enqueue(new UpsertDto(getIndexType(), item)); + session.enqueue(new UpsertDto<>(getIndexType(), item)); } } catch (Exception e) { throw new IllegalStateException("Fail to insert item in db: " + item, e); @@ -281,7 +281,7 @@ public abstract class BaseDao, KEY extends Serializ try { doDeleteByKey(session, key); if (hasIndex()) { - session.enqueue(new DeleteKey(getIndexType(), key)); + session.enqueue(new DeleteKey<>(getIndexType(), key)); } } catch (Exception e) { throw new IllegalStateException("Fail to delete item from db: " + key, e); @@ -290,14 +290,14 @@ public abstract class BaseDao, KEY extends Serializ protected final void enqueueUpdate(Object nestedItem, KEY key, DbSession session) { if (hasIndex()) { - session.enqueue(new UpsertNestedItem( + session.enqueue(new UpsertNestedItem<>( this.getIndexType(), key, nestedItem)); } } public void enqueueDelete(Object nestedItem, KEY key, DbSession session) { if (hasIndex()) { - session.enqueue(new DeleteNestedItem( + session.enqueue(new DeleteNestedItem<>( this.getIndexType(), key, nestedItem)); session.commit(); } @@ -329,7 +329,7 @@ public abstract class BaseDao, KEY extends Serializ public void handleResult(ResultContext resultContext) { DTO dto = (DTO) resultContext.getResultObject(); // session.enqueue(new UpsertDto(getIndexType(), dto, false)); - getSession().enqueue(new InsertDto(getIndexType(), dto, false)); + getSession().enqueue(new InsertDto<>(getIndexType(), dto, false)); count++; if (count % 100000 == 0) { LOGGER.info("Synchronized {} {}", count, getIndexType()); diff --git a/server/sonar-server/src/main/java/org/sonar/server/db/migrations/SelectImpl.java b/server/sonar-server/src/main/java/org/sonar/server/db/migrations/SelectImpl.java index a433b473e4a..62ad570ded6 100644 --- a/server/sonar-server/src/main/java/org/sonar/server/db/migrations/SelectImpl.java +++ b/server/sonar-server/src/main/java/org/sonar/server/db/migrations/SelectImpl.java @@ -40,7 +40,7 @@ class SelectImpl extends BaseSqlStatement