From: Julien Lancelot <julien.lancelot@gmail.com>
Date: Mon, 3 Dec 2012 14:28:29 +0000 (+0100)
Subject: SONAR-3306 Improve unit test to fix issue on it-sonar-persistence tests
X-Git-Tag: 3.4~204
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=827c047c411d86101d08b8845a9395b5c1bfcdff;p=sonarqube.git

SONAR-3306 Improve unit test to fix issue on it-sonar-persistence tests
---

diff --git a/sonar-core/src/test/java/org/sonar/core/persistence/SemaphoreDaoTest.java b/sonar-core/src/test/java/org/sonar/core/persistence/SemaphoreDaoTest.java
index 7f7a86d720a..30fd3363958 100644
--- a/sonar-core/src/test/java/org/sonar/core/persistence/SemaphoreDaoTest.java
+++ b/sonar-core/src/test/java/org/sonar/core/persistence/SemaphoreDaoTest.java
@@ -73,14 +73,12 @@ public class SemaphoreDaoTest extends AbstractDaoTestCase {
 
   @Test
   public void create_and_acquire_semaphore() throws Exception {
-    LOG.info("create_and_acquire_semaphore");
     SemaphoreDao dao = new SemaphoreDao(getMyBatis());
     Lock lock = dao.acquire("foo", 60);
     assertThat(lock.isAcquired()).isTrue();
     assertThat(lock.getDurationSinceLocked()).isNull();
 
     SemaphoreDto semaphore = selectSemaphore("foo");
-    LOG.info("semaphore : " + semaphore);
     assertThat(semaphore).isNotNull();
     assertThat(semaphore.getName()).isEqualTo("foo");
     assertThat(isRecent(semaphore.getCreatedAt())).isTrue();
@@ -239,13 +237,9 @@ public class SemaphoreDaoTest extends AbstractDaoTestCase {
   }
 
   private boolean isRecent(Date date) {
-    LOG.info("**** Date : " + date);
-    Date now = now();
-    LOG.info("**** Now : " + now);
-    Date dateInTheFuture = DateUtils.addDays(date, 1);
-    LOG.info("**** DateInTheFuture : " + dateInTheFuture);
-    LOG.info("date.before(now) -> " + date.before(now) + " && dateInTheFuture.after(date) -> " + dateInTheFuture.after(date));
-    return date.before(now) && dateInTheFuture.after(now);
+    Date futur = DateUtils.addDays(now(), 1);
+    Date past = DateUtils.addDays(now(), -1);
+    return date.after(past) && date.before(futur);
   }
 
   private Date now() {