From: Go MAEDA <maeda@farend.jp>
Date: Sun, 14 Mar 2021 03:14:49 +0000 (+0000)
Subject: Fix that column header is clickable even when the column is not actually sortable... 
X-Git-Tag: 4.2.0~54
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=83f3f454970870696b1b4acccafc30a0ca957f3f;p=redmine.git

Fix that column header is clickable even when the column is not actually sortable (#33548).

Patch by Vincent Robert and Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@20783 e93f8b46-1217-0410-a6f0-8f06a7374b81
---

diff --git a/app/models/query.rb b/app/models/query.rb
index f81f5782a..dc610f41e 100644
--- a/app/models/query.rb
+++ b/app/models/query.rb
@@ -51,7 +51,7 @@ class QueryColumn
 
   # Returns true if the column is sortable, otherwise false
   def sortable?
-    !@sortable.nil?
+    @sortable.present?
   end
 
   def sortable
diff --git a/test/unit/query_test.rb b/test/unit/query_test.rb
index a6dff724c..f590cd4dc 100644
--- a/test/unit/query_test.rb
+++ b/test/unit/query_test.rb
@@ -1707,6 +1707,16 @@ class QueryTest < ActiveSupport::TestCase
     assert !q.sortable_columns['cf_1']
   end
 
+  def test_sortable_should_return_false_for_multi_custom_field
+    field = CustomField.find(1)
+    field.update_attribute :multiple, true
+
+    q = IssueQuery.new
+
+    field_column = q.available_columns.detect {|c| c.name==:cf_1}
+    assert !field_column.sortable?
+  end
+
   def test_default_sort
     q = IssueQuery.new
     assert_equal [['id', 'desc']], q.sort_criteria