From: Pierre <pierre.guillot@sonarsource.com>
Date: Mon, 13 Dec 2021 09:04:44 +0000 (+0100)
Subject: SONAR-15768 switch 0/1 logic
X-Git-Tag: 9.3.0.51899~121
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=86fff2bc2be8624fdd7b88d6b6356769c418dd1d;p=sonarqube.git

SONAR-15768 switch 0/1 logic
---

diff --git a/server/sonar-webserver-monitoring/src/main/java/org/sonar/server/monitoring/ServerMonitoringMetrics.java b/server/sonar-webserver-monitoring/src/main/java/org/sonar/server/monitoring/ServerMonitoringMetrics.java
index ad69899ab92..255bab082ec 100644
--- a/server/sonar-webserver-monitoring/src/main/java/org/sonar/server/monitoring/ServerMonitoringMetrics.java
+++ b/server/sonar-webserver-monitoring/src/main/java/org/sonar/server/monitoring/ServerMonitoringMetrics.java
@@ -70,12 +70,12 @@ public class ServerMonitoringMetrics {
 
     computeEngineGauge = Gauge.build()
       .name("sonarqube_heath_compute_engine_status")
-      .help("Tells whether Compute Engine is up (healthy, ready to take tasks) or down. 0 for up, 1 for down")
+      .help("Tells whether Compute Engine is up (healthy, ready to take tasks) or down. 1 for up, 0 for down")
       .register();
 
     elasticsearchGauge = Gauge.build()
       .name("sonarqube_heath_elasticsearch_status")
-      .help("Tells whether Elasticsearch is up or down. 0 for Up, 1 for down")
+      .help("Tells whether Elasticsearch is up or down. 1 for Up, 0 for down")
       .register();
 
   }
@@ -121,18 +121,18 @@ public class ServerMonitoringMetrics {
   }
 
   public void setComputeEngineStatusToGreen() {
-    computeEngineGauge.set(0);
+    computeEngineGauge.set(1);
   }
 
   public void setComputeEngineStatusToRed() {
-    computeEngineGauge.set(1);
+    computeEngineGauge.set(0);
   }
 
   public void setElasticSearchStatusToGreen() {
-    elasticsearchGauge.set(0);
+    elasticsearchGauge.set(1);
   }
 
   public void setElasticSearchStatusToRed() {
-    elasticsearchGauge.set(1);
+    elasticsearchGauge.set(0);
   }
 }
diff --git a/server/sonar-webserver-monitoring/src/test/java/org/sonar/server/monitoring/ServerMonitoringMetricsTest.java b/server/sonar-webserver-monitoring/src/test/java/org/sonar/server/monitoring/ServerMonitoringMetricsTest.java
index 13b99bc7456..7e67a817141 100644
--- a/server/sonar-webserver-monitoring/src/test/java/org/sonar/server/monitoring/ServerMonitoringMetricsTest.java
+++ b/server/sonar-webserver-monitoring/src/test/java/org/sonar/server/monitoring/ServerMonitoringMetricsTest.java
@@ -60,8 +60,8 @@ public class ServerMonitoringMetricsTest {
     assertThat(CollectorRegistry.defaultRegistry.getSampleValue("gitlab_config_ok")).isZero();
     assertThat(CollectorRegistry.defaultRegistry.getSampleValue("bitbucket_config_ok")).isZero();
     assertThat(CollectorRegistry.defaultRegistry.getSampleValue("azure_config_ok")).isZero();
-    assertThat(CollectorRegistry.defaultRegistry.getSampleValue("sonarqube_heath_compute_engine_status")).isZero();
-    assertThat(CollectorRegistry.defaultRegistry.getSampleValue("sonarqube_heath_elasticsearch_status")).isZero();
+    assertThat(CollectorRegistry.defaultRegistry.getSampleValue("sonarqube_heath_compute_engine_status")).isPositive();
+    assertThat(CollectorRegistry.defaultRegistry.getSampleValue("sonarqube_heath_elasticsearch_status")).isPositive();
   }
 
   @Test
@@ -79,8 +79,8 @@ public class ServerMonitoringMetricsTest {
     assertThat(CollectorRegistry.defaultRegistry.getSampleValue("gitlab_config_ok")).isEqualTo(1);
     assertThat(CollectorRegistry.defaultRegistry.getSampleValue("bitbucket_config_ok")).isEqualTo(1);
     assertThat(CollectorRegistry.defaultRegistry.getSampleValue("azure_config_ok")).isEqualTo(1);
-    assertThat(CollectorRegistry.defaultRegistry.getSampleValue("sonarqube_heath_compute_engine_status")).isEqualTo(1);
-    assertThat(CollectorRegistry.defaultRegistry.getSampleValue("sonarqube_heath_elasticsearch_status")).isEqualTo(1);
+    assertThat(CollectorRegistry.defaultRegistry.getSampleValue("sonarqube_heath_compute_engine_status")).isZero();
+    assertThat(CollectorRegistry.defaultRegistry.getSampleValue("sonarqube_heath_elasticsearch_status")).isZero();
   }
 
   @Test
diff --git a/server/sonar-webserver-webapi/src/main/java/org/sonar/server/platform/ws/SafeModeMonitoringMetricAction.java b/server/sonar-webserver-webapi/src/main/java/org/sonar/server/platform/ws/SafeModeMonitoringMetricAction.java
index 87d6c75c0ce..29263a32a30 100644
--- a/server/sonar-webserver-webapi/src/main/java/org/sonar/server/platform/ws/SafeModeMonitoringMetricAction.java
+++ b/server/sonar-webserver-webapi/src/main/java/org/sonar/server/platform/ws/SafeModeMonitoringMetricAction.java
@@ -37,7 +37,8 @@ import static java.nio.charset.StandardCharsets.UTF_8;
 
 public class SafeModeMonitoringMetricAction implements MonitoringWsAction {
 
-  protected static final Gauge isWebUpGauge = Gauge.build().name("sonarqube_heath_web_status").help("Tells whether web service is up").register();
+  protected static final Gauge isWebUpGauge = Gauge.build().name("sonarqube_heath_web_status")
+    .help("Tells whether Web process is up or down. 1 for up, 0 for down").register();
 
   private final SystemPasscode systemPasscode;
   private final BearerPasscode bearerPasscode;
@@ -50,7 +51,7 @@ public class SafeModeMonitoringMetricAction implements MonitoringWsAction {
   @Override
   public void define(WebService.NewController context) {
     context.createAction("metrics").setHandler(this);
-    isWebUpGauge.set(0D);
+    isWebUpGauge.set(1D);
   }
 
   @Override