From: jaubourg <j@ubourg.net>
Date: Wed, 25 Apr 2012 16:18:44 +0000 (+0200)
Subject: Callbacks.add now accepts array-like objects (like Arguments). Now uses the slice... 
X-Git-Tag: 1.8b1~181
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=87c83b04589e91a96adcfce788c6207295f83a5b;p=jquery.git

Callbacks.add now accepts array-like objects (like Arguments). Now uses the slice method of the args array in fireWith rather than a quite slow jQuery.merge.
---

diff --git a/src/callbacks.js b/src/callbacks.js
index 42f9315e9..b3b1c8a69 100644
--- a/src/callbacks.js
+++ b/src/callbacks.js
@@ -94,12 +94,11 @@ jQuery.Callbacks = function( options ) {
 					var start = list.length;
 					(function add( args ) {
 						jQuery.each( args, function( _, arg ) {
-							var type;
-							if ( ( type = jQuery.type(arg) ) === "array" ) {
+							if ( jQuery.isFunction( arg ) && ( !options.unique || !self.has( arg ) ) ) {
+								list.push( arg );
+							} else if ( arg && arg.length ) {
 								// Inspect recursively
 								add( arg );
-							} else if ( type === "function" && ( !options.unique || !self.has( arg ) ) ) {
-								list.push( arg );
 							}
 						});
 					})( arguments );
@@ -121,7 +120,7 @@ jQuery.Callbacks = function( options ) {
 			remove: function() {
 				if ( list ) {
 					jQuery.each( arguments, function( _, arg ) {
-						var index = 0;
+						var index;
 						while( ( index = jQuery.inArray( arg, list, index ) ) > -1 ) {
 							list.splice( index, 1 );
 							// Handle firing indexes
@@ -170,7 +169,8 @@ jQuery.Callbacks = function( options ) {
 			},
 			// Call all callbacks with the given context and arguments
 			fireWith: function( context, args ) {
-				args = [ context, jQuery.merge( [], args || [] ) ];
+				args = args || [];
+				args = [ context, args.slice ? args.slice() : args ];
 				if ( list && ( !fired || stack ) ) {
 					if ( firing ) {
 						stack.push( args );