From: Jean-Baptiste Lievremont <jean-baptiste.lievremont@sonarsource.com>
Date: Mon, 27 Oct 2014 09:03:16 +0000 (+0100)
Subject: Fix quality flaws
X-Git-Tag: 5.0-RC1~570
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=8dd85509938421f9be97a895c8f907fd6d7cedb3;p=sonarqube.git

Fix quality flaws
---

diff --git a/server/sonar-server/src/main/java/org/sonar/server/issue/ws/SearchAction.java b/server/sonar-server/src/main/java/org/sonar/server/issue/ws/SearchAction.java
index b065883f0ca..0a4bc20d5bb 100644
--- a/server/sonar-server/src/main/java/org/sonar/server/issue/ws/SearchAction.java
+++ b/server/sonar-server/src/main/java/org/sonar/server/issue/ws/SearchAction.java
@@ -240,19 +240,17 @@ public class SearchAction extends SearchRequestHandler<IssueQuery, Issue> {
       }
     }
 
-    for (FacetValue rule: result.getFacetValues(IssueFilterParameters.RULES)) {
-      ruleKeys.add(RuleKey.parse(rule.getKey()));
-    }
-    for (FacetValue project: result.getFacetValues(IssueFilterParameters.COMPONENT_ROOTS)) {
-      projectUuids.add(project.getKey());
-    }
-    for (FacetValue component: result.getFacetValues(IssueFilterParameters.COMPONENTS)) {
-      componentUuids.add(component.getKey());
-    }
-    for (FacetValue user: result.getFacetValues(IssueFilterParameters.ASSIGNEES)) {
-      userLogins.add(user.getKey());
+    Collection<FacetValue> facetRules = result.getFacetValues(IssueFilterParameters.RULES);
+    if (facetRules != null) {
+      for (FacetValue rule: facetRules) {
+        ruleKeys.add(RuleKey.parse(rule.getKey()));
+      }
     }
 
+    collectFacetKeys(result, IssueFilterParameters.COMPONENT_ROOTS, projectUuids);
+    collectFacetKeys(result, IssueFilterParameters.COMPONENTS, componentUuids);
+    collectFacetKeys(result, IssueFilterParameters.ASSIGNEES, userLogins);
+
     DbSession session = dbClient.openSession(false);
     try {
       List<DefaultIssueComment> comments = issueChangeDao.selectCommentsByIssues(session, issueKeys);
@@ -293,6 +291,15 @@ public class SearchAction extends SearchRequestHandler<IssueQuery, Issue> {
     writeLegacyPaging(context, json, result);
   }
 
+  private void collectFacetKeys(Result<Issue> result, String facetName, Collection<String> facetKeys) {
+    Collection<FacetValue> facetValues = result.getFacetValues(facetName);
+    if (facetValues != null) {
+      for (FacetValue project: facetValues) {
+        facetKeys.add(project.getKey());
+      }
+    }
+  }
+
   private void writeLegacyPaging(QueryContext context, JsonWriter json, Result<?> result) {
     // TODO remove with stas on HTML side
     json.prop("maxResultsReached", false);