From: Jani Laakso <jani.laakso@itmill.com>
Date: Fri, 1 Feb 2008 08:20:20 +0000 (+0000)
Subject: Deprecated
X-Git-Tag: 6.7.0.beta1~5123
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=8f579807e7420ff573463cdc42186168ddca794e;p=vaadin-framework.git

Deprecated
 * public Button(String caption, Object target, String methodName)
 * public CheckBox(String caption, Object target, String methodName)
Reason: Using this method is discouraged because it cannot be checked during compilation. Java reflect is done through string variable. Error prone and this does not survive re-factoring (=> applications brake).

Typo fixes.

svn changeset:3693/svn branch:trunk
---

diff --git a/src/com/itmill/toolkit/event/MethodEventSource.java b/src/com/itmill/toolkit/event/MethodEventSource.java
index 9718bfcd68..e80cf80fcf 100644
--- a/src/com/itmill/toolkit/event/MethodEventSource.java
+++ b/src/com/itmill/toolkit/event/MethodEventSource.java
@@ -8,7 +8,7 @@ import java.lang.reflect.Method;
 
 /**
  * <p>
- * Interface for classes supporting registeration of methods as event receivers.
+ * Interface for classes supporting registration of methods as event receivers.
  * </p>
  * 
  * <p>
diff --git a/src/com/itmill/toolkit/ui/AbstractComponentContainer.java b/src/com/itmill/toolkit/ui/AbstractComponentContainer.java
index eaf3274de1..5251e99438 100644
--- a/src/com/itmill/toolkit/ui/AbstractComponentContainer.java
+++ b/src/com/itmill/toolkit/ui/AbstractComponentContainer.java
@@ -31,7 +31,7 @@ public abstract class AbstractComponentContainer extends AbstractComponent
 
     /**
      * Removes all components from the container. This should probably be
-     * reimplemented in extending classes for a more powerfull implementation.
+     * re-implemented in extending classes for a more powerful implementation.
      */
     public void removeAllComponents() {
         final LinkedList l = new LinkedList();
diff --git a/src/com/itmill/toolkit/ui/Button.java b/src/com/itmill/toolkit/ui/Button.java
index 5f8a00de8e..605cac85b7 100644
--- a/src/com/itmill/toolkit/ui/Button.java
+++ b/src/com/itmill/toolkit/ui/Button.java
@@ -74,6 +74,10 @@ public class Button extends AbstractField {
      * @param methodName
      *                the name of the method in target object, that receives
      *                button click events.
+     * @deprecated Use
+     *             {@link #Button(String, com.itmill.toolkit.ui.Button.ClickListener)}
+     *             instead. Using this method is discouraged because it cannot
+     *             be checked during compilation.
      */
     public Button(String caption, Object target, String methodName) {
         this(caption);
diff --git a/src/com/itmill/toolkit/ui/CheckBox.java b/src/com/itmill/toolkit/ui/CheckBox.java
index 97558e4fc0..12edb77bff 100644
--- a/src/com/itmill/toolkit/ui/CheckBox.java
+++ b/src/com/itmill/toolkit/ui/CheckBox.java
@@ -4,6 +4,8 @@
 
 package com.itmill.toolkit.ui;
 
+import java.lang.reflect.Method;
+
 import com.itmill.toolkit.data.Property;
 
 public class CheckBox extends Button {
@@ -54,6 +56,10 @@ public class CheckBox extends Button {
      * @param methodName
      *                the name of the method in target object, that receives
      *                button click events.
+     * @deprecated Use {@link #addListener(Class, Object, Method)} or
+     *             {@link #addListener(com.itmill.toolkit.ui.Component.Listener)}
+     *             instead. Using this method is discouraged because it cannot
+     *             be checked during compilation.
      */
     public CheckBox(String caption, Object target, String methodName) {
         setCaption(caption);