From: Sébastien Lesaint <sebastien.lesaint@sonarsource.com>
Date: Fri, 9 Feb 2018 15:36:23 +0000 (+0100)
Subject: Merge branch 'branch-6.7'
X-Git-Tag: 7.5~1666
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=916f7021154eae9c7c88f0f219884d972573209c;p=sonarqube.git

Merge branch 'branch-6.7'
---

916f7021154eae9c7c88f0f219884d972573209c
diff --cc server/sonar-db-dao/src/test/java/org/sonar/db/rule/RuleDaoTest.java
index 957375812d0,22cc745f840..b585954a785
--- a/server/sonar-db-dao/src/test/java/org/sonar/db/rule/RuleDaoTest.java
+++ b/server/sonar-db-dao/src/test/java/org/sonar/db/rule/RuleDaoTest.java
@@@ -46,11 -44,10 +46,12 @@@ import org.sonar.db.RowNotFoundExceptio
  import org.sonar.db.es.RuleExtensionId;
  import org.sonar.db.organization.OrganizationDto;
  import org.sonar.db.organization.OrganizationTesting;
 +import org.sonar.db.rule.RuleDto.Scope;
  
+ import static com.google.common.collect.ImmutableSet.of;
  import static com.google.common.collect.Sets.newHashSet;
  import static java.util.Arrays.asList;
 +import static java.util.Collections.emptyList;
  import static java.util.Collections.singletonList;
  import static org.apache.commons.lang.RandomStringUtils.randomAlphanumeric;
  import static org.assertj.core.api.Assertions.assertThat;
diff --cc server/sonar-server/src/main/java/org/sonar/server/rule/CachingRuleFinder.java
index bed8c761474,36a25efd1ca..da5e850067e
--- a/server/sonar-server/src/main/java/org/sonar/server/rule/CachingRuleFinder.java
+++ b/server/sonar-server/src/main/java/org/sonar/server/rule/CachingRuleFinder.java
@@@ -174,7 -175,9 +174,8 @@@ public class CachingRuleFinder implemen
        .setRepositoryKey(ruleDefinition.getRepositoryKey())
        .setSeverity(severity != null ? RulePriority.valueOf(severity) : null)
        .setStatus(ruleDefinition.getStatus().name())
-       .setTags(ruleDefinition.getSystemTags().toArray(new String[ruleDefinition.getSystemTags().size()]))
 -      .setSystemTags(systemTags)
 -      // FIXME tags should contain user defined tags and we can't provide them without organization => tags should return []
 -      .setTags(systemTags)
++      .setSystemTags(ruleDefinition.getSystemTags().toArray(new String[ruleDefinition.getSystemTags().size()]))
++      .setTags(new String[0])
        .setId(ruleDefinition.getId());
      if (description != null && descriptionFormat != null) {
        if (RuleDto.Format.HTML.equals(descriptionFormat)) {
diff --cc server/sonar-server/src/test/java/org/sonar/server/rule/CachingRuleFinderTest.java
index 7bc6af5db42,b4e7bf3a9bc..ee0287a318a
--- a/server/sonar-server/src/test/java/org/sonar/server/rule/CachingRuleFinderTest.java
+++ b/server/sonar-server/src/test/java/org/sonar/server/rule/CachingRuleFinderTest.java
@@@ -408,7 -408,9 +408,8 @@@ public class CachingRuleFinderTest 
      assertThat(rule.getUpdatedAt().getTime()).isEqualTo(ruleDefinition.getUpdatedAt());
      assertThat(rule.getRepositoryKey()).isEqualTo(ruleDefinition.getRepositoryKey());
      assertThat(rule.getSeverity().name()).isEqualTo(ruleDefinition.getSeverityString());
-     assertThat(rule.getTags()).isEqualTo(ruleDefinition.getSystemTags().stream().toArray(String[]::new));
 -    String[] systemTags = ruleDefinition.getSystemTags().stream().toArray(String[]::new);
 -    assertThat(rule.getSystemTags()).isEqualTo(systemTags);
 -    assertThat(rule.getTags()).isEqualTo(systemTags);
++    assertThat(rule.getSystemTags()).isEqualTo(ruleDefinition.getSystemTags().stream().toArray(String[]::new));
++    assertThat(rule.getTags()).isEmpty();
      assertThat(rule.getId()).isEqualTo(ruleDefinition.getId());
      assertThat(rule.getDescription()).isEqualTo(ruleDefinition.getDescription());
  
diff --cc server/sonar-server/src/test/java/org/sonar/server/rule/DefaultRuleFinderTest.java
index 3727eea253e,138d6535861..a8e8f668d82
--- a/server/sonar-server/src/test/java/org/sonar/server/rule/DefaultRuleFinderTest.java
+++ b/server/sonar-server/src/test/java/org/sonar/server/rule/DefaultRuleFinderTest.java
@@@ -28,8 -29,9 +29,10 @@@ import org.sonar.api.utils.System2
  import org.sonar.db.DbClient;
  import org.sonar.db.DbSession;
  import org.sonar.db.DbTester;
+ import org.sonar.db.organization.OrganizationDto;
+ import org.sonar.db.rule.RuleDefinitionDto;
  import org.sonar.db.rule.RuleDto;
 +import org.sonar.db.rule.RuleDto.Scope;
  import org.sonar.server.organization.DefaultOrganizationProvider;
  import org.sonar.server.organization.TestDefaultOrganizationProvider;