From: Jean-Philippe Lang <jp_lang@yahoo.fr>
Date: Sun, 24 Jul 2011 16:48:26 +0000 (+0000)
Subject: Fixed: pagination do not show total visible issue count (#8633).
X-Git-Tag: 1.3.0~1629
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=9cebf65568f9c0867b546c213db47346a73b9d09;p=redmine.git

Fixed: pagination do not show total visible issue count (#8633).

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@6314 e93f8b46-1217-0410-a6f0-8f06a7374b81
---

diff --git a/app/models/query.rb b/app/models/query.rb
index 28e1a6d18..ad6a65eb5 100644
--- a/app/models/query.rb
+++ b/app/models/query.rb
@@ -510,7 +510,7 @@ class Query < ActiveRecord::Base
 
   # Returns the issue count
   def issue_count
-    Issue.count(:include => [:status, :project], :conditions => statement)
+    Issue.visible.count(:include => [:status, :project], :conditions => statement)
   rescue ::ActiveRecord::StatementInvalid => e
     raise StatementInvalid.new(e.message)
   end
diff --git a/test/unit/query_test.rb b/test/unit/query_test.rb
index 328acc489..9cba0cd64 100644
--- a/test/unit/query_test.rb
+++ b/test/unit/query_test.rb
@@ -471,7 +471,21 @@ class QueryTest < ActiveSupport::TestCase
       q.issues(:conditions => "foo = 1")
     end
   end
-  
+
+  def test_issue_count
+    q = Query.new(:name => '_')
+    issue_count = q.issue_count
+    assert_equal q.issues.size, issue_count
+  end
+
+  def test_issue_count_with_archived_issues
+    p = Project.generate!( :status => Project::STATUS_ARCHIVED )
+    i = Issue.generate!( :project => p, :tracker => p.trackers.first )
+    assert !i.visible?
+
+    test_issue_count
+  end
+
   def test_issue_count_by_association_group
     q = Query.new(:name => '_', :group_by => 'assigned_to')
     count_by_group = q.issue_count_by_group