From: Johannes Dahlström <johannes.dahlstrom@vaadin.com>
Date: Fri, 16 Dec 2011 12:47:56 +0000 (+0000)
Subject: #8040 Improved comment
X-Git-Tag: 7.0.0.alpha2~485^2~48
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=a79c9749fc0adea7c5ed7163d210c501984b05e9;p=vaadin-framework.git

#8040 Improved comment

svn changeset:22424/svn branch:6.7
---

diff --git a/src/com/vaadin/terminal/gwt/client/ui/VScrollTable.java b/src/com/vaadin/terminal/gwt/client/ui/VScrollTable.java
index d77507084d..553934bf98 100644
--- a/src/com/vaadin/terminal/gwt/client/ui/VScrollTable.java
+++ b/src/com/vaadin/terminal/gwt/client/ui/VScrollTable.java
@@ -4052,8 +4052,15 @@ public class VScrollTable extends FlowPanel implements Table, ScrollHandler,
                 reactLastRow = totalRows - 1;
             }
             if (lastRendered < reactFirstRow || firstRendered > reactLastRow) {
-                // #8040 - scroll position is completely changed
-                // TODO: should probably be done earlier
+                /*
+                 * #8040 - scroll position is completely changed since the
+                 * latest request, so request a new set of rows.
+                 * 
+                 * TODO: We should probably check whether the fetched rows match
+                 * the current scroll position right when they arrive, so as to
+                 * not waste time rendering a set of rows that will never be
+                 * visible...
+                 */
                 rowRequestHandler.setReqFirstRow(reactFirstRow);
                 rowRequestHandler.setReqRows(reactLastRow - reactFirstRow + 1);
                 rowRequestHandler.deferRowFetch(1);