From: Carl Schwan <carl@carlschwan.eu>
Date: Mon, 2 May 2022 19:46:42 +0000 (+0200)
Subject: Don't use slow hashing to check the LDAP binding
X-Git-Tag: v24.0.1rc1~21^2
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=a9e674bec043670e7a151b1a9430c38bac61f761;p=nextcloud-server.git

Don't use slow hashing to check the LDAP binding

Using password_hash is expensive and should be used for hashing
passwords when saving them in the database. Here we just want to see if
the bind was already done with the given password, so use a fast hashing
algorythm.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
---

diff --git a/apps/user_ldap/lib/Connection.php b/apps/user_ldap/lib/Connection.php
index 565fb415e58..89b58b7ebfd 100644
--- a/apps/user_ldap/lib/Connection.php
+++ b/apps/user_ldap/lib/Connection.php
@@ -128,7 +128,7 @@ class Connection extends LDAPUtility {
 	protected $ignoreValidation = false;
 
 	/**
-	 * @var array{dn?: mixed, hash?: string, result?: bool}
+	 * @var array{sum?: string, result?: bool}
 	 */
 	protected $bindResult = [];
 
@@ -672,11 +672,7 @@ class Connection extends LDAPUtility {
 
 		if (
 			count($this->bindResult) !== 0
-			&& $this->bindResult['dn'] === $this->configuration->ldapAgentName
-			&& \OC::$server->getHasher()->verify(
-				$this->configPrefix . $this->configuration->ldapAgentPassword,
-				$this->bindResult['hash']
-			)
+			&& $this->bindResult['sum'] === md5($this->configuration->ldapAgentName . $this->configPrefix . $this->configuration->ldapAgentPassword)
 		) {
 			// don't attempt to bind again with the same data as before
 			// bind might have been invoked via getConnectionResource(),
@@ -689,8 +685,7 @@ class Connection extends LDAPUtility {
 										$this->configuration->ldapAgentPassword);
 
 		$this->bindResult = [
-			'dn' => $this->configuration->ldapAgentName,
-			'hash' => \OC::$server->getHasher()->hash($this->configPrefix . $this->configuration->ldapAgentPassword),
+			'sum' => md5($this->configuration->ldapAgentName . $this->configPrefix . $this->configuration->ldapAgentPassword),
 			'result' => $ldapLogin,
 		];