From: PJ Fanning Date: Thu, 25 Aug 2022 19:22:28 +0000 (+0000) Subject: sonar issues X-Git-Tag: REL_5_2_3~35 X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=aa8c73ea4a9c70d5c8704557519a7ed0667a434c;p=poi.git sonar issues git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1903688 13f79535-47bb-0310-9956-ffa450edef68 --- diff --git a/poi/src/main/java/org/apache/poi/ss/format/CellDateFormatter.java b/poi/src/main/java/org/apache/poi/ss/format/CellDateFormatter.java index f408450b48..24a95b023f 100644 --- a/poi/src/main/java/org/apache/poi/ss/format/CellDateFormatter.java +++ b/poi/src/main/java/org/apache/poi/ss/format/CellDateFormatter.java @@ -44,7 +44,7 @@ public class CellDateFormatter extends CellFormatter { private static final int NUM_MILLISECONDS_IN_DAY = 1000 * 60 * 60 * 24; - private static /* final */ volatile CellDateFormatter SIMPLE_DATE; + private static CellDateFormatter SIMPLE_DATE_FORMATTER; class DatePartHandler implements CellFormatPart.PartHandler { private int mStart = -1; @@ -242,12 +242,12 @@ public class CellDateFormatter extends CellFormatter { */ @Override public void simpleValue(StringBuffer toAppendTo, Object value) { - CellDateFormatter cellDateFormatter = SIMPLE_DATE; + CellDateFormatter cellDateFormatter = SIMPLE_DATE_FORMATTER; if (cellDateFormatter == null) { synchronized (CellDateFormatter.class) { - cellDateFormatter = SIMPLE_DATE; + cellDateFormatter = SIMPLE_DATE_FORMATTER; if (cellDateFormatter == null) { - SIMPLE_DATE = cellDateFormatter = new CellDateFormatter("mm/d/y"); + SIMPLE_DATE_FORMATTER = cellDateFormatter = new CellDateFormatter("mm/d/y"); } } }