From: Pierre Ossman <ossman@cendio.se>
Date: Thu, 26 Mar 2020 07:50:04 +0000 (+0100)
Subject: Avoid using insecure variable length arrays
X-Git-Tag: v1.10.90~44
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=b0875cadc20e36c19490c5d8effd64c30e2d901b;p=tigervnc.git

Avoid using insecure variable length arrays
---

diff --git a/common/rdr/Exception.cxx b/common/rdr/Exception.cxx
index 9b6096b6..f4e23836 100644
--- a/common/rdr/Exception.cxx
+++ b/common/rdr/Exception.cxx
@@ -57,10 +57,11 @@ GAIException::GAIException(const char* s, int err)
 {
   strncat(str_, ": ", len-1-strlen(str_));
 #ifdef _WIN32
-  wchar_t currStr[len-strlen(str_)];
+  wchar_t *currStr = new wchar_t[len-strlen(str_)];
   wcsncpy(currStr, gai_strerrorW(err), len-1-strlen(str_));
   WideCharToMultiByte(CP_UTF8, 0, currStr, -1, str_+strlen(str_),
                       len-1-strlen(str_), 0, 0);
+  delete [] currStr;
 #else
   //FIXME: perhaps print the error number (NNNN)
   strncat(str_, gai_strerror(err), len-1-strlen(str_));