From: Vsevolod Stakhov <vsevolod@highsecure.ru>
Date: Mon, 17 Oct 2016 09:25:37 +0000 (+0100)
Subject: [Fix] Explicitly ban default passwords in webui
X-Git-Tag: 1.4.0~251
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=b5582a8c06de7fb8625b5d61a4663b9032f7c455;p=rspamd.git

[Fix] Explicitly ban default passwords in webui
---

diff --git a/src/controller.c b/src/controller.c
index ed990c898..ba6ee7561 100644
--- a/src/controller.c
+++ b/src/controller.c
@@ -512,6 +512,13 @@ static gboolean rspamd_controller_check_password(
 		ret = FALSE;
 	}
 	else {
+		if (rspamd_ftok_cstr_equal (password, "q1", FALSE) ||
+				rspamd_ftok_cstr_equal (password, "q2", FALSE)) {
+			msg_info_session ("deny default password for remote access");
+			ret = FALSE;
+			goto end;
+		}
+
 		if (is_enable) {
 			/* For privileged commands we strictly require enable password */
 			if (ctx->enable_password != NULL) {
@@ -542,10 +549,6 @@ static gboolean rspamd_controller_check_password(
 			else {
 				msg_warn_session (
 						"no password to check while executing a privileged command");
-				if (ctx->secure_map) {
-					msg_info("deny unauthorized connection");
-					ret = FALSE;
-				}
 				ret = FALSE;
 			}
 		}
@@ -598,15 +601,16 @@ static gboolean rspamd_controller_check_password(
 		}
 	}
 
-	if (query_args != NULL) {
-		g_hash_table_unref (query_args);
-	}
-
 	if (check_normal == FALSE && check_enable == FALSE) {
 		msg_info ("absent or incorrect password has been specified");
 		ret = FALSE;
 	}
 
+end:
+	if (query_args != NULL) {
+		g_hash_table_unref (query_args);
+	}
+
 	if (!ret) {
 		rspamd_controller_send_error (entry, 403, "Unauthorized");
 	}