From: Jean-Philippe Lang Date: Mon, 23 Feb 2015 10:11:08 +0000 (+0000) Subject: Removed unneeded #h calls in views. X-Git-Tag: 3.1.0~230 X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=b778c51e9049ca2c0d745a699db6d93d53b71175;p=redmine.git Removed unneeded #h calls in views. git-svn-id: http://svn.redmine.org/redmine/trunk@14043 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- diff --git a/app/views/activities/index.html.erb b/app/views/activities/index.html.erb index c6fd357c7..0a996a052 100644 --- a/app/views/activities/index.html.erb +++ b/app/views/activities/index.html.erb @@ -9,7 +9,7 @@
<%= User.current.logged? && e.respond_to?(:event_author) && User.current == e.event_author ? 'me' : nil %>"> <%= avatar(e.event_author, :size => "24") if e.respond_to?(:event_author) %> <%= format_time(e.event_datetime, false) %> - <%= content_tag('span', h(e.project), :class => 'project') if @project.nil? || @project != e.project %> + <%= content_tag('span', e.project, :class => 'project') if @project.nil? || @project != e.project %> <%= link_to format_activity_title(e.event_title), e.event_url %>
"><%= format_activity_description(e.event_description) %> diff --git a/app/views/admin/plugins.html.erb b/app/views/admin/plugins.html.erb index 117735cdc..47c1dfade 100644 --- a/app/views/admin/plugins.html.erb +++ b/app/views/admin/plugins.html.erb @@ -4,11 +4,11 @@ <% @plugins.each do |plugin| %> - - + diff --git a/app/views/attachments/_links.html.erb b/app/views/attachments/_links.html.erb index 001a038db..0804b8002 100644 --- a/app/views/attachments/_links.html.erb +++ b/app/views/attachments/_links.html.erb @@ -11,7 +11,7 @@ :controller => 'attachments', :action => 'show', :id => attachment, :filename => attachment.filename %> <% end %> - <%= h(" - #{attachment.description}") unless attachment.description.blank? %> + <%= " - #{attachment.description}" unless attachment.description.blank? %> (<%= number_to_human_size attachment.filesize %>) <% if options[:deletable] %> <%= link_to image_tag('delete.png'), attachment_path(attachment), @@ -21,7 +21,7 @@ :title => l(:button_delete) %> <% end %> <% if options[:author] %> - <%= h(attachment.author) %>, <%= format_time(attachment.created_on) %> + <%= attachment.author %>, <%= format_time(attachment.created_on) %> <% end %>

<% end %> diff --git a/app/views/attachments/diff.html.erb b/app/views/attachments/diff.html.erb index b8fb69048..d125f82fd 100644 --- a/app/views/attachments/diff.html.erb +++ b/app/views/attachments/diff.html.erb @@ -1,7 +1,7 @@

<%=h @attachment.filename %>

-

<%= h("#{@attachment.description} - ") unless @attachment.description.blank? %> +

<%= "#{@attachment.description} - " unless @attachment.description.blank? %> <%= link_to_user(@attachment.author) %>, <%= format_time(@attachment.created_on) %>

<%= link_to_attachment @attachment, :text => l(:button_download), :download => true -%> (<%= number_to_human_size @attachment.filesize %>)

diff --git a/app/views/attachments/edit.html.erb b/app/views/attachments/edit.html.erb index c979c90ea..de089eae5 100644 --- a/app/views/attachments/edit.html.erb +++ b/app/views/attachments/edit.html.erb @@ -11,7 +11,7 @@
diff --git a/app/views/attachments/file.html.erb b/app/views/attachments/file.html.erb index 47cb7b1f9..e507ab648 100644 --- a/app/views/attachments/file.html.erb +++ b/app/views/attachments/file.html.erb @@ -1,7 +1,7 @@

<%=h @attachment.filename %>

-

<%= h("#{@attachment.description} - ") unless @attachment.description.blank? %> +

<%= "#{@attachment.description} - " unless @attachment.description.blank? %> <%= link_to_user(@attachment.author) %>, <%= format_time(@attachment.created_on) %>

<%= link_to_attachment @attachment, :text => l(:button_download), :download => true -%> (<%= number_to_human_size @attachment.filesize %>)

diff --git a/app/views/auth_sources/index.html.erb b/app/views/auth_sources/index.html.erb index ad84572d4..fcdbf7d43 100644 --- a/app/views/auth_sources/index.html.erb +++ b/app/views/auth_sources/index.html.erb @@ -15,10 +15,10 @@
<% for source in @auth_sources %> "> - - - - + + + + diff --git a/app/views/boards/show.html.erb b/app/views/boards/show.html.erb index f5e9b1295..7a599eae2 100644 --- a/app/views/boards/show.html.erb +++ b/app/views/boards/show.html.erb @@ -10,7 +10,7 @@ -

<%=h @board.name %>

-

<%=h @board.description %>

+

<%= @board.name %>

+

<%= @board.description %>

<% if @topics.any? %>
<%=h plugin.name %> - <%= content_tag('span', h(plugin.description), :class => 'description') unless plugin.description.blank? %> - <%= content_tag('span', link_to(h(plugin.url), plugin.url), :class => 'url') unless plugin.url.blank? %> + <%= plugin.name %> + <%= content_tag('span', plugin.description, :class => 'description') unless plugin.description.blank? %> + <%= content_tag('span', link_to(plugin.url, plugin.url), :class => 'url') unless plugin.url.blank? %> <%= plugin.author_url.blank? ? h(plugin.author) : link_to(h(plugin.author), plugin.author_url) %><%= plugin.author_url.blank? ? plugin.author : link_to(plugin.author, plugin.author_url) %> <%= plugin.version %> <%= link_to(l(:button_configure), plugin_settings_path(plugin)) if plugin.configurable? %>
<%= attachment.filename_was %> (<%= number_to_human_size attachment.filesize %>) - <%= h(attachment.author) %>, <%= format_time(attachment.created_on) %> + <%= attachment.author %>, <%= format_time(attachment.created_on) %>
<%= link_to(h(source.name), :action => 'edit', :id => source)%><%= h source.auth_method_name %><%= h source.host %><%= h source.users.count %><%= link_to(source.name, :action => 'edit', :id => source)%><%= source.auth_method_name %><%= source.host %><%= source.users.count %> <%= link_to l(:button_test), try_connection_auth_source_path(source), :class => 'icon icon-test' %> <%= delete_link auth_source_path(source) %> diff --git a/app/views/boards/index.html.erb b/app/views/boards/index.html.erb index 640b8a1a3..29074130b 100644 --- a/app/views/boards/index.html.erb +++ b/app/views/boards/index.html.erb @@ -11,7 +11,7 @@ <% Board.board_tree(@boards) do |board, level| %>
- <%= link_to h(board.name), project_board_path(board.project, board), :class => "board" %>
+ <%= link_to board.name, project_board_path(board.project, board), :class => "board" %>
<%=h board.description %>
<%= board.topics_count %>
@@ -36,7 +36,7 @@ <% @topics.each do |topic| %> - + diff --git a/app/views/calendars/show.html.erb b/app/views/calendars/show.html.erb index bfa8351d6..f18946027 100644 --- a/app/views/calendars/show.html.erb +++ b/app/views/calendars/show.html.erb @@ -1,4 +1,4 @@ -

<%= @query.new_record? ? l(:label_calendar) : h(@query.name) %>

+

<%= @query.new_record? ? l(:label_calendar) : @query.name %>

<%= form_tag({:controller => 'calendars', :action => 'show', :project_id => @project}, :method => :get, :id => 'query_form') do %> diff --git a/app/views/common/_calendar.html.erb b/app/views/common/_calendar.html.erb index 7951b68ce..d950749aa 100644 --- a/app/views/common/_calendar.html.erb +++ b/app/views/common/_calendar.html.erb @@ -12,13 +12,13 @@ while day <= calendar.enddt %> <% calendar.events_on(day).each do |i| %> <% if i.is_a? Issue %>
- <%= h("#{i.project} -") unless @project && @project == i.project %> + <%= "#{i.project} -" unless @project && @project == i.project %> <%= link_to_issue i, :truncate => 30 %> <%= render_issue_tooltip i %>
<% else %> - <%= h("#{i.project} -") unless @project && @project == i.project %> + <%= "#{i.project} -" unless @project && @project == i.project %> <%= link_to_version i%> <% end %> diff --git a/app/views/common/error.html.erb b/app/views/common/error.html.erb index 5bb43dea0..a5ec39c3a 100644 --- a/app/views/common/error.html.erb +++ b/app/views/common/error.html.erb @@ -1,7 +1,7 @@ -

<%=h @status %>

+

<%= @status %>

<% if @message.present? %> -

<%=h @message %>

+

<%= @message %>

<% end %>

<%= l(:button_back) %>

diff --git a/app/views/context_menus/issues.html.erb b/app/views/context_menus/issues.html.erb index 65ddb002b..48be73b02 100644 --- a/app/views/context_menus/issues.html.erb +++ b/app/views/context_menus/issues.html.erb @@ -14,7 +14,7 @@ <%= l(:field_status) %> @@ -26,7 +26,7 @@ <%= l(:field_tracker) %> @@ -38,7 +38,7 @@ <%= l(:field_priority) %> @@ -68,7 +68,7 @@ :disabled => !@can[:edit] %> <% end %> <% @assignables.each do |u| -%> -
  • <%= context_menu_link h(u.name), bulk_update_issues_path(:ids => @issue_ids, :issue => {'assigned_to_id' => u}, :back_url => @back), :method => :post, +
  • <%= context_menu_link u.name, bulk_update_issues_path(:ids => @issue_ids, :issue => {'assigned_to_id' => u}, :back_url => @back), :method => :post, :selected => (@issue && u == @issue.assigned_to), :disabled => !@can[:edit] %>
  • <% end -%>
  • <%= context_menu_link l(:label_nobody), bulk_update_issues_path(:ids => @issue_ids, :issue => {'assigned_to_id' => 'none'}, :back_url => @back), :method => :post, @@ -82,7 +82,7 @@ <%= l(:field_category) %>
      <% @project.issue_categories.each do |u| -%> -
    • <%= context_menu_link h(u.name), bulk_update_issues_path(:ids => @issue_ids, :issue => {'category_id' => u}, :back_url => @back), :method => :post, +
    • <%= context_menu_link u.name, bulk_update_issues_path(:ids => @issue_ids, :issue => {'category_id' => u}, :back_url => @back), :method => :post, :selected => (@issue && u == @issue.category), :disabled => !@can[:edit] %>
    • <% end -%>
    • <%= context_menu_link l(:label_none), bulk_update_issues_path(:ids => @issue_ids, :issue => {'category_id' => 'none'}, :back_url => @back), :method => :post, @@ -105,7 +105,7 @@ <% @options_by_custom_field.each do |field, options| %>
    • - <%= h(field.name) %> + <%= field.name %>
        <% options.each do |text, value| %>
      • <%= bulk_update_custom_field_context_menu_link(field, text, value || text) %>
      • diff --git a/app/views/context_menus/time_entries.html.erb b/app/views/context_menus/time_entries.html.erb index 3ab8d07aa..5f6ebd7ef 100644 --- a/app/views/context_menus/time_entries.html.erb +++ b/app/views/context_menus/time_entries.html.erb @@ -14,7 +14,7 @@ <%= l(:field_activity) %>
          <% @activities.each do |u| -%> -
        • <%= context_menu_link h(u.name), {:controller => 'timelog', :action => 'bulk_update', :ids => @time_entries.collect(&:id), :time_entry => {'activity_id' => u}, :back_url => @back}, :method => :post, +
        • <%= context_menu_link u.name, {:controller => 'timelog', :action => 'bulk_update', :ids => @time_entries.collect(&:id), :time_entry => {'activity_id' => u}, :back_url => @back}, :method => :post, :selected => (@time_entry && u == @time_entry.activity), :disabled => !@can[:edit] %>
        • <% end -%>
        • <%= context_menu_link l(:label_none), {:controller => 'timelog', :action => 'bulk_update', :ids => @time_entries.collect(&:id), :time_entry => {'activity_id' => 'none'}, :back_url => @back}, :method => :post, @@ -25,7 +25,7 @@ <% @options_by_custom_field.each do |field, options| %>
        • - <%= h(field.name) %> + <%= field.name %>
            <% options.each do |text, value| %>
          • <%= bulk_update_time_entry_custom_field_context_menu_link(field, text, value || text) %>
          • diff --git a/app/views/custom_fields/_form.html.erb b/app/views/custom_fields/_form.html.erb index 0e1851d01..c5e2824c5 100644 --- a/app/views/custom_fields/_form.html.erb +++ b/app/views/custom_fields/_form.html.erb @@ -94,7 +94,7 @@ when "IssueCustomField" %> (@custom_field.trackers.include? tracker), :id => "custom_field_tracker_ids_#{tracker.id}" %> <% end %> <%= hidden_field_tag "custom_field[tracker_ids][]", '' %> @@ -103,7 +103,7 @@ when "IssueCustomField" %>
            <%= l(:label_project_plural) %> <%= render_project_nested_lists(Project.all) do |p| - content_tag('label', check_box_tag('custom_field[project_ids][]', p.id, @custom_field.projects.to_a.include?(p), :id => nil) + ' ' + h(p)) + content_tag('label', check_box_tag('custom_field[project_ids][]', p.id, @custom_field.projects.to_a.include?(p), :id => nil) + ' ' + p) end %> <%= hidden_field_tag('custom_field[project_ids][]', '', :id => nil) %>

            <%= check_all_links 'custom_field_project_ids' %>

            diff --git a/app/views/custom_fields/_index.html.erb b/app/views/custom_fields/_index.html.erb index 0b578d6ee..858665e93 100644 --- a/app/views/custom_fields/_index.html.erb +++ b/app/views/custom_fields/_index.html.erb @@ -13,7 +13,7 @@
  • <% (@custom_fields_by_type[tab[:name]] || []).sort.each do |custom_field| -%> "> - + <% if tab[:name] == 'IssueCustomField' %> diff --git a/app/views/documents/_document.html.erb b/app/views/documents/_document.html.erb index e14d880a7..9a96d5d32 100644 --- a/app/views/documents/_document.html.erb +++ b/app/views/documents/_document.html.erb @@ -1,4 +1,4 @@ -

    <%= link_to h(document.title), document_path(document) %>

    +

    <%= link_to document.title, document_path(document) %>

    <%= format_time(document.updated_on) %>

    diff --git a/app/views/documents/show.html.erb b/app/views/documents/show.html.erb index 8b1f0067b..8d2e495c0 100644 --- a/app/views/documents/show.html.erb +++ b/app/views/documents/show.html.erb @@ -7,9 +7,9 @@ <% end %>
    -

    <%=h @document.title %>

    +

    <%= @document.title %>

    -

    <%=h @document.category.name %>
    +

    <%= @document.category.name %>
    <%= format_date @document.created_on %>

    <% if @document.custom_field_values.any? %> diff --git a/app/views/enumerations/index.html.erb b/app/views/enumerations/index.html.erb index 684b933a6..d1fb91926 100644 --- a/app/views/enumerations/index.html.erb +++ b/app/views/enumerations/index.html.erb @@ -15,7 +15,7 @@ <% enumerations.each do |enumeration| %> - + diff --git a/app/views/files/index.html.erb b/app/views/files/index.html.erb index c164cc011..decc7314e 100644 --- a/app/views/files/index.html.erb +++ b/app/views/files/index.html.erb @@ -21,7 +21,7 @@ <% if container.is_a?(Version) -%> <% end -%> diff --git a/app/views/gantts/show.html.erb b/app/views/gantts/show.html.erb index 5dd95232d..ada60cd66 100644 --- a/app/views/gantts/show.html.erb +++ b/app/views/gantts/show.html.erb @@ -6,7 +6,7 @@ <% end %> -

    <%= @query.new_record? ? l(:label_gantt) : h(@query.name) %>

    +

    <%= @query.new_record? ? l(:label_gantt) : @query.name %>

    <%= form_tag({:controller => 'gantts', :action => 'show', :project_id => @project, :month => params[:month], @@ -172,7 +172,7 @@ style += "height: #{height}px;" %> <%= content_tag(:div, :style => style, :class => "gantt_hdr") do %> - <%= link_to h("#{month_f.year}-#{month_f.month}"), + <%= link_to "#{month_f.year}-#{month_f.month}", @gantt.params.merge(:year => month_f.year, :month => month_f.month), :title => "#{month_name(month_f.month)} #{month_f.year}" %> <% end %> diff --git a/app/views/groups/index.html.erb b/app/views/groups/index.html.erb index a600ca48d..888b4085d 100644 --- a/app/views/groups/index.html.erb +++ b/app/views/groups/index.html.erb @@ -13,7 +13,7 @@
    <% @groups.each do |group| %> "> - + diff --git a/app/views/groups/show.html.erb b/app/views/groups/show.html.erb index 4a0a18da7..b10427bf9 100644 --- a/app/views/groups/show.html.erb +++ b/app/views/groups/show.html.erb @@ -2,6 +2,6 @@
      <% @group.users.each do |user| %> -
    • <%=h user %>
    • +
    • <%= user %>
    • <% end %>
    diff --git a/app/views/issue_statuses/index.html.erb b/app/views/issue_statuses/index.html.erb index 81c34f703..3da8c5b80 100644 --- a/app/views/issue_statuses/index.html.erb +++ b/app/views/issue_statuses/index.html.erb @@ -18,9 +18,9 @@
    <% for status in @issue_statuses %> "> - + <% if Issue.use_status_for_done_ratio? %> - + <% end %> diff --git a/app/views/issues/_relations.html.erb b/app/views/issues/_relations.html.erb index fcb1759ef..d3e7f4d0b 100644 --- a/app/views/issues/_relations.html.erb +++ b/app/views/issues/_relations.html.erb @@ -16,7 +16,7 @@ - +
    <%= link_to h(topic.subject), board_message_path(@board, topic) %><%= link_to topic.subject, board_message_path(@board, topic) %> <%= link_to_user(topic.author) %> <%= format_time(topic.created_on) %> <%= topic.replies_count %>
    <%= link_to h(custom_field.name), edit_custom_field_path(custom_field) %><%= link_to custom_field.name, edit_custom_field_path(custom_field) %> <%= l(custom_field.format.label) %> <%= checked_image custom_field.is_required? %>
    <%= link_to h(enumeration), edit_enumeration_path(enumeration) %><%= link_to enumeration, edit_enumeration_path(enumeration) %> <%= checked_image enumeration.is_default? %> <%= checked_image enumeration.active? %> <%= reorder_links('enumeration', {:action => 'update', :id => enumeration}, :put) %>
    - <%= link_to(h(container), {:controller => 'versions', :action => 'show', :id => container}, :class => "icon icon-package") %> + <%= link_to(container, {:controller => 'versions', :action => 'show', :id => container}, :class => "icon icon-package") %>
    <%= link_to h(group), edit_group_path(group) %><%= link_to group, edit_group_path(group) %> <%= (@user_count_by_group_id[group.id] || 0) unless group.builtin? %> <%= delete_link group unless group.builtin? %>
    <%= link_to h(status.name), edit_issue_status_path(status) %><%= link_to status.name, edit_issue_status_path(status) %><%= h status.default_done_ratio %><%= status.default_done_ratio %><%= checked_image status.is_closed? %> <%= reorder_links('issue_status', {:action => 'update', :id => status, :page => params[:page]}, :put) %> <%= relation.to_s(@issue) {|other| link_to_issue(other, :project => Setting.cross_project_issue_relations?)}.html_safe %> <%=h other_issue.status.name %><%= other_issue.status.name %> <%= format_date(other_issue.start_date) %> <%= format_date(other_issue.due_date) %> <%= link_to image_tag('link_break.png'), diff --git a/app/views/issues/bulk_edit.html.erb b/app/views/issues/bulk_edit.html.erb index 4cdc257da..b4ec3d542 100644 --- a/app/views/issues/bulk_edit.html.erb +++ b/app/views/issues/bulk_edit.html.erb @@ -93,7 +93,7 @@ <% @custom_fields.each do |custom_field| %>

    - + <%= custom_field_tag_for_bulk_edit('issue', custom_field, @issues, @issue_params[:custom_field_values][custom_field.id.to_s]) %>

    <% end %> diff --git a/app/views/issues/edit.html.erb b/app/views/issues/edit.html.erb index f2c6024ba..1cd61b783 100644 --- a/app/views/issues/edit.html.erb +++ b/app/views/issues/edit.html.erb @@ -1,4 +1,4 @@ -

    <%=h "#{@issue.tracker.name} ##{@issue.id}" %>

    +

    <%= "#{@issue.tracker.name} ##{@issue.id}" %>

    <%= render :partial => 'edit' %> <% content_for :header_tags do %> diff --git a/app/views/issues/index.html.erb b/app/views/issues/index.html.erb index 50c8bf9bf..55bfc5647 100644 --- a/app/views/issues/index.html.erb +++ b/app/views/issues/index.html.erb @@ -5,7 +5,7 @@ <% end %> -

    <%= @query.new_record? ? l(:label_issue_plural) : h(@query.name) %>

    +

    <%= @query.new_record? ? l(:label_issue_plural) : @query.name %>

    <% html_title(@query.new_record? ? l(:label_issue_plural) : @query.name) %> <%= form_tag({ :controller => 'issues', :action => 'index', :project_id => @project }, diff --git a/app/views/issues/show.html.erb b/app/views/issues/show.html.erb index 6a514ac88..ad8ee98a4 100644 --- a/app/views/issues/show.html.erb +++ b/app/views/issues/show.html.erb @@ -35,14 +35,14 @@ <%= issue_fields_rows do |rows| - rows.left l(:field_status), h(@issue.status.name), :class => 'status' - rows.left l(:field_priority), h(@issue.priority.name), :class => 'priority' + rows.left l(:field_status), @issue.status.name, :class => 'status' + rows.left l(:field_priority), @issue.priority.name, :class => 'priority' unless @issue.disabled_core_fields.include?('assigned_to_id') rows.left l(:field_assigned_to), avatar(@issue.assigned_to, :size => "14").to_s.html_safe + (@issue.assigned_to ? link_to_user(@issue.assigned_to) : "-"), :class => 'assigned-to' end unless @issue.disabled_core_fields.include?('category_id') - rows.left l(:field_category), h(@issue.category ? @issue.category.name : "-"), :class => 'category' + rows.left l(:field_category), (@issue.category ? @issue.category.name : "-"), :class => 'category' end unless @issue.disabled_core_fields.include?('fixed_version_id') rows.left l(:field_fixed_version), (@issue.fixed_version ? link_to_version(@issue.fixed_version) : "-"), :class => 'fixed-version' diff --git a/app/views/layouts/base.html.erb b/app/views/layouts/base.html.erb index 778f1d3cd..434f46ce8 100644 --- a/app/views/layouts/base.html.erb +++ b/app/views/layouts/base.html.erb @@ -2,7 +2,7 @@ -<%=h html_title %> +<%= html_title %> <%= csrf_meta_tag %> @@ -15,7 +15,7 @@ <%= yield :header_tags -%> - +
    diff --git a/app/views/mailer/_issue.html.erb b/app/views/mailer/_issue.html.erb index 6b84a5be1..9461d8490 100644 --- a/app/views/mailer/_issue.html.erb +++ b/app/views/mailer/_issue.html.erb @@ -1,4 +1,4 @@ -

    <%= link_to(h("#{issue.tracker.name} ##{issue.id}: #{issue.subject}"), issue_url) %>

    +

    <%= link_to("#{issue.tracker.name} ##{issue.id}: #{issue.subject}", issue_url) %>

    <%= render_email_issue_attributes(issue, users.first, true) %> diff --git a/app/views/mailer/account_activated.html.erb b/app/views/mailer/account_activated.html.erb index cb8d8caa1..6dc952238 100644 --- a/app/views/mailer/account_activated.html.erb +++ b/app/views/mailer/account_activated.html.erb @@ -1,2 +1,2 @@

    <%= l(:notice_account_activated) %>

    -

    <%= l(:label_login) %>: <%= link_to h(@login_url), @login_url %>

    +

    <%= l(:label_login) %>: <%= link_to @login_url, @login_url %>

    diff --git a/app/views/mailer/account_activation_request.html.erb b/app/views/mailer/account_activation_request.html.erb index 4450631b9..b19cf3219 100644 --- a/app/views/mailer/account_activation_request.html.erb +++ b/app/views/mailer/account_activation_request.html.erb @@ -1,2 +1,2 @@

    <%= l(:mail_body_account_activation_request, h(@user.login)) %>

    -

    <%= link_to h(@url), @url %>

    +

    <%= link_to @url, @url %>

    diff --git a/app/views/mailer/account_information.html.erb b/app/views/mailer/account_information.html.erb index 426aacee1..4d4066d65 100644 --- a/app/views/mailer/account_information.html.erb +++ b/app/views/mailer/account_information.html.erb @@ -3,9 +3,9 @@ <% else %>

    <%= l(:mail_body_account_information) %>:

      -
    • <%= l(:field_login) %>: <%=h @user.login %>
    • -
    • <%= l(:field_password) %>: <%=h @password %>
    • +
    • <%= l(:field_login) %>: <%= @user.login %>
    • +
    • <%= l(:field_password) %>: <%= @password %>
    <% end %> -

    <%= l(:label_login) %>: <%= link_to h(@login_url), @login_url %>

    +

    <%= l(:label_login) %>: <%= link_to @login_url, @login_url %>

    diff --git a/app/views/mailer/attachments_added.html.erb b/app/views/mailer/attachments_added.html.erb index 11d1cf54c..d2355b1c4 100644 --- a/app/views/mailer/attachments_added.html.erb +++ b/app/views/mailer/attachments_added.html.erb @@ -1,5 +1,5 @@ -<%= link_to h(@added_to), @added_to_url %>
    +<%= link_to @added_to, @added_to_url %>
      <% @attachments.each do |attachment | %> -
    • <%=h attachment.filename %>
    • +
    • <%= attachment.filename %>
    • <% end %>
    diff --git a/app/views/mailer/document_added.html.erb b/app/views/mailer/document_added.html.erb index 8606dd784..e3ece786d 100644 --- a/app/views/mailer/document_added.html.erb +++ b/app/views/mailer/document_added.html.erb @@ -1,3 +1,3 @@ -<%= link_to(h(@document.title), @document_url) %> (<%=h @document.category.name %>)
    +<%= link_to(@document.title, @document_url) %> (<%= @document.category.name %>)

    <%= textilizable(@document, :description, :only_path => false) %> diff --git a/app/views/mailer/lost_password.html.erb b/app/views/mailer/lost_password.html.erb index d740480ad..9294bcfae 100644 --- a/app/views/mailer/lost_password.html.erb +++ b/app/views/mailer/lost_password.html.erb @@ -1,4 +1,4 @@

    <%= l(:mail_body_lost_password) %>
    -<%= link_to h(@url), @url %>

    +<%= link_to @url, @url %>

    -

    <%= l(:field_login) %>: <%=h @token.user.login %>

    +

    <%= l(:field_login) %>: <%= @token.user.login %>

    diff --git a/app/views/mailer/message_posted.html.erb b/app/views/mailer/message_posted.html.erb index f43a8cf0f..3401b1816 100644 --- a/app/views/mailer/message_posted.html.erb +++ b/app/views/mailer/message_posted.html.erb @@ -1,4 +1,4 @@ -

    <%=h @message.board.project.name %> - <%=h @message.board.name %>: <%= link_to(h(@message.subject), @message_url) %>

    -<%=h @message.author %> +

    <%= @message.board.project.name %> - <%= @message.board.name %>: <%= link_to(@message.subject, @message_url) %>

    +<%= @message.author %> <%= textilizable(@message, :content, :only_path => false) %> diff --git a/app/views/mailer/news_added.html.erb b/app/views/mailer/news_added.html.erb index 758ebccb8..daf250adf 100644 --- a/app/views/mailer/news_added.html.erb +++ b/app/views/mailer/news_added.html.erb @@ -1,4 +1,4 @@ -

    <%= link_to(h(@news.title), @news_url) %>

    -<%=h @news.author.name %> +

    <%= link_to(@news.title, @news_url) %>

    +<%= @news.author.name %> <%= textilizable(@news, :description, :only_path => false) %> diff --git a/app/views/mailer/news_comment_added.html.erb b/app/views/mailer/news_comment_added.html.erb index ef2be0f65..c9cc2a78e 100644 --- a/app/views/mailer/news_comment_added.html.erb +++ b/app/views/mailer/news_comment_added.html.erb @@ -1,4 +1,4 @@ -

    <%= link_to(h(@news.title), @news_url) %>

    +

    <%= link_to(@news.title, @news_url) %>

    <%= l(:text_user_wrote, :value => h(@comment.author)) %>

    diff --git a/app/views/mailer/register.html.erb b/app/views/mailer/register.html.erb index 282deca90..5e8f6dfcf 100644 --- a/app/views/mailer/register.html.erb +++ b/app/views/mailer/register.html.erb @@ -1,2 +1,2 @@

    <%= l(:mail_body_register) %>
    -<%= link_to h(@url), @url %>

    +<%= link_to @url, @url %>

    diff --git a/app/views/mailer/test_email.html.erb b/app/views/mailer/test_email.html.erb index 1e81b3bfe..c73f0e341 100644 --- a/app/views/mailer/test_email.html.erb +++ b/app/views/mailer/test_email.html.erb @@ -1,2 +1,2 @@

    This is a test email sent by Redmine.
    -Redmine URL: <%= link_to h(@url), @url %>

    +Redmine URL: <%= link_to @url, @url %>

    diff --git a/app/views/mailer/wiki_content_added.html.erb b/app/views/mailer/wiki_content_added.html.erb index 8c83f62c8..f6d92a9d8 100644 --- a/app/views/mailer/wiki_content_added.html.erb +++ b/app/views/mailer/wiki_content_added.html.erb @@ -1,3 +1,3 @@ -

    <%= l(:mail_body_wiki_content_added, :id => link_to(h(@wiki_content.page.pretty_title), @wiki_content_url), +

    <%= l(:mail_body_wiki_content_added, :id => link_to(@wiki_content.page.pretty_title, @wiki_content_url), :author => h(@wiki_content.author)).html_safe %>
    -<%=h @wiki_content.comments %>

    +<%= @wiki_content.comments %>

    diff --git a/app/views/mailer/wiki_content_updated.html.erb b/app/views/mailer/wiki_content_updated.html.erb index f1f3857bd..83a9a1675 100644 --- a/app/views/mailer/wiki_content_updated.html.erb +++ b/app/views/mailer/wiki_content_updated.html.erb @@ -1,6 +1,6 @@ -

    <%= l(:mail_body_wiki_content_updated, :id => link_to(h(@wiki_content.page.pretty_title), @wiki_content_url), +

    <%= l(:mail_body_wiki_content_updated, :id => link_to(@wiki_content.page.pretty_title, @wiki_content_url), :author => h(@wiki_content.author)).html_safe %>
    -<%=h @wiki_content.comments %>

    +<%= @wiki_content.comments %>

    <%= l(:label_view_diff) %>:
    -<%= link_to h(@wiki_diff_url), @wiki_diff_url %>

    +<%= link_to @wiki_diff_url, @wiki_diff_url %>

    diff --git a/app/views/messages/edit.html.erb b/app/views/messages/edit.html.erb index 7ce0560bb..53948e4da 100644 --- a/app/views/messages/edit.html.erb +++ b/app/views/messages/edit.html.erb @@ -1,6 +1,6 @@ <%= board_breadcrumb(@message) %> -

    <%= avatar(@topic.author, :size => "24") %><%=h @topic.subject %>

    +

    <%= avatar(@topic.author, :size => "24") %><%= @topic.subject %>

    <%= form_for @message, { :as => :message, diff --git a/app/views/messages/new.html.erb b/app/views/messages/new.html.erb index fbdac695f..f8d840694 100644 --- a/app/views/messages/new.html.erb +++ b/app/views/messages/new.html.erb @@ -1,4 +1,4 @@ -

    <%= link_to h(@board.name), :controller => 'boards', :action => 'show', :project_id => @project, :id => @board %> » <%= l(:label_message_new) %>

    +

    <%= link_to @board.name, :controller => 'boards', :action => 'show', :project_id => @project, :id => @board %> » <%= l(:label_message_new) %>

    <%= form_for @message, :url => {:action => 'new'}, :html => {:multipart => true, :id => 'message-form'} do |f| %> <%= render :partial => 'form', :locals => {:f => f} %> diff --git a/app/views/messages/show.html.erb b/app/views/messages/show.html.erb index cb5e84a87..533be20bb 100644 --- a/app/views/messages/show.html.erb +++ b/app/views/messages/show.html.erb @@ -22,7 +22,7 @@ ) if @message.destroyable_by?(User.current) %>
    -

    <%= avatar(@topic.author, :size => "24") %><%=h @topic.subject %>

    +

    <%= avatar(@topic.author, :size => "24") %><%= @topic.subject %>

    <%= authoring @topic.created_on, @topic.author %>

    @@ -59,7 +59,7 @@

    <%= avatar(message.author, :size => "24") %> - <%= link_to h(message.subject), { :controller => 'messages', :action => 'show', :board_id => @board, :id => @topic, :r => message, :anchor => "message-#{message.id}" } %> + <%= link_to message.subject, { :controller => 'messages', :action => 'show', :board_id => @board, :id => @topic, :r => message, :anchor => "message-#{message.id}" } %> - <%= authoring message.created_on, message.author %>

    diff --git a/app/views/my/_sidebar.html.erb b/app/views/my/_sidebar.html.erb index 4c9270fc7..a35bcaf77 100644 --- a/app/views/my/_sidebar.html.erb +++ b/app/views/my/_sidebar.html.erb @@ -22,7 +22,7 @@

    <%= l(:label_api_access_key) %>

    <%= link_to_function(l(:button_show), "$('#api-access-key').toggle();")%> -
    <%= h(@user.api_key) %>
    +
    <%= @user.api_key %>
    <%= javascript_tag("$('#api-access-key').hide();") %>

    diff --git a/app/views/my/blocks/_timelog.html.erb b/app/views/my/blocks/_timelog.html.erb index f88de9549..747039c85 100644 --- a/app/views/my/blocks/_timelog.html.erb +++ b/app/views/my/blocks/_timelog.html.erb @@ -36,9 +36,9 @@ entries_by_day = entries.group_by(&:spent_on) <% entries_by_day[day].each do |entry| -%>

    - - - + + + <% TimeEntryActivity.new.available_custom_fields.each do |value| %> - + <% end %> @@ -15,7 +15,7 @@ <% enumeration.custom_field_values.each do |value| %> diff --git a/app/views/projects/settings/_boards.html.erb b/app/views/projects/settings/_boards.html.erb index b6a460b97..f115c2866 100644 --- a/app/views/projects/settings/_boards.html.erb +++ b/app/views/projects/settings/_boards.html.erb @@ -11,7 +11,7 @@ next if board.new_record? %> - + - - + + - - + + - + - + <% for status in @statuses %> - + <% end %> @@ -14,7 +14,7 @@ <% for row in rows %> "> - + <% for status in @statuses %> <% end %> diff --git a/app/views/reports/_simple.html.erb b/app/views/reports/_simple.html.erb index 8cfefe8a7..9dca3554c 100644 --- a/app/views/reports/_simple.html.erb +++ b/app/views/reports/_simple.html.erb @@ -11,7 +11,7 @@ <% for row in rows %> "> - + diff --git a/app/views/repositories/_breadcrumbs.html.erb b/app/views/repositories/_breadcrumbs.html.erb index 20c2040e5..eb115f9ad 100644 --- a/app/views/repositories/_breadcrumbs.html.erb +++ b/app/views/repositories/_breadcrumbs.html.erb @@ -1,4 +1,4 @@ -<%= link_to(@repository.identifier.present? ? h(@repository.identifier) : 'root', +<%= link_to(@repository.identifier.present? ? @repository.identifier : 'root', :action => 'show', :id => @project, :repository_id => @repository.identifier_param, :path => nil, :rev => @rev) %> @@ -13,11 +13,11 @@ dirs.each do |dir| link_path << '/' unless link_path.empty? link_path << "#{dir}" %> - / <%= link_to h(dir), :action => 'show', :id => @project, :repository_id => @repository.identifier_param, + / <%= link_to dir, :action => 'show', :id => @project, :repository_id => @repository.identifier_param, :path => to_path_param(link_path), :rev => @rev %> <% end %> <% if filename %> - / <%= link_to h(filename), + / <%= link_to filename, :action => 'changes', :id => @project, :repository_id => @repository.identifier_param, :path => to_path_param("#{link_path}/#{filename}"), :rev => @rev %> <% end %> @@ -26,6 +26,6 @@ dirs.each do |dir| # For Mercurial *tip*, @rev and @changeset are nil. rev_text = @changeset.nil? ? @rev : format_revision(@changeset) %> -<%= "@ #{h rev_text}" unless rev_text.blank? %> +<%= "@ #{rev_text}" unless rev_text.blank? %> <% html_title(with_leading_slash(path)) -%> diff --git a/app/views/repositories/_dir_list_content.html.erb b/app/views/repositories/_dir_list_content.html.erb index 21f205ad7..9721fa66c 100644 --- a/app/views/repositories/_dir_list_content.html.erb +++ b/app/views/repositories/_dir_list_content.html.erb @@ -3,7 +3,7 @@ depth = params[:depth].to_i %> <% ent_path = Redmine::CodesetUtil.replace_invalid_utf8(entry.path) %> <% ent_name = Redmine::CodesetUtil.replace_invalid_utf8(entry.name) %> - + diff --git a/app/views/repositories/committers.html.erb b/app/views/repositories/committers.html.erb index d9c2d5d96..b942e4b82 100644 --- a/app/views/repositories/committers.html.erb +++ b/app/views/repositories/committers.html.erb @@ -18,7 +18,7 @@ <% i = 0 -%> <% @committers.each do |committer, user_id| -%> - +
    <%=h entry.activity %><%=h entry.project %> <%= h(' - ') + link_to_issue(entry.issue, :truncate => 50) if entry.issue %><%=h entry.comments %><%= entry.activity %><%= entry.project %> <%= h(' - ') + link_to_issue(entry.issue, :truncate => 50) if entry.issue %><%= entry.comments %> <%= html_hours("%.2f" % entry.hours) %> <% if entry.editable_by?(@user) -%> diff --git a/app/views/news/_news.html.erb b/app/views/news/_news.html.erb index cc83d2a9e..391d9a900 100644 --- a/app/views/news/_news.html.erb +++ b/app/views/news/_news.html.erb @@ -1,6 +1,6 @@

    <%= link_to_project(news.project) + ': ' unless @project %> -<%= link_to h(news.title), news_path(news) %> +<%= link_to news.title, news_path(news) %> <% if news.comments_count > 0 %>(<%= l(:label_x_comments, :count => news.comments_count) %>)<% end %>
    -<% unless news.summary.blank? %><%=h news.summary %>
    <% end %> +<% unless news.summary.blank? %><%= news.summary %>
    <% end %> <%= authoring news.created_on, news.author %>

    diff --git a/app/views/news/index.html.erb b/app/views/news/index.html.erb index 614a7b1f7..4560ac4fd 100644 --- a/app/views/news/index.html.erb +++ b/app/views/news/index.html.erb @@ -25,7 +25,7 @@ <% else %> <% @newss.each do |news| %>

    <%= avatar(news.author, :size => "24") %><%= link_to_project(news.project) + ': ' unless news.project == @project %> - <%= link_to h(news.title), news_path(news) %> + <%= link_to news.title, news_path(news) %> <%= "(#{l(:label_x_comments, :count => news.comments_count)})" if news.comments_count > 0 %>

    <%= authoring news.created_on, news.author %>

    diff --git a/app/views/news/show.html.erb b/app/views/news/show.html.erb index d359e90b9..c188d2e2c 100644 --- a/app/views/news/show.html.erb +++ b/app/views/news/show.html.erb @@ -23,7 +23,7 @@
    <% end %> -

    <% unless @news.summary.blank? %><%=h @news.summary %>
    <% end %> +

    <% unless @news.summary.blank? %><%= @news.summary %>
    <% end %> <%= authoring @news.created_on, @news.author %>

    <%= textilizable(@news, :description) %> diff --git a/app/views/projects/_form.html.erb b/app/views/projects/_form.html.erb index a670a03b6..e13604c36 100644 --- a/app/views/projects/_form.html.erb +++ b/app/views/projects/_form.html.erb @@ -46,7 +46,7 @@ <% @trackers.each do |tracker| %> <% end %> <%= hidden_field_tag 'project[tracker_ids][]', '' %> @@ -60,7 +60,7 @@ <%= check_box_tag 'project[issue_custom_field_ids][]', custom_field.id, (@project.all_issue_custom_fields.include? custom_field), :disabled => (custom_field.is_for_all? ? "disabled" : nil), :id => nil %> - <%=h custom_field.name %> + <%= custom_field.name %> <% end %> <%= hidden_field_tag 'project[issue_custom_field_ids][]', '' %> diff --git a/app/views/projects/_members_box.html.erb b/app/views/projects/_members_box.html.erb index e8c8114c4..7ac4b2cd7 100644 --- a/app/views/projects/_members_box.html.erb +++ b/app/views/projects/_members_box.html.erb @@ -2,7 +2,7 @@

    <%=l(:label_member_plural)%>

    <% @users_by_role.keys.sort.each do |role| %> -

    <%=h role %>: <%= @users_by_role[role].sort.collect{|u| link_to_user u}.join(", ").html_safe %>

    +

    <%= role %>: <%= @users_by_role[role].sort.collect{|u| link_to_user u}.join(", ").html_safe %>

    <% end %>
    <% end %> diff --git a/app/views/projects/destroy.html.erb b/app/views/projects/destroy.html.erb index ac392b72c..ca5ae1723 100644 --- a/app/views/projects/destroy.html.erb +++ b/app/views/projects/destroy.html.erb @@ -6,7 +6,7 @@ <% if @project_to_destroy.descendants.any? %>
    <%= l(:text_subprojects_destroy_warning, - content_tag('strong', h(@project_to_destroy.descendants.collect{|p| p.to_s}.join(', ')))).html_safe %> + content_tag('strong', @project_to_destroy.descendants.collect{|p| p.to_s}.join(', '))).html_safe %> <% end %>

    diff --git a/app/views/projects/list_members.html.erb b/app/views/projects/list_members.html.erb index 04de16044..7f2ae3795 100644 --- a/app/views/projects/list_members.html.erb +++ b/app/views/projects/list_members.html.erb @@ -4,7 +4,7 @@ <% members = @members.group_by {|m| m.role } %> <% members.keys.sort{|x,y| x.position <=> y.position}.each do |role| %> -

    <%= h(role.name) %>

    +

    <%= role.name %>

      <% members[role].each do |m| %>
    • <%= link_to_user m.user %> (<%= format_date m.created_on %>)
    • diff --git a/app/views/projects/settings/_activities.html.erb b/app/views/projects/settings/_activities.html.erb index 65c26f57c..db1a3c286 100644 --- a/app/views/projects/settings/_activities.html.erb +++ b/app/views/projects/settings/_activities.html.erb @@ -5,7 +5,7 @@
    <%= l(:field_name) %> <%= l(:enumeration_system_activity) %><%= h value.name %><%= value.name %><%= l(:field_active) %>
    <%= ff.hidden_field :parent_id, :value => enumeration.id unless enumeration.project %> - <%= h(enumeration) %> + <%= enumeration %> <%= checked_image !enumeration.project %>
    <%= link_to board.name, project_board_path(@project, board) %><%=h board.description %><%= board.description %> <% if authorize_for("boards", "edit") %> <%= reorder_links('board', {:controller => 'boards', :action => 'update', :project_id => @project, :id => board}, :put) %> diff --git a/app/views/projects/settings/_issue_categories.html.erb b/app/views/projects/settings/_issue_categories.html.erb index 7c56fb667..8a04f2555 100644 --- a/app/views/projects/settings/_issue_categories.html.erb +++ b/app/views/projects/settings/_issue_categories.html.erb @@ -9,8 +9,8 @@ <% for category in @project.issue_categories %> <% unless category.new_record? %>
    <%=h(category.name) %><%=h(category.assigned_to.name) if category.assigned_to %><%= category.name %><%= category.assigned_to.name if category.assigned_to %> <% if User.current.allowed_to?(:manage_categories, @project) %> <%= link_to l(:button_edit), edit_issue_category_path(category), :class => 'icon icon-edit' %> diff --git a/app/views/projects/settings/_repositories.html.erb b/app/views/projects/settings/_repositories.html.erb index 9352963cf..e60164caa 100644 --- a/app/views/projects/settings/_repositories.html.erb +++ b/app/views/projects/settings/_repositories.html.erb @@ -17,8 +17,8 @@ {:controller => 'repositories', :action => 'show',:id => @project, :repository_id => repository.identifier_param} if repository.identifier.present? %> <%= checked_image repository.is_default? %><%=h repository.scm_name %><%=h repository.url %><%= repository.scm_name %><%= repository.url %> <% if User.current.allowed_to?(:manage_repository, @project) %> <%= link_to(l(:label_user_plural), committers_repository_path(repository), diff --git a/app/views/projects/settings/_versions.html.erb b/app/views/projects/settings/_versions.html.erb index 778803bf3..d33788a5a 100644 --- a/app/views/projects/settings/_versions.html.erb +++ b/app/views/projects/settings/_versions.html.erb @@ -14,10 +14,10 @@
    <%= link_to_version version %> <%= format_date(version.effective_date) %><%=h version.description %><%= version.description %> <%= l("version_status_#{version.status}") %> <%= link_to_if_authorized(h(version.wiki_page_title), {:controller => 'wiki', :action => 'show', :project_id => version.project, :id => Wiki.titleize(version.wiki_page_title)}) || h(version.wiki_page_title) unless version.wiki_page_title.blank? || version.project.wiki.nil? %><%= link_to_if_authorized(version.wiki_page_title, {:controller => 'wiki', :action => 'show', :project_id => version.project, :id => Wiki.titleize(version.wiki_page_title)}) || h(version.wiki_page_title) unless version.wiki_page_title.blank? || version.project.wiki.nil? %> <% if version.project == @project && User.current.allowed_to?(:manage_versions, @project) %> <%= link_to l(:button_edit), edit_version_path(version), :class => 'icon icon-edit' %> diff --git a/app/views/projects/show.html.erb b/app/views/projects/show.html.erb index addcfdf62..dce288e4c 100644 --- a/app/views/projects/show.html.erb +++ b/app/views/projects/show.html.erb @@ -25,7 +25,7 @@ <% end %>
      <% unless @project.homepage.blank? %> -
    • <%=l(:field_homepage)%>: <%= link_to h(@project.homepage), @project.homepage %>
    • +
    • <%=l(:field_homepage)%>: <%= link_to @project.homepage, @project.homepage %>
    • <% end %> <% if @subprojects.any? %>
    • <%=l(:label_subproject_plural)%>: @@ -41,7 +41,7 @@

      <%=l(:label_issue_tracking)%>

        <% for tracker in @trackers %> -
      • <%= link_to h(tracker.name), project_issues_path(@project, :set_filter => 1, :tracker_id => tracker.id) %>: +
      • <%= link_to tracker.name, project_issues_path(@project, :set_filter => 1, :tracker_id => tracker.id) %>: <%= l(:label_x_open_issues_abbr_on_total, :count => @open_issues_by_tracker[tracker].to_i, :total => @total_issues_by_tracker[tracker].to_i) %>
      • diff --git a/app/views/queries/index.html.erb b/app/views/queries/index.html.erb index 98b0dfb72..b0dbc05be 100644 --- a/app/views/queries/index.html.erb +++ b/app/views/queries/index.html.erb @@ -11,7 +11,7 @@ <% @queries.each do |query| %>
    - <%= link_to h(query.name), :controller => 'issues', :action => 'index', :project_id => @project, :query_id => query %> + <%= link_to query.name, :controller => 'issues', :action => 'index', :project_id => @project, :query_id => query %> <% if query.editable_by?(User.current) %> diff --git a/app/views/reports/_details.html.erb b/app/views/reports/_details.html.erb index 7d2ea4dcb..ab7fe3620 100644 --- a/app/views/reports/_details.html.erb +++ b/app/views/reports/_details.html.erb @@ -5,7 +5,7 @@
    <%=h status.name %><%= status.name %><%=l(:label_open_issues_plural)%> <%=l(:label_closed_issues_plural)%>
    <%= link_to h(row.name), aggregate_path(@project, field_name, row) %><%= link_to row.name, aggregate_path(@project, field_name, row) %><%= aggregate_link data, { field_name => row.id, "status_id" => status.id }, aggregate_path(@project, field_name, row, :status_id => status.id) %>
    <%= link_to h(row.name), aggregate_path(@project, field_name, row) %><%= link_to row.name, aggregate_path(@project, field_name, row) %> <%= aggregate_link data, { field_name => row.id, "closed" => 0 }, aggregate_path(@project, field_name, row, :status_id => "o") %> <%= aggregate_link data, { field_name => row.id, "closed" => 1 }, aggregate_path(@project, field_name, row, :status_id => "c") %> <%= aggregate_link data, { field_name => row.id }, aggregate_path(@project, field_name, row, :status_id => "*") %>
    "> <% if entry.is_dir? %> @@ -16,7 +16,7 @@ :depth => (depth + 1), :parent_id => tr_id)) %>');">  <% end %> -<%= link_to h(ent_name), +<%= link_to ent_name, {:action => (entry.is_dir? ? 'show' : 'changes'), :id => @project, :repository_id => @repository.identifier_param, :path => to_path_param(ent_path), :rev => @rev}, :class => (entry.is_dir? ? 'icon icon-folder' : "icon icon-file #{Redmine::MimeType.css_class_of(ent_name)}")%>
    <%=h committer %><%= committer %> <%= hidden_field_tag "committers[#{i}][]", committer, :id => nil %> <%= select_tag "committers[#{i}][]", diff --git a/app/views/repositories/revision.html.erb b/app/views/repositories/revision.html.erb index 64dfd75ea..13edf07cb 100644 --- a/app/views/repositories/revision.html.erb +++ b/app/views/repositories/revision.html.erb @@ -32,7 +32,7 @@ <% if @changeset.scmid.present? %> - + <% end %> <% if @changeset.parents.present? %> diff --git a/app/views/repositories/show.html.erb b/app/views/repositories/show.html.erb index fcf0a0e0d..b89bbf9fe 100644 --- a/app/views/repositories/show.html.erb +++ b/app/views/repositories/show.html.erb @@ -61,7 +61,7 @@

    <%= l(:label_repository_plural) %>

    <%= @repositories.sort.collect {|repo| - link_to h(repo.name), + link_to repo.name, {:controller => 'repositories', :action => 'show', :id => @project, :repository_id => repo.identifier_param, :rev => nil, :path => nil}, :class => 'repository' + (repo == @repository ? ' selected' : '') diff --git a/app/views/roles/index.html.erb b/app/views/roles/index.html.erb index 19a6c42c4..9545d5509 100644 --- a/app/views/roles/index.html.erb +++ b/app/views/roles/index.html.erb @@ -14,7 +14,7 @@

    <% for role in @roles %> "> - + <% @roles.each do |role| %> @@ -26,7 +26,7 @@ <%= l_or_humanize(mod, :prefix => 'project_module_') %> <% @roles.each do |role| %> - + <% end %> <% end %> diff --git a/app/views/search/index.html.erb b/app/views/search/index.html.erb index 2f0b06a6c..35d0d0bf7 100644 --- a/app/views/search/index.html.erb +++ b/app/views/search/index.html.erb @@ -42,7 +42,7 @@
    <% @results.each do |e| %>
    - <%= content_tag('span', h(e.project), :class => 'project') unless @project == e.project %> + <%= content_tag('span', e.project, :class => 'project') unless @project == e.project %> <%= link_to(highlight_tokens(e.event_title.truncate(255), @tokens), e.event_url) %>
    <%= highlight_tokens(e.event_description, @tokens) %> diff --git a/app/views/timelog/_form.html.erb b/app/views/timelog/_form.html.erb index 955c2d06b..9b078013d 100644 --- a/app/views/timelog/_form.html.erb +++ b/app/views/timelog/_form.html.erb @@ -13,7 +13,7 @@ <% end %>

    <%= f.text_field :issue_id, :size => 6 %> - <%= h("#{@time_entry.issue.tracker.name} ##{@time_entry.issue.id}: #{@time_entry.issue.subject}") if @time_entry.issue %> + <%= "#{@time_entry.issue.tracker.name} ##{@time_entry.issue.id}: #{@time_entry.issue.subject}" if @time_entry.issue %>

    <%= f.text_field :spent_on, :size => 10, :required => true %><%= calendar_for('time_entry_spent_on') %>

    <%= f.text_field :hours, :size => 6, :required => true %>

    diff --git a/app/views/timelog/_report_criteria.html.erb b/app/views/timelog/_report_criteria.html.erb index 8ebb29e58..c86b219d1 100644 --- a/app/views/timelog/_report_criteria.html.erb +++ b/app/views/timelog/_report_criteria.html.erb @@ -3,7 +3,7 @@ <% next if hours_for_value.empty? -%>
    <%= ("" * level).html_safe %> - + <%= ("" * (criterias.length - level - 1)).html_safe -%> <% total = 0 -%> <% @report.periods.each do |period| -%> diff --git a/app/views/trackers/_form.html.erb b/app/views/trackers/_form.html.erb index 5a7416548..107095540 100644 --- a/app/views/trackers/_form.html.erb +++ b/app/views/trackers/_form.html.erb @@ -27,7 +27,7 @@ <% IssueCustomField.all.each do |field| %> <% end %>

    diff --git a/app/views/trackers/index.html.erb b/app/views/trackers/index.html.erb index 64f06fc5c..f76a4f5db 100644 --- a/app/views/trackers/index.html.erb +++ b/app/views/trackers/index.html.erb @@ -15,7 +15,7 @@ <% for tracker in @trackers %> "> - + <% for user in @users -%> "> - - - - + + + + diff --git a/app/views/users/show.html.erb b/app/views/users/show.html.erb index fd4a1b974..570be3154 100644 --- a/app/views/users/show.html.erb +++ b/app/views/users/show.html.erb @@ -2,7 +2,7 @@ <%= link_to(l(:button_edit), edit_user_path(@user), :class => 'icon icon-edit') if User.current.admin? %> -

    <%= avatar @user, :size => "50" %> <%=h @user.name %>

    +

    <%= avatar @user, :size => "50" %> <%= @user.name %>

      @@ -10,11 +10,11 @@
    • <%=l(:field_login)%>: <%= @user.login %>
    • <% end %> <% unless @user.pref.hide_mail %> -
    • <%=l(:field_mail)%>: <%= mail_to(h(@user.mail), nil, :encode => 'javascript') %>
    • +
    • <%=l(:field_mail)%>: <%= mail_to(@user.mail, nil, :encode => 'javascript') %>
    • <% end %> <% @user.visible_custom_field_values.each do |custom_value| %> <% if !custom_value.value.blank? %> -
    • <%=h custom_value.custom_field.name%>: <%=h show_value(custom_value) %>
    • +
    • <%= custom_value.custom_field.name %>: <%= show_value(custom_value) %>
    • <% end %> <% end %>
    • <%=l(:label_registered_on)%>: <%= format_date(@user.created_on) %>
    • @@ -28,7 +28,7 @@
        <% for membership in @memberships %>
      • <%= link_to_project(membership.project) %> - (<%=h membership.roles.sort.collect(&:to_s).join(', ') %>, <%= format_date(membership.created_on) %>)
      • + (<%= membership.roles.sort.collect(&:to_s).join(', ') %>, <%= format_date(membership.created_on) %>) <% end %>
      <% end %> @@ -53,7 +53,7 @@ <% @events_by_day[day].sort {|x,y| y.event_datetime <=> x.event_datetime }.each do |e| -%>
      <%= format_time(e.event_datetime, false) %> - <%= content_tag('span', h(e.project), :class => 'project') %> + <%= content_tag('span', e.project, :class => 'project') %> <%= link_to format_activity_title(e.event_title), e.event_url %>
      <%= format_activity_description(e.event_description) %>
      <% end -%> diff --git a/app/views/versions/_issue_counts.html.erb b/app/views/versions/_issue_counts.html.erb index 951cc0186..7d9652250 100644 --- a/app/views/versions/_issue_counts.html.erb +++ b/app/views/versions/_issue_counts.html.erb @@ -15,7 +15,7 @@
    - - + + <% line_num += 1 %> <% end -%> diff --git a/app/views/wiki/date_index.html.erb b/app/views/wiki/date_index.html.erb index a543ef229..74a5f45fb 100644 --- a/app/views/wiki/date_index.html.erb +++ b/app/views/wiki/date_index.html.erb @@ -12,7 +12,7 @@

    <%= format_date(date) %>

      <% @pages_by_date[date].each do |page| %> -
    • <%= link_to h(page.pretty_title), :action => 'show', :id => page.title, :project_id => page.project %>
    • +
    • <%= link_to page.pretty_title, :action => 'show', :id => page.title, :project_id => page.project %>
    • <% end %>
    <% end %> diff --git a/app/views/wiki/destroy.html.erb b/app/views/wiki/destroy.html.erb index eebe250ca..d6270b685 100644 --- a/app/views/wiki/destroy.html.erb +++ b/app/views/wiki/destroy.html.erb @@ -1,6 +1,6 @@ <%= wiki_page_breadcrumb(@page) %> -

    <%=h @page.pretty_title %>

    +

    <%= @page.pretty_title %>

    <%= form_tag({}, :method => :delete) do %>
    diff --git a/app/views/wiki/edit.html.erb b/app/views/wiki/edit.html.erb index 40e6b792a..2a2ba312a 100644 --- a/app/views/wiki/edit.html.erb +++ b/app/views/wiki/edit.html.erb @@ -1,6 +1,6 @@ <%= wiki_page_breadcrumb(@page) %> -

    <%= h @page.pretty_title %>

    +

    <%= @page.pretty_title %>

    <%= form_for @content, :as => :content, :url => {:action => 'update', :id => @page.title}, diff --git a/app/views/wiki/export.html.erb b/app/views/wiki/export.html.erb index da45423dc..a9df66dee 100644 --- a/app/views/wiki/export.html.erb +++ b/app/views/wiki/export.html.erb @@ -1,7 +1,7 @@ -<%=h @page.pretty_title %> +<%= @page.pretty_title %>
    ID<%= h(@changeset.scmid) %>ID<%= @changeset.scmid %>
    <%= content_tag(role.builtin? ? 'em' : 'span', link_to(h(role.name), edit_role_path(role))) %><%= content_tag(role.builtin? ? 'em' : 'span', link_to(role.name, edit_role_path(role))) %> <% unless role.builtin? %> <%= reorder_links('role', {:action => 'update', :id => role, :page => params[:page]}, :put) %> diff --git a/app/views/roles/permissions.html.erb b/app/views/roles/permissions.html.erb index 13a072ff3..cea4bd9e6 100644 --- a/app/views/roles/permissions.html.erb +++ b/app/views/roles/permissions.html.erb @@ -9,7 +9,7 @@ <%=l(:label_permissions)%> - <%= content_tag(role.builtin? ? 'em' : 'span', h(role.name)) %> + <%= content_tag(role.builtin? ? 'em' : 'span', role.name) %> <%= link_to_function(image_tag('toggle_check.png'), "toggleCheckboxesBySelector('input.role-#{role.id}')", :title => "#{l(:button_check_all)}/#{l(:button_uncheck_all)}") %> <%= h(role.name) %><%= role.name %>
    <%= h(format_criteria_value(@report.available_criteria[criterias[level]], value)) %><%= format_criteria_value(@report.available_criteria[criterias[level]], value) %>
    <%= link_to h(tracker.name), edit_tracker_path(tracker) %><%= link_to tracker.name, edit_tracker_path(tracker) %> <% unless tracker.workflow_rules.count > 0 %> diff --git a/app/views/users/_groups.html.erb b/app/views/users/_groups.html.erb index 3b277abd7..204bd9d00 100644 --- a/app/views/users/_groups.html.erb +++ b/app/views/users/_groups.html.erb @@ -1,7 +1,7 @@ <%= form_for(:user, :url => { :action => 'update' }, :html => {:method => :put}) do %>
    <% Group.givable.sort.each do |group| %> -
    +
    <% end %> <%= hidden_field_tag 'user[group_ids][]', '' %>
    diff --git a/app/views/users/index.html.erb b/app/views/users/index.html.erb index fe3d6de44..a89712dad 100644 --- a/app/views/users/index.html.erb +++ b/app/views/users/index.html.erb @@ -37,10 +37,10 @@
    <%= avatar(user, :size => "14") %><%= link_to h(user.login), edit_user_path(user) %><%= h(user.firstname) %><%= h(user.lastname) %><%= avatar(user, :size => "14") %><%= link_to user.login, edit_user_path(user) %><%= user.firstname %><%= user.lastname %> <%= checked_image user.admin? %> <%= format_time(user.created_on) %>
    <% if count[:group] -%> - <%= link_to(h(count[:group]), project_issues_path(version.project, :set_filter => 1, :status_id => '*', :fixed_version_id => version, "#{criteria}_id" => count[:group])) %> + <%= link_to(count[:group], project_issues_path(version.project, :set_filter => 1, :status_id => '*', :fixed_version_id => version, "#{criteria}_id" => count[:group])) %> <% else -%> <%= link_to(l(:label_none), project_issues_path(version.project, :set_filter => 1, :status_id => '*', :fixed_version_id => version, "#{criteria}_id" => "!*")) %> <% end %> diff --git a/app/views/versions/show.html.erb b/app/views/versions/show.html.erb index fdbec6ff6..d05729e51 100644 --- a/app/views/versions/show.html.erb +++ b/app/views/versions/show.html.erb @@ -5,7 +5,7 @@ <%= call_hook(:view_versions_show_contextual, { :version => @version, :project => @project }) %> -

    <%= h(@version.name) %>

    +

    <%= @version.name %>

    <%= render :partial => 'versions/overview', :locals => {:version => @version} %> diff --git a/app/views/wiki/annotate.html.erb b/app/views/wiki/annotate.html.erb index b1b765909..950a5a77c 100644 --- a/app/views/wiki/annotate.html.erb +++ b/app/views/wiki/annotate.html.erb @@ -13,7 +13,7 @@

    <%= @annotate.content.author ? link_to_user(@annotate.content.author) : l(:label_user_anonymous) %>, <%= format_time(@annotate.content.updated_on) %>
    - <%=h @annotate.content.comments %> + <%= @annotate.content.comments %>

    <% colors = Hash.new {|k,v| k[v] = (k.size % 12) } %> @@ -27,8 +27,8 @@
    <%= link_to line[0], :controller => 'wiki', :action => 'show', :project_id => @project, :id => @page.title, :version => line[0] %><%= h(line[1]) %>
    <%=h line[2] %>
    <%= line[1] %>
    <%= line[2] %>