From: Nick Burch <nick@apache.org>
Date: Wed, 21 Aug 2013 09:41:15 +0000 (+0000)
Subject: Push the fix for bug #55248 up to the Sheet interface (was XSSF only before)
X-Git-Tag: REL_3_10_BETA2~17
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=b7db2fceef95b2144049950951d89a3ad2b40ac9;p=poi.git

Push the fix for bug #55248 up to the Sheet interface (was XSSF only before)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1516124 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/src/java/org/apache/poi/hssf/usermodel/HSSFSheet.java b/src/java/org/apache/poi/hssf/usermodel/HSSFSheet.java
index 76008ddab3..c99a843e34 100644
--- a/src/java/org/apache/poi/hssf/usermodel/HSSFSheet.java
+++ b/src/java/org/apache/poi/hssf/usermodel/HSSFSheet.java
@@ -1242,6 +1242,19 @@ public final class HSSFSheet implements org.apache.poi.ss.usermodel.Sheet {
         return _sheet.getLeftCol();
     }
 
+    /**
+     * Sets desktop window pane display area, when the
+     * file is first opened in a viewer.
+     *
+     * @param toprow  the top row to show in desktop window pane
+     * @param leftcol the left column to show in desktop window pane
+     */
+    public void showInPane(int toprow, int leftcol) {
+        int maxrow = SpreadsheetVersion.EXCEL97.getLastRowIndex();
+        if (toprow > maxrow) throw new IllegalArgumentException("Maximum row number is " + maxrow);
+        
+        showInPane((short)toprow, (short)leftcol);
+    }
     /**
      * Sets desktop window pane display area, when the
      * file is first opened in a viewer.
diff --git a/src/java/org/apache/poi/ss/usermodel/Sheet.java b/src/java/org/apache/poi/ss/usermodel/Sheet.java
index 91caad02ff..62d2e04ef2 100644
--- a/src/java/org/apache/poi/ss/usermodel/Sheet.java
+++ b/src/java/org/apache/poi/ss/usermodel/Sheet.java
@@ -582,6 +582,16 @@ public interface Sheet extends Iterable<Row> {
      * @param toprow the top row to show in desktop window pane
      * @param leftcol the left column to show in desktop window pane
      */
+    void showInPane(int toprow, int leftcol);
+
+    /**
+     * Sets desktop window pane display area, when the
+     * file is first opened in a viewer.
+     *
+     * @param toprow the top row to show in desktop window pane
+     * @param leftcol the left column to show in desktop window pane
+     * @deprecated Use {@link #showInPane(int, int)} as there can be more than 32767 rows.
+     */
     void showInPane(short toprow, short leftcol);
 
     /**
diff --git a/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFSheet.java b/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFSheet.java
index 0af15ead35..37ce7fba2c 100644
--- a/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFSheet.java
+++ b/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFSheet.java
@@ -2411,7 +2411,7 @@ public class XSSFSheet extends POIXMLDocumentPart implements Sheet {
      * @param toprow the top row to show in desktop window pane
      * @param leftcol the left column to show in desktop window pane
      *
-     * @deprecated Use the version of showInPane() with ints as there can be more than 32767 rows.
+     * @deprecated Use {@link #showInPane(int, int)} as there can be more than 32767 rows.
      */
     @Deprecated
 	public void showInPane(short toprow, short leftcol) {