From: Mageti <etienne@mageti.fr>
Date: Wed, 10 Dec 2014 09:51:51 +0000 (+0100)
Subject: Correction for #723
X-Git-Tag: v0.9.99~1592^2~1
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=b7ebbb4064942ca5013207eb89c4e2dd045ba3ce;p=gitea.git

Correction for #723

Correction for #723
Bug was : decode failed if the password contains ```:```
---

diff --git a/modules/base/tool.go b/modules/base/tool.go
index 14c0e7d086..39d3e8abdc 100644
--- a/modules/base/tool.go
+++ b/modules/base/tool.go
@@ -48,11 +48,11 @@ func BasicAuthDecode(encoded string) (user string, name string, err error) {
 		return user, name, err
 	}
 
-	a := strings.Split(string(s), ":")
-	if len(a) == 2 {
-		user, name = a[0], a[1]
-	} else {
+	a := strings.SplitN(string(s), ":", 2)
+	if len(a) != 2 {
 		err = errors.New("decode failed")
+	} else {
+		user, name = a[0], a[1]
 	}
 	return user, name, err
 }