From: Stas Vilchik <vilchiks@gmail.com>
Date: Tue, 30 Aug 2016 09:29:40 +0000 (+0200)
Subject: SONAR-7962 increase visibility of size section
X-Git-Tag: 6.1-RC1~268
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=b95f7b0abf9272ef717a0d2f4bced584c18d4b9f;p=sonarqube.git

SONAR-7962 increase visibility of size section
---

diff --git a/server/sonar-web/src/main/js/apps/overview/meta/Meta.js b/server/sonar-web/src/main/js/apps/overview/meta/Meta.js
index d672a56badc..70d063d3101 100644
--- a/server/sonar-web/src/main/js/apps/overview/meta/Meta.js
+++ b/server/sonar-web/src/main/js/apps/overview/meta/Meta.js
@@ -44,15 +44,11 @@ const Meta = ({ component, measures }) => {
 
   return (
       <div className="overview-meta">
-        <div className="overview-meta-card">
-          {hasDescription && (
-              <div className="overview-meta-description big-spacer-bottom">
-                {description}
-              </div>
-          )}
-
-          <MetaLinks component={component}/>
-        </div>
+        {hasDescription && (
+            <div className="overview-meta-card overview-meta-description">
+              {description}
+            </div>
+        )}
 
         <MetaSize component={component} measures={measures}/>
 
@@ -64,6 +60,8 @@ const Meta = ({ component, measures }) => {
             <MetaQualityProfiles profiles={profiles}/>
         )}
 
+        <MetaLinks component={component}/>
+
         <MetaKey component={component}/>
 
         {showShowEvents && (
diff --git a/server/sonar-web/src/main/js/apps/overview/meta/MetaLinks.js b/server/sonar-web/src/main/js/apps/overview/meta/MetaLinks.js
index a6f610728fc..25984706b78 100644
--- a/server/sonar-web/src/main/js/apps/overview/meta/MetaLinks.js
+++ b/server/sonar-web/src/main/js/apps/overview/meta/MetaLinks.js
@@ -67,17 +67,19 @@ export default class MetaLinks extends React.Component {
     const orderedLinks = orderLinks(links);
 
     return (
-        <ul className="overview-meta-list">
-          {orderedLinks.map(link => (
-              <li key={link.id}>
-                <a className="link-with-icon" href={link.url} target="_blank">
-                  {this.renderLinkIcon(link)}
-                  &nbsp;
-                  {link.name}
-                </a>
-              </li>
-          ))}
-        </ul>
+        <div className="overview-meta-card">
+          <ul className="overview-meta-list">
+            {orderedLinks.map(link => (
+                <li key={link.id}>
+                  <a className="link-with-icon" href={link.url} target="_blank">
+                    {this.renderLinkIcon(link)}
+                    &nbsp;
+                    {link.name}
+                  </a>
+                </li>
+            ))}
+          </ul>
+        </div>
     );
   }
 }
diff --git a/server/sonar-web/src/main/js/apps/overview/meta/MetaSize.js b/server/sonar-web/src/main/js/apps/overview/meta/MetaSize.js
index 9c073cfe28f..8717d86e587 100644
--- a/server/sonar-web/src/main/js/apps/overview/meta/MetaSize.js
+++ b/server/sonar-web/src/main/js/apps/overview/meta/MetaSize.js
@@ -20,8 +20,8 @@
 import React from 'react';
 import { DrilldownLink } from '../../../components/shared/drilldown-link';
 import LanguageDistribution from '../../../components/charts/LanguageDistribution';
-import { translate } from '../../../helpers/l10n';
 import { formatMeasure } from '../../../helpers/measures';
+import { getMetricName } from '../helpers/metrics';
 
 export default class MetaSize extends React.Component {
   static propTypes = {
@@ -41,23 +41,15 @@ export default class MetaSize extends React.Component {
 
     return (
         <div id="overview-size" className="overview-meta-card">
-          <h4 className="overview-meta-header">
-            {translate('overview.domain.size')}
-          </h4>
-
-          <div>
-            <div id="overview-ncloc" className="overview-meta-size-ncloc">
-              <DrilldownLink
-                  className="overview-domain-secondary-measure-value"
-                  component={this.props.component.key}
-                  metric="ncloc">
-                {formatMeasure(ncloc.value, 'SHORT_INT')}
-              </DrilldownLink>
-            </div>
-            <div id="overview-language-distribution"
-                 className="overview-meta-size-lang-dist">
-              <LanguageDistribution distribution={languageDistribution.value}/>
-            </div>
+          <div id="overview-ncloc" className="overview-meta-size-ncloc">
+            <DrilldownLink component={this.props.component.key} metric="ncloc">
+              {formatMeasure(ncloc.value, 'SHORT_INT')}
+            </DrilldownLink>
+            <div className="overview-domain-measure-label text-muted">{getMetricName('ncloc')}</div>
+          </div>
+          <div id="overview-language-distribution"
+               className="overview-meta-size-lang-dist">
+            <LanguageDistribution distribution={languageDistribution.value}/>
           </div>
         </div>
     );
diff --git a/server/sonar-web/src/main/js/apps/overview/styles.css b/server/sonar-web/src/main/js/apps/overview/styles.css
index 3723eed7a14..8400857a470 100644
--- a/server/sonar-web/src/main/js/apps/overview/styles.css
+++ b/server/sonar-web/src/main/js/apps/overview/styles.css
@@ -259,14 +259,20 @@
 .overview-meta-size-ncloc {
   display: inline-block;
   vertical-align: middle;
-  width: 80px;
+  width: 100px;
   text-align: center;
 }
 
+.overview-meta-size-ncloc a {
+  line-height: 1;
+  font-size: 24px;
+  font-weight: 300;
+}
+
 .overview-meta-size-lang-dist {
   display: inline-block;
   vertical-align: middle;
-  width: 180px;
+  width: 160px;
   min-height: 40px;
   border-left: 1px solid #e6e6e6;
   box-sizing: border-box;