From: Jörn Zaefferer <joern.zaefferer@gmail.com>
Date: Wed, 4 May 2011 09:06:32 +0000 (+0200)
Subject: Popup: Partial fix for closing popup when trigger is clicked again.
X-Git-Tag: 1.9m5~94
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=bba4cb2be68ae6ca71be987bf13f8c7834242221;p=jquery-ui.git

Popup: Partial fix for closing popup when trigger is clicked again.
---

diff --git a/tests/visual/menu/popup.js b/tests/visual/menu/popup.js
index f57cba699..947888eec 100644
--- a/tests/visual/menu/popup.js
+++ b/tests/visual/menu/popup.js
@@ -39,6 +39,10 @@ $.widget( "ui.popup", {
 		this._bind(this.options.trigger, {
 			click: function( event ) {
 				event.preventDefault();
+				if (this.open) {
+					// let it propagate to close
+					return;
+				}
 				var that = this;
 				setTimeout(function() {
 					that._open( event );
@@ -47,10 +51,14 @@ $.widget( "ui.popup", {
 		});
 		
 		this._bind(this.element, {
-			blur: "_close"
+			// TODO also triggered when open and clicking the trigger again
+			// figure out how to close in that case, while still closing on regular blur
+			//blur: "_close"
 		});
 
 		this._bind({
+			// TODO only triggerd on element if it can receive focus
+			// bind to document instead?
 			keyup: function( event ) {
 				if (event.keyCode == $.ui.keyCode.ESCAPE && this.element.is( ":visible" )) {
 					this._close( event );