From: Pierre Ossman <ossman@cendio.se>
Date: Mon, 18 May 2020 16:53:43 +0000 (+0200)
Subject: Support calling methods from timers
X-Git-Tag: v1.11.90~74^2~26
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=bd5ad5e79f35ec284d250aed66db4baa290c6089;p=tigervnc.git

Support calling methods from timers

We can't safely use the normal timers in base classes as we cannot
guarantee that subclasses will call the base class' handleTimeout()
properly if the subclass overrides it.
---

diff --git a/common/rfb/Timer.h b/common/rfb/Timer.h
index ef509725..ddfce1b2 100644
--- a/common/rfb/Timer.h
+++ b/common/rfb/Timer.h
@@ -35,6 +35,8 @@ namespace rfb {
      dispatch elapsed Timer callbacks and to determine how long to wait in select() for
      the next timeout to occur.
 
+     For classes that can be derived it's best to use MethodTimer which can call a specific
+     method on the class, thus avoiding conflicts when subclassing.
   */
 
   struct Timer {
@@ -101,6 +103,19 @@ namespace rfb {
     static std::list<Timer*> pending;
   };
 
+  template<class T> class MethodTimer
+    : public Timer, public Timer::Callback {
+  public:
+    MethodTimer(T* obj_, bool (T::*cb_)(Timer*))
+      : Timer(this), obj(obj_), cb(cb_) {}
+
+    virtual bool handleTimeout(Timer* t) { return (obj->*cb)(t); }
+
+  private:
+    T* obj;
+    bool (T::*cb)(Timer*);
+  };
+
 };
 
 #endif