From: Simon Brandhof <simon.brandhof@sonarsource.com>
Date: Tue, 8 May 2018 15:04:18 +0000 (+0200)
Subject: Fix false-positive in RuleIndexTest
X-Git-Tag: 7.5~1211
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=c0623a85b48f7504a65498baf82eada5a1cf6ec9;p=sonarqube.git

Fix false-positive in RuleIndexTest
---

diff --git a/server/sonar-server/src/test/java/org/sonar/server/rule/index/RuleIndexTest.java b/server/sonar-server/src/test/java/org/sonar/server/rule/index/RuleIndexTest.java
index 51bd2f1dda8..b5f54fc075b 100644
--- a/server/sonar-server/src/test/java/org/sonar/server/rule/index/RuleIndexTest.java
+++ b/server/sonar-server/src/test/java/org/sonar/server/rule/index/RuleIndexTest.java
@@ -217,12 +217,22 @@ public class RuleIndexTest {
 
   @Test
   public void search_content_by_query() {
-    RuleDefinitionDto rule1 = createJavaRule(rule -> rule.setRuleKey("123").setDescription("My great rule CWE-123 which makes your code 1000 times better!"));
-    RuleDefinitionDto rule2 = createJavaRule(rule -> rule.setRuleKey("124").setDescription("Another great and shiny rule CWE-124"));
-    RuleDefinitionDto rule3 = createJavaRule(rule -> rule.setRuleKey("1000").setDescription("Another great rule CWE-1000"));
+    // it's important to set all the fields being used by the search (name, desc, key, lang, ...),
+    // otherwise the generated random values may raise false-positives
+    RuleDefinitionDto rule1 = createJavaRule(rule -> rule.setRuleKey("123")
+      .setName("rule 123")
+      .setDescription("My great rule CWE-123 which makes your code 1000 times better!"));
+    RuleDefinitionDto rule2 = createJavaRule(rule -> rule.setRuleKey("124")
+      .setName("rule 124")
+      .setDescription("Another great and shiny rule CWE-124"));
+    RuleDefinitionDto rule3 = createJavaRule(rule -> rule.setRuleKey("1000")
+      .setName("rule 1000")
+      .setDescription("Another great rule CWE-1000"));
     RuleDefinitionDto rule4 = createJavaRule(rule -> rule.setRuleKey("404")
+      .setName("rule 404")
       .setDescription("<h1>HTML-Geeks</h1><p style=\"color:blue\">special formatting!</p><table><tr><td>inside</td><td>tables</td></tr></table>"));
     RuleDefinitionDto rule5 = createJavaRule(rule -> rule.setRuleKey("405")
+      .setName("rule 405")
       .setDescription("internationalization missunderstandings alsdkjfnadklsjfnadkdfnsksdjfn"));
     index();