From: Stas Vilchik <vilchiks@gmail.com>
Date: Tue, 7 Oct 2014 12:56:22 +0000 (+0200)
Subject: SONAR-5598 The ">" icon used on filters in the headers is confusing
X-Git-Tag: 4.5.1-RC1~84^2~1
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=c310b49e7e463621296e8efd4618afc39ec74a43;p=sonarqube.git

SONAR-5598 The ">" icon used on filters in the headers is confusing
---

diff --git a/server/sonar-web/src/main/hbs/component-viewer/header/_cw-header-link.hbs b/server/sonar-web/src/main/hbs/component-viewer/header/_cw-header-link.hbs
index 70f66492319..f61e72781c6 100644
--- a/server/sonar-web/src/main/hbs/component-viewer/header/_cw-header-link.hbs
+++ b/server/sonar-web/src/main/hbs/component-viewer/header/_cw-header-link.hbs
@@ -1,5 +1,5 @@
 <li><a class="item {{cl}}" data-metric="{{label}}">
   <span class="label">{{t 'metric' label 'name'}}</span>
   <span class="number">{{value}}</span>
-  <i class="icon-chevron-right"></i>
-</a></li>
\ No newline at end of file
+  <i class="icon-component-viewer-filter"></i>
+</a></li>
diff --git a/server/sonar-web/src/main/hbs/component-viewer/header/cw-issues-header.hbs b/server/sonar-web/src/main/hbs/component-viewer/header/cw-issues-header.hbs
index 91ba1ecc927..4f8fcbfbcd9 100644
--- a/server/sonar-web/src/main/hbs/component-viewer/header/cw-issues-header.hbs
+++ b/server/sonar-web/src/main/hbs/component-viewer/header/cw-issues-header.hbs
@@ -14,31 +14,31 @@
     {{#if currentIssue}}
       <li><a class="item js-filter-current-issue">
         <span>{{t 'component_viewer.issues.current_issue'}}</span>
-        <i class="icon-chevron-right"></i>
+        <i class="icon-component-viewer-filter"></i>
       </a></li>
     {{/if}}
     {{#unless state.removed}}
       <li><a class="item js-filter-unresolved-issues">
         <span>{{t 'component_viewer.issues.unresolved_issues'}}</span>
-        <i class="icon-chevron-right"></i>
+        <i class="icon-component-viewer-filter"></i>
       </a></li>
     {{/unless}}
     {{#unless state.removed}}
       <li><a class="item js-filter-open-issues">
         <span>{{t 'component_viewer.issues.open_issues'}}</span>
-        <i class="icon-chevron-right"></i>
+        <i class="icon-component-viewer-filter"></i>
       </a></li>
     {{/unless}}
     {{#unless state.removed}}
       <li><a class="item js-filter-fixed-issues">
         <span>{{t 'component_viewer.issues.fixed_issues'}}</span>
-        <i class="icon-chevron-right"></i>
+        <i class="icon-component-viewer-filter"></i>
       </a></li>
     {{/unless}}
     {{#unless state.removed}}
       <li><a class="item js-filter-false-positive-issues">
         <span>{{t 'component_viewer.issues.false_positive_issues'}}</span>
-        <i class="icon-chevron-right"></i>
+        <i class="icon-component-viewer-filter"></i>
       </a></li>
     {{/unless}}
   </ul>
@@ -55,7 +55,7 @@
           <li><a class="item js-filter-{{key}}-issues">
             <span>{{severityIcon key}} {{name}}</span>
             <span class="number">{{count}}</span>
-            <i class="icon-chevron-right"></i>
+            <i class="icon-component-viewer-filter"></i>
           </a></li>
         {{else}}
           <li><span class="item">
@@ -79,7 +79,7 @@
           <li><a class="item js-filter-rule" data-rule="{{key}}" title="{{name}}">
             <span>{{name}}</span>
             <span class="number">{{count}}</span>
-            <i class="icon-chevron-right"></i>
+            <i class="icon-component-viewer-filter"></i>
           </a></li>
         {{else}}
           <li><span class="item">
diff --git a/server/sonar-web/src/main/hbs/component-viewer/header/cw-scm-header.hbs b/server/sonar-web/src/main/hbs/component-viewer/header/cw-scm-header.hbs
index 2cf3da9e995..d208b7cb185 100644
--- a/server/sonar-web/src/main/hbs/component-viewer/header/cw-scm-header.hbs
+++ b/server/sonar-web/src/main/hbs/component-viewer/header/cw-scm-header.hbs
@@ -8,7 +8,7 @@
   <ul class="component-viewer-header-expanded-bar-section-list">
     <li><a class="item js-filter-modified-lines">
       <span>{{t 'component_viewer.scm.modified_lines'}}</span>
-      <i class="icon-chevron-right"></i>
+      <i class="icon-component-viewer-filter"></i>
     </a></li>
   </ul>
 </div>
diff --git a/server/sonar-web/src/main/hbs/component-viewer/header/cw-tests-header.hbs b/server/sonar-web/src/main/hbs/component-viewer/header/cw-tests-header.hbs
index c11d69bc279..6cba8cef9c4 100644
--- a/server/sonar-web/src/main/hbs/component-viewer/header/cw-tests-header.hbs
+++ b/server/sonar-web/src/main/hbs/component-viewer/header/cw-tests-header.hbs
@@ -72,7 +72,7 @@
             {{#if coveredLines}}
               <span class="number">{{coveredLines}}</span>
             {{/if}}
-            <i class="icon-chevron-right"></i>
+            <i class="icon-component-viewer-filter"></i>
           </a></li>
         {{else}}
           <li><span class="item" data-name="{{name}}" data-status="{{status}}" title="{{name}}">
diff --git a/server/sonar-web/src/main/less/component-viewer.less b/server/sonar-web/src/main/less/component-viewer.less
index 58ee62b571d..a24fcd828ab 100644
--- a/server/sonar-web/src/main/less/component-viewer.less
+++ b/server/sonar-web/src/main/less/component-viewer.less
@@ -556,7 +556,7 @@
     & > i {
       position: absolute;
       top: 50%;
-      right: 10px;
+      right: 6px;
       margin-top: -7px;
     }
 
diff --git a/server/sonar-web/src/main/less/icons.less b/server/sonar-web/src/main/less/icons.less
index f13dc75e7d5..fa174f8b19b 100644
--- a/server/sonar-web/src/main/less/icons.less
+++ b/server/sonar-web/src/main/less/icons.less
@@ -516,6 +516,11 @@ a[class^="icon-"], a[class*=" icon-"] {
   content: "\f016";
   font-size: @iconFontSize;
 }
+.icon-component-viewer-filter:before {
+  content: "\e60e";
+  color: #999;
+  font-size: @iconSmallFontSize;
+}
 
 
 /*