From: Simon Brandhof <simon.brandhof@sonarsource.com>
Date: Wed, 29 Oct 2014 20:57:25 +0000 (+0100)
Subject: SONAR-5792 do not support yes/no values on rails web services
X-Git-Tag: 5.0-RC1~501
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=c3265ba39c8b6646b6e4dab69cf20af3b9865b45;p=sonarqube.git

SONAR-5792 do not support yes/no values on rails web services
---

diff --git a/server/sonar-server/src/main/java/org/sonar/server/component/ws/ProjectsWs.java b/server/sonar-server/src/main/java/org/sonar/server/component/ws/ProjectsWs.java
index 5bb14174d3e..3f0f0831c24 100644
--- a/server/sonar-server/src/main/java/org/sonar/server/component/ws/ProjectsWs.java
+++ b/server/sonar-server/src/main/java/org/sonar/server/component/ws/ProjectsWs.java
@@ -57,22 +57,22 @@ public class ProjectsWs implements WebService {
     action.createParam("desc")
       .setDescription("Load project description")
       .setDefaultValue("true")
-      .setBooleanPossibleValues();
+      .setPossibleValues("true", "false");
 
     action.createParam("subprojects")
       .setDescription("Load sub-projects. Ignored if the parameter key is set")
       .setDefaultValue("false")
-      .setBooleanPossibleValues();
+      .setPossibleValues("true", "false");
 
     action.createParam("views")
       .setDescription("Load views and sub-views. Ignored if the parameter key is set")
       .setDefaultValue("false")
-      .setBooleanPossibleValues();
+      .setPossibleValues("true", "false");
 
     action.createParam("libs")
       .setDescription("Load libraries. Ignored if the parameter key is set")
       .setDefaultValue("false")
-      .setBooleanPossibleValues();
+      .setPossibleValues("true", "false");
 
     action.createParam("versions")
       .setDescription("Load version")
diff --git a/server/sonar-server/src/main/java/org/sonar/server/component/ws/ResourcesWs.java b/server/sonar-server/src/main/java/org/sonar/server/component/ws/ResourcesWs.java
index 6431124137f..428cb6cef3e 100644
--- a/server/sonar-server/src/main/java/org/sonar/server/component/ws/ResourcesWs.java
+++ b/server/sonar-server/src/main/java/org/sonar/server/component/ws/ResourcesWs.java
@@ -90,7 +90,7 @@ public class ResourcesWs implements WebService {
     action.createParam("verbose")
       .setDescription("Add some data to response")
       .setDefaultValue("false")
-      .setBooleanPossibleValues();
+      .setPossibleValues("true", "false");
 
     action.createParam("limit")
       .setDescription("Limit the number of results. Only used if one metric, and only one, is set")
@@ -100,12 +100,12 @@ public class ResourcesWs implements WebService {
       .setDescription("Include trends and period variations in response: add &lttrend&gt (1 if better, else worse), &ltvar&gt (1 if measure value increases) " +
         "and nodes &ltp*&gt for period variations")
       .setDefaultValue("false")
-      .setBooleanPossibleValues();
+      .setPossibleValues("true", "false");
 
     action.createParam("includealerts")
       .setDescription("Include alerts data: add nodes &ltalert&gt (ERROR, WARN, OK) and &ltalert_text&gt")
       .setDefaultValue("false")
-      .setBooleanPossibleValues();
+      .setPossibleValues("true", "false");
 
     action.createParam("rules")
       .setDescription("Filter on rules: setting it to true will return rules id and rule name for measure having such info " +
@@ -131,7 +131,7 @@ public class ResourcesWs implements WebService {
     action.createParam("display_key")
       .setDescription("Return the resource key instead of the resource id")
       .setDefaultValue("false")
-      .setBooleanPossibleValues();
+      .setPossibleValues("true", "false");
 
     action.createParam("q")
       .setDescription("Comma-separated list of qualifiers")
diff --git a/server/sonar-server/src/main/java/org/sonar/server/issue/ws/IssuesWs.java b/server/sonar-server/src/main/java/org/sonar/server/issue/ws/IssuesWs.java
index 090340e35cb..c53debfe03f 100644
--- a/server/sonar-server/src/main/java/org/sonar/server/issue/ws/IssuesWs.java
+++ b/server/sonar-server/src/main/java/org/sonar/server/issue/ws/IssuesWs.java
@@ -281,8 +281,8 @@ public class IssuesWs implements WebService {
       .setRequired(true)
       .setExampleValue("assign,plan");
     action.createParam("assign.assignee")
-      .setDescription("To assign the list of issues to a specific user (login), or unassign all the issues")
-      .setExampleValue("sbrandhof");
+      .setDescription("To assign the list of issues to a specific user (login), or un-assign all the issues")
+      .setExampleValue("john.smith");
     action.createParam("set_severity.severity")
       .setDescription("To change the severity of the list of issues")
       .setExampleValue(Severity.BLOCKER)
@@ -296,11 +296,11 @@ public class IssuesWs implements WebService {
       .setPossibleValues(DefaultTransitions.ALL);
     action.createParam("comment")
       .setDescription("To add a comment to a list of issues")
-      .setExampleValue("blabla...");
+      .setExampleValue("Here is my comment");
     action.createParam("sendNotifications")
       .setDescription("Available since version 4.0")
       .setDefaultValue("false")
-      .setBooleanPossibleValues();
+      .setPossibleValues("true", "false");
     RailsHandler.addFormatParam(action);
   }
 
diff --git a/server/sonar-server/src/main/java/org/sonar/server/user/ws/UsersWs.java b/server/sonar-server/src/main/java/org/sonar/server/user/ws/UsersWs.java
index aeca5aff44e..518a39f5987 100644
--- a/server/sonar-server/src/main/java/org/sonar/server/user/ws/UsersWs.java
+++ b/server/sonar-server/src/main/java/org/sonar/server/user/ws/UsersWs.java
@@ -50,7 +50,7 @@ public class UsersWs implements WebService {
     action.createParam("includeDeactivated")
       .setDescription("Include deactivated users")
       .setDefaultValue("false")
-      .setBooleanPossibleValues();
+      .setPossibleValues("true", "false");
 
     action.createParam("logins")
       .setDescription("Comma-separated list of user logins")