From: Dmitry Petrov Date: Wed, 6 Oct 2010 14:24:03 +0000 (-0400) Subject: Autocomplete: Prevent keypress events caused by enter key when selecting an item... X-Git-Tag: 1.8.6~36 X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=c3b282fceb8b5161c013575bf01c652d6573d72e;p=jquery-ui.git Autocomplete: Prevent keypress events caused by enter key when selecting an item. Fixes #6055 - Autocomplete: Selecting an item by pressing enter submits the form in Opera. --- diff --git a/ui/jquery.ui.autocomplete.js b/ui/jquery.ui.autocomplete.js index 6c4492370..8b41a24dc 100644 --- a/ui/jquery.ui.autocomplete.js +++ b/ui/jquery.ui.autocomplete.js @@ -28,7 +28,9 @@ $.widget( "ui.autocomplete", { }, _create: function() { var self = this, - doc = this.element[ 0 ].ownerDocument; + doc = this.element[ 0 ].ownerDocument, + suppressKeyPress; + this.element .addClass( "ui-autocomplete-input" ) .attr( "autocomplete", "off" ) @@ -43,6 +45,7 @@ $.widget( "ui.autocomplete", { return; } + suppressKeyPress = false; var keyCode = $.ui.keyCode; switch( event.keyCode ) { case keyCode.PAGE_UP: @@ -65,6 +68,9 @@ $.widget( "ui.autocomplete", { case keyCode.NUMPAD_ENTER: // when menu is open and has focus if ( self.menu.active ) { + // #6055 - Opera still allows the keypress to occur + // which causes forms to submit + suppressKeyPress = true; event.preventDefault(); } //passthrough - ENTER and TAB both select the current element @@ -91,6 +97,12 @@ $.widget( "ui.autocomplete", { break; } }) + .bind( "keypress.autocomplete", function( event ) { + if ( suppressKeyPress ) { + suppressKeyPress = false; + event.preventDefault(); + } + }) .bind( "focus.autocomplete", function() { if ( self.options.disabled ) { return;