From: Fabrice Bellingard <bellingard@gmail.com>
Date: Thu, 9 Feb 2012 17:49:46 +0000 (+0100)
Subject: SONAR-3014 Improve display of links not starting with 'http(s)'
X-Git-Tag: 2.14~119
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=c3bc6982b7e165304e269d7b7ef309a05148be98;p=sonarqube.git

SONAR-3014 Improve display of links not starting with 'http(s)'

Initial request:
=> The main project dashboard "Links" column provides a Developer
   Connection link that browsers do not support
---

diff --git a/plugins/sonar-core-plugin/src/main/resources/org/sonar/plugins/core/widgets/description.html.erb b/plugins/sonar-core-plugin/src/main/resources/org/sonar/plugins/core/widgets/description.html.erb
index 758eb00d986..8152bde247f 100644
--- a/plugins/sonar-core-plugin/src/main/resources/org/sonar/plugins/core/widgets/description.html.erb
+++ b/plugins/sonar-core-plugin/src/main/resources/org/sonar/plugins/core/widgets/description.html.erb
@@ -6,8 +6,8 @@
   <table class="width100 marginbottom10">
     <tbody>
     <tr>
-      <td><%= message('widget.description.key') -%>: </td>
-      <td id="resource_key"><%= @project.key -%></td>
+      <td width="25%"><%= message('widget.description.key') -%>: </td>
+      <td width="75%" id="resource_key"><%= @project.key -%></td>
     </tr>
     <% if @project.language %>
     <tr>
@@ -35,7 +35,15 @@
         <td valign="top"><%= message('widget.description.links') -%>: </td>
         <td id="resource_links">
         <% @project.project_links.sort.each do |link| %>
-          <%= link_to(image_tag(link.icon, :alt => link.name), link.href , :popup => true, :class => 'nolink') -%> <%= link_to(h(link.name), link.href, :popup => true) -%><br/>
+          <div>
+          <%= link_to(image_tag(link.icon, :alt => link.name), link.href , :popup => true, :class => 'nolink') -%>
+          <% if link.href.starts_with?('http') %>
+            <%= link_to(h(link.name), link.href, :popup => true) -%>
+          <% else %>
+            <a href="#" onclick="$('link_<%= link.id -%>').toggle();return false;"><%= h(link.name) -%></a>
+            <div id="link_<%= link.id -%>" style="padding-left: 20px; display:none"><%= h(link.href) -%></div>
+          <% end %>
+          </div>
         <% end %>
         </td>
       </tr>