From: 7PH Date: Thu, 2 Mar 2023 10:21:09 +0000 (+0100) Subject: SONAR-18553 Migrate concise issues list components tests to RTL X-Git-Tag: 10.0.0.68432~174 X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=c6011fd3a2e8a7284ea46b3abe9310a483aaad76;p=sonarqube.git SONAR-18553 Migrate concise issues list components tests to RTL --- diff --git a/server/sonar-web/src/main/js/apps/issues/conciseIssuesList/ConciseIssueBox.tsx b/server/sonar-web/src/main/js/apps/issues/conciseIssuesList/ConciseIssueBox.tsx index 12568435f02..e41bef46e56 100644 --- a/server/sonar-web/src/main/js/apps/issues/conciseIssuesList/ConciseIssueBox.tsx +++ b/server/sonar-web/src/main/js/apps/issues/conciseIssuesList/ConciseIssueBox.tsx @@ -79,7 +79,6 @@ export default class ConciseIssueBox extends React.PureComponent { className="concise-issue-box-message" aria-current={selected} innerRef={(node) => (this.messageElement = node)} - onClick={this.handleClick} > { - state: State = { collapsed: true }; + state = { collapsed: true }; handleExpandClick = () => { this.setState({ collapsed: false }); @@ -78,13 +78,13 @@ export default class ConciseIssueLocations extends React.PureComponent - {badges.slice(0, LIMIT - 1)} + {badges.slice(0, COLLAPSE_LIMIT - 1)} {this.renderExpandButton()} ); diff --git a/server/sonar-web/src/main/js/apps/issues/conciseIssuesList/__tests__/ConciseIssue-test.tsx b/server/sonar-web/src/main/js/apps/issues/conciseIssuesList/__tests__/ConciseIssue-test.tsx deleted file mode 100644 index 954e447b9ba..00000000000 --- a/server/sonar-web/src/main/js/apps/issues/conciseIssuesList/__tests__/ConciseIssue-test.tsx +++ /dev/null @@ -1,82 +0,0 @@ -/* - * SonarQube - * Copyright (C) 2009-2023 SonarSource SA - * mailto:info AT sonarsource DOT com - * - * This program is free software; you can redistribute it and/or - * modify it under the terms of the GNU Lesser General Public - * License as published by the Free Software Foundation; either - * version 3 of the License, or (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public License - * along with this program; if not, write to the Free Software Foundation, - * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. - */ -import { shallow } from 'enzyme'; -import * as React from 'react'; -import { Issue } from '../../../../types/types'; -import ConciseIssue from '../ConciseIssue'; - -const issue: Issue = { - actions: [], - component: '', - componentLongName: 'src/file.js', - componentQualifier: '', - componentUuid: '', - creationDate: '', - flows: [], - flowsWithType: [], - key: '', - message: '', - project: '', - projectKey: '', - projectName: '', - rule: '', - ruleName: '', - secondaryLocations: [], - severity: '', - status: '', - transitions: [], - type: 'BUG', -}; - -it('should render', () => { - expect( - shallow( - - ) - ).toMatchSnapshot(); -}); - -it('should not render component', () => { - expect( - shallow( - - ).find('ConciseIssueComponent') - ).toHaveLength(0); -}); diff --git a/server/sonar-web/src/main/js/apps/issues/conciseIssuesList/__tests__/ConciseIssueBox-test.tsx b/server/sonar-web/src/main/js/apps/issues/conciseIssuesList/__tests__/ConciseIssueBox-test.tsx deleted file mode 100644 index bbea7fd404c..00000000000 --- a/server/sonar-web/src/main/js/apps/issues/conciseIssuesList/__tests__/ConciseIssueBox-test.tsx +++ /dev/null @@ -1,53 +0,0 @@ -/* - * SonarQube - * Copyright (C) 2009-2023 SonarSource SA - * mailto:info AT sonarsource DOT com - * - * This program is free software; you can redistribute it and/or - * modify it under the terms of the GNU Lesser General Public - * License as published by the Free Software Foundation; either - * version 3 of the License, or (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public License - * along with this program; if not, write to the Free Software Foundation, - * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. - */ -import { shallow } from 'enzyme'; -import * as React from 'react'; -import { mockIssue } from '../../../../helpers/testMocks'; -import { click, waitAndUpdate } from '../../../../helpers/testUtils'; -import ConciseIssueBox from '../ConciseIssueBox'; - -it('should render correctly', async () => { - const onClick = jest.fn(); - const issue = mockIssue(); - const wrapper = shallowRender({ onClick, issue }); - await waitAndUpdate(wrapper); - expect(wrapper).toMatchSnapshot(); - - click(wrapper.find('.concise-issue-box')); - expect(onClick).toHaveBeenCalledWith(issue.key); - - expect(shallowRender({ issue: mockIssue(true), selected: true })).toMatchSnapshot(); -}); - -const shallowRender = (props: Partial = {}) => { - return shallow( - - ); -}; diff --git a/server/sonar-web/src/main/js/apps/issues/conciseIssuesList/__tests__/ConciseIssueComponent-test.tsx b/server/sonar-web/src/main/js/apps/issues/conciseIssuesList/__tests__/ConciseIssueComponent-test.tsx deleted file mode 100644 index 7db8fa14b55..00000000000 --- a/server/sonar-web/src/main/js/apps/issues/conciseIssuesList/__tests__/ConciseIssueComponent-test.tsx +++ /dev/null @@ -1,28 +0,0 @@ -/* - * SonarQube - * Copyright (C) 2009-2023 SonarSource SA - * mailto:info AT sonarsource DOT com - * - * This program is free software; you can redistribute it and/or - * modify it under the terms of the GNU Lesser General Public - * License as published by the Free Software Foundation; either - * version 3 of the License, or (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public License - * along with this program; if not, write to the Free Software Foundation, - * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. - */ -import { shallow } from 'enzyme'; -import * as React from 'react'; -import ConciseIssueComponent from '../ConciseIssueComponent'; - -it('should render', () => { - expect( - shallow() - ).toMatchSnapshot(); -}); diff --git a/server/sonar-web/src/main/js/apps/issues/conciseIssuesList/__tests__/ConciseIssueLocationBadge-test.tsx b/server/sonar-web/src/main/js/apps/issues/conciseIssuesList/__tests__/ConciseIssueLocationBadge-test.tsx deleted file mode 100644 index ed45c99e8b7..00000000000 --- a/server/sonar-web/src/main/js/apps/issues/conciseIssuesList/__tests__/ConciseIssueLocationBadge-test.tsx +++ /dev/null @@ -1,26 +0,0 @@ -/* - * SonarQube - * Copyright (C) 2009-2023 SonarSource SA - * mailto:info AT sonarsource DOT com - * - * This program is free software; you can redistribute it and/or - * modify it under the terms of the GNU Lesser General Public - * License as published by the Free Software Foundation; either - * version 3 of the License, or (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public License - * along with this program; if not, write to the Free Software Foundation, - * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. - */ -import { shallow } from 'enzyme'; -import * as React from 'react'; -import ConciseIssueLocationBadge from '../ConciseIssueLocationBadge'; - -it('should render', () => { - expect(shallow()).toMatchSnapshot(); -}); diff --git a/server/sonar-web/src/main/js/apps/issues/conciseIssuesList/__tests__/ConciseIssueLocations-test.tsx b/server/sonar-web/src/main/js/apps/issues/conciseIssuesList/__tests__/ConciseIssueLocations-test.tsx deleted file mode 100644 index 5e09d67f6fe..00000000000 --- a/server/sonar-web/src/main/js/apps/issues/conciseIssuesList/__tests__/ConciseIssueLocations-test.tsx +++ /dev/null @@ -1,66 +0,0 @@ -/* - * SonarQube - * Copyright (C) 2009-2023 SonarSource SA - * mailto:info AT sonarsource DOT com - * - * This program is free software; you can redistribute it and/or - * modify it under the terms of the GNU Lesser General Public - * License as published by the Free Software Foundation; either - * version 3 of the License, or (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public License - * along with this program; if not, write to the Free Software Foundation, - * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. - */ -import { shallow } from 'enzyme'; -import * as React from 'react'; -import ConciseIssueLocations from '../ConciseIssueLocations'; - -const textRange = { startLine: 1, startOffset: 1, endLine: 1, endOffset: 1 }; - -const loc = { component: '', msg: '', textRange }; - -it('should render secondary locations', () => { - const issue = { - flows: [], - secondaryLocations: [loc, loc, loc], - }; - expect( - shallow( - - ) - ).toMatchSnapshot(); -}); - -it('should render one flow', () => { - const issue = { - flows: [[loc, loc, loc]], - secondaryLocations: [], - }; - expect( - shallow( - - ) - ).toMatchSnapshot(); -}); - -it('should render several flows', () => { - const issue = { - flows: [ - [loc, loc, loc], - [loc, loc], - [loc, loc, loc], - ], - secondaryLocations: [], - }; - expect( - shallow( - - ) - ).toMatchSnapshot(); -}); diff --git a/server/sonar-web/src/main/js/apps/issues/conciseIssuesList/__tests__/ConciseIssues-it.tsx b/server/sonar-web/src/main/js/apps/issues/conciseIssuesList/__tests__/ConciseIssues-it.tsx new file mode 100644 index 00000000000..0b1b38baf71 --- /dev/null +++ b/server/sonar-web/src/main/js/apps/issues/conciseIssuesList/__tests__/ConciseIssues-it.tsx @@ -0,0 +1,332 @@ +/* + * SonarQube + * Copyright (C) 2009-2023 SonarSource SA + * mailto:info AT sonarsource DOT com + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 3 of the License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public License + * along with this program; if not, write to the Free Software Foundation, + * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. + */ +import { screen } from '@testing-library/react'; +import userEvent from '@testing-library/user-event'; +import * as React from 'react'; +import { byRole, byText } from 'testing-library-selector'; +import { mockFlowLocation, mockIssue } from '../../../../helpers/testMocks'; +import { renderComponent } from '../../../../helpers/testReactTestingUtils'; +import { FlowType, Issue } from '../../../../types/types'; +import { COLLAPSE_LIMIT } from '../ConciseIssueLocations'; +import ConciseIssuesList, { ConciseIssuesListProps } from '../ConciseIssuesList'; +import ConciseIssuesListHeader, { ConciseIssuesListHeaderProps } from '../ConciseIssuesListHeader'; + +const loc = mockFlowLocation(); +const issues = [ + mockIssue(false, { + key: 'issue1', + message: 'Issue 1', + component: 'foo', + componentLongName: 'Long Foo', + }), + mockIssue(false, { + key: 'issue2', + message: 'Issue 2', + component: 'foo', + componentLongName: 'Long Foo', + }), + mockIssue(false, { + key: 'issue3', + message: 'Issue 3', + component: 'bar', + componentLongName: 'Long Bar', + }), + mockIssue(true, { + key: 'issue4', + message: 'Issue 4', + component: 'foo', + componentLongName: 'Long Foo', + flowsWithType: [ + { + type: FlowType.DATA, + description: 'Flow Foo', + locations: [mockFlowLocation({ msg: 'loc 1' })], + }, + ], + }), +]; + +const originalScrollIntoView = HTMLElement.prototype.scrollIntoView; + +beforeAll(() => { + HTMLElement.prototype.scrollIntoView = jest.fn(); +}); + +afterAll(() => { + HTMLElement.prototype.scrollIntoView = originalScrollIntoView; +}); + +describe('rendering', () => { + it('should hide the back button', () => { + const { ui } = getPageObject(); + renderConciseIssues(issues, {}, { displayBackButton: false }); + + expect(ui.headerBackButton.query()).not.toBeInTheDocument(); + }); + + it('should render concise issues without duplicating component', () => { + renderConciseIssues(issues); + + expect(screen.getAllByTitle('Long Foo')).toHaveLength(2); + expect(screen.getByTitle('Long Bar')).toBeInTheDocument(); + }); + + it('should scroll issue into view when one of the issue is selected', () => { + renderConciseIssues(issues, { + selected: 'issue2', + }); + + expect(HTMLElement.prototype.scrollIntoView).toHaveBeenCalledTimes(1); + }); + + it('should show locations and flows when selected', () => { + renderConciseIssues(issues, { + selected: 'issue4', + selectedFlowIndex: 0, + }); + + expect(screen.getByText('Flow Foo')).toBeInTheDocument(); + expect(screen.getByText('loc 1')).toBeInTheDocument(); + }); + + it('should hide locations and flows when not selected', () => { + renderConciseIssues(issues, { + selected: 'issue2', + }); + + expect(screen.queryByText('Flow Foo')).not.toBeInTheDocument(); + expect(screen.queryByText('loc 1')).not.toBeInTheDocument(); + }); + + it('should not render the expand button if below the collapse limit', () => { + const { ui } = getPageObject(); + renderConciseIssues( + [ + ...issues, + mockIssue(true, { + key: 'custom', + message: 'Custom Issue', + flows: Array.from({ length: COLLAPSE_LIMIT - 1 }).map(() => [loc]), + secondaryLocations: [loc, loc], + }), + ], + { + selected: 'custom', + } + ); + + expect(ui.expandBadgesButton.query()).not.toBeInTheDocument(); + }); +}); + +describe('interacting', () => { + it('should handle back button properly', async () => { + const { ui } = getPageObject(); + const onBackClick = jest.fn(); + const { override } = renderConciseIssues( + issues, + {}, + { + displayBackButton: true, + loading: true, + onBackClick, + } + ); + + // Back button should be shown, but disabled + expect(ui.headerBackButton.get()).toBeInTheDocument(); + await ui.clickBackButton(); + expect(onBackClick).toHaveBeenCalledTimes(0); + + // Re-render without loading + override( + issues, + {}, + { + displayBackButton: true, + loading: false, + onBackClick, + } + ); + + // Back button should be shown and enabled + expect(ui.headerBackButton.get()).toBeInTheDocument(); + await ui.clickBackButton(); + expect(onBackClick).toHaveBeenCalledTimes(1); + }); + + it('should scroll selected issue into view', () => { + const scrollIntoView = jest.fn(); + window.HTMLElement.prototype.scrollIntoView = scrollIntoView; + const { override } = renderConciseIssues(issues, { + selected: 'issue2', + }); + + expect(scrollIntoView).toHaveBeenCalledTimes(1); + + override(issues, { + selected: 'issue4', + }); + expect(scrollIntoView).toHaveBeenCalledTimes(2); + }); + + it('expand button should work correctly', async () => { + const { ui } = getPageObject(); + renderConciseIssues( + [ + ...issues, + mockIssue(true, { + key: 'custom', + message: 'Custom Issue', + flows: Array.from({ length: COLLAPSE_LIMIT }).map(() => [loc]), + secondaryLocations: [loc, loc], + }), + ], + { + selected: 'custom', + } + ); + + expect(ui.expandBadgesButton.get()).toBeInTheDocument(); + expect(ui.boxLocationFlowBadgeText.getAll()).toHaveLength(COLLAPSE_LIMIT - 1); + await ui.clickExpandBadgesButton(); + + expect(ui.expandBadgesButton.query()).not.toBeInTheDocument(); + expect(ui.boxLocationFlowBadgeText.getAll()).toHaveLength(9); + }); + + it('issue selection should correctly be handled', async () => { + const { user } = getPageObject(); + const onIssueSelect = jest.fn(); + renderConciseIssues(issues, { + onIssueSelect, + selected: 'issue2', + }); + + expect(onIssueSelect).not.toHaveBeenCalled(); + + await user.click(screen.getByRole('button', { name: 'Issue 4' })); + expect(onIssueSelect).toHaveBeenCalledTimes(1); + expect(onIssueSelect).toHaveBeenLastCalledWith('issue4'); + }); + + it('flow selection should correctly be handled', async () => { + const { user } = getPageObject(); + const onFlowSelect = jest.fn(); + renderConciseIssues( + [ + ...issues, + mockIssue(true, { + key: 'custom', + message: 'Custom Issue', + secondaryLocations: [], + flows: [[loc], [loc, loc, loc], [loc]], + }), + ], + { + onFlowSelect, + selected: 'issue4', + } + ); + + expect(onFlowSelect).not.toHaveBeenCalled(); + + await user.click(screen.getByText('+3', { exact: false })); + expect(onFlowSelect).toHaveBeenCalledTimes(1); + expect(onFlowSelect).toHaveBeenLastCalledWith(1); + }); +}); + +function getPageObject() { + const selectors = { + headerBackButton: byRole('link', { name: 'issues.return_to_list' }), + expandBadgesButton: byRole('button', { name: '...' }), + boxLocationFlowBadgeText: byText('issue.this_issue_involves_x_code_locations', { + exact: false, + }), + }; + const user = userEvent.setup(); + const ui = { + ...selectors, + async clickBackButton() { + await user.click(ui.headerBackButton.get()); + }, + async clickExpandBadgesButton() { + await user.click(ui.expandBadgesButton.get()); + }, + }; + return { ui, user }; +} + +function renderConciseIssues( + issues: Issue[], + listProps: Partial = {}, + headerProps: Partial = {} +) { + const wrapper = renderComponent( + <> + + + + ); + + function override( + issues: Issue[], + listProps: Partial = {}, + headerProps: Partial = {} + ) { + wrapper.rerender( + <> + + + + ); + } + + return { ...wrapper, override }; +} diff --git a/server/sonar-web/src/main/js/apps/issues/conciseIssuesList/__tests__/ConciseIssuesList-test.tsx b/server/sonar-web/src/main/js/apps/issues/conciseIssuesList/__tests__/ConciseIssuesList-test.tsx deleted file mode 100644 index 41c5ca6e2b2..00000000000 --- a/server/sonar-web/src/main/js/apps/issues/conciseIssuesList/__tests__/ConciseIssuesList-test.tsx +++ /dev/null @@ -1,40 +0,0 @@ -/* - * SonarQube - * Copyright (C) 2009-2023 SonarSource SA - * mailto:info AT sonarsource DOT com - * - * This program is free software; you can redistribute it and/or - * modify it under the terms of the GNU Lesser General Public - * License as published by the Free Software Foundation; either - * version 3 of the License, or (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public License - * along with this program; if not, write to the Free Software Foundation, - * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. - */ -import { shallow } from 'enzyme'; -import * as React from 'react'; -import { Issue } from '../../../../types/types'; -import ConciseIssuesList from '../ConciseIssuesList'; - -it('should render', () => { - const issues = [{ key: 'foo' }, { key: 'bar' }] as Issue[]; - expect( - shallow( - - ) - ).toMatchSnapshot(); -}); diff --git a/server/sonar-web/src/main/js/apps/issues/conciseIssuesList/__tests__/ConciseIssuesListHeader-test.tsx b/server/sonar-web/src/main/js/apps/issues/conciseIssuesList/__tests__/ConciseIssuesListHeader-test.tsx deleted file mode 100644 index 74a8b1d1277..00000000000 --- a/server/sonar-web/src/main/js/apps/issues/conciseIssuesList/__tests__/ConciseIssuesListHeader-test.tsx +++ /dev/null @@ -1,39 +0,0 @@ -/* - * SonarQube - * Copyright (C) 2009-2023 SonarSource SA - * mailto:info AT sonarsource DOT com - * - * This program is free software; you can redistribute it and/or - * modify it under the terms of the GNU Lesser General Public - * License as published by the Free Software Foundation; either - * version 3 of the License, or (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public License - * along with this program; if not, write to the Free Software Foundation, - * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. - */ -import { shallow } from 'enzyme'; -import * as React from 'react'; -import ConciseIssuesListHeader, { ConciseIssuesListHeaderProps } from '../ConciseIssuesListHeader'; - -it('should render correctly', () => { - expect(shallowRender()).toMatchSnapshot('default'); - expect(shallowRender({ loading: true })).toMatchSnapshot('loading'); - expect(shallowRender({ displayBackButton: true })).toMatchSnapshot('with back button'); -}); - -function shallowRender(props: Partial = {}) { - return shallow( - - ); -} diff --git a/server/sonar-web/src/main/js/apps/issues/conciseIssuesList/__tests__/__snapshots__/ConciseIssue-test.tsx.snap b/server/sonar-web/src/main/js/apps/issues/conciseIssuesList/__tests__/__snapshots__/ConciseIssue-test.tsx.snap deleted file mode 100644 index 310f39dcdc3..00000000000 --- a/server/sonar-web/src/main/js/apps/issues/conciseIssuesList/__tests__/__snapshots__/ConciseIssue-test.tsx.snap +++ /dev/null @@ -1,44 +0,0 @@ -// Jest Snapshot v1, https://goo.gl/fbAQLP - -exports[`should render 1`] = ` - -
  • - -
    • -
  • - -
    • -     -`; diff --git a/server/sonar-web/src/main/js/apps/issues/conciseIssuesList/__tests__/__snapshots__/ConciseIssueBox-test.tsx.snap b/server/sonar-web/src/main/js/apps/issues/conciseIssuesList/__tests__/__snapshots__/ConciseIssueBox-test.tsx.snap deleted file mode 100644 index 051deeee673..00000000000 --- a/server/sonar-web/src/main/js/apps/issues/conciseIssuesList/__tests__/__snapshots__/ConciseIssueBox-test.tsx.snap +++ /dev/null @@ -1,220 +0,0 @@ -// Jest Snapshot v1, https://goo.gl/fbAQLP - -exports[`should render correctly 1`] = ` -
    - - - -
    - - -
    -
    -`; - -exports[`should render correctly 2`] = ` -
    - - - -
    - - -
    - -
    -`; diff --git a/server/sonar-web/src/main/js/apps/issues/conciseIssuesList/__tests__/__snapshots__/ConciseIssueComponent-test.tsx.snap b/server/sonar-web/src/main/js/apps/issues/conciseIssuesList/__tests__/__snapshots__/ConciseIssueComponent-test.tsx.snap deleted file mode 100644 index a21ab801a3f..00000000000 --- a/server/sonar-web/src/main/js/apps/issues/conciseIssuesList/__tests__/__snapshots__/ConciseIssueComponent-test.tsx.snap +++ /dev/null @@ -1,12 +0,0 @@ -// Jest Snapshot v1, https://goo.gl/fbAQLP - -exports[`should render 1`] = ` -
    - - src/app/folder/sub-folder/long-folder/name/app.js - -
    -`; diff --git a/server/sonar-web/src/main/js/apps/issues/conciseIssuesList/__tests__/__snapshots__/ConciseIssueLocationBadge-test.tsx.snap b/server/sonar-web/src/main/js/apps/issues/conciseIssuesList/__tests__/__snapshots__/ConciseIssueLocationBadge-test.tsx.snap deleted file mode 100644 index b0ccd9b6dd0..00000000000 --- a/server/sonar-web/src/main/js/apps/issues/conciseIssuesList/__tests__/__snapshots__/ConciseIssueLocationBadge-test.tsx.snap +++ /dev/null @@ -1,15 +0,0 @@ -// Jest Snapshot v1, https://goo.gl/fbAQLP - -exports[`should render 1`] = ` - - - + - 7 - - -`; diff --git a/server/sonar-web/src/main/js/apps/issues/conciseIssuesList/__tests__/__snapshots__/ConciseIssueLocations-test.tsx.snap b/server/sonar-web/src/main/js/apps/issues/conciseIssuesList/__tests__/__snapshots__/ConciseIssueLocations-test.tsx.snap deleted file mode 100644 index be3b3061f5a..00000000000 --- a/server/sonar-web/src/main/js/apps/issues/conciseIssuesList/__tests__/__snapshots__/ConciseIssueLocations-test.tsx.snap +++ /dev/null @@ -1,41 +0,0 @@ -// Jest Snapshot v1, https://goo.gl/fbAQLP - -exports[`should render one flow 1`] = ` - -`; - -exports[`should render secondary locations 1`] = ` - -`; - -exports[`should render several flows 1`] = ` -[ - , - , - , -] -`; diff --git a/server/sonar-web/src/main/js/apps/issues/conciseIssuesList/__tests__/__snapshots__/ConciseIssuesList-test.tsx.snap b/server/sonar-web/src/main/js/apps/issues/conciseIssuesList/__tests__/__snapshots__/ConciseIssuesList-test.tsx.snap deleted file mode 100644 index d9518d3ac9c..00000000000 --- a/server/sonar-web/src/main/js/apps/issues/conciseIssuesList/__tests__/__snapshots__/ConciseIssuesList-test.tsx.snap +++ /dev/null @@ -1,37 +0,0 @@ -// Jest Snapshot v1, https://goo.gl/fbAQLP - -exports[`should render 1`] = ` -
      - - -
    -`; diff --git a/server/sonar-web/src/main/js/apps/issues/conciseIssuesList/__tests__/__snapshots__/ConciseIssuesListHeader-test.tsx.snap b/server/sonar-web/src/main/js/apps/issues/conciseIssuesList/__tests__/__snapshots__/ConciseIssuesListHeader-test.tsx.snap deleted file mode 100644 index 3887851221e..00000000000 --- a/server/sonar-web/src/main/js/apps/issues/conciseIssuesList/__tests__/__snapshots__/ConciseIssuesListHeader-test.tsx.snap +++ /dev/null @@ -1,56 +0,0 @@ -// Jest Snapshot v1, https://goo.gl/fbAQLP - -exports[`should render correctly: default 1`] = ` -
    -
    - -
    -
    -`; - -exports[`should render correctly: loading 1`] = ` -
    -
    - - -
    -
    -`; - -exports[`should render correctly: with back button 1`] = ` -
    -
    - - -
    -
    -`; diff --git a/server/sonar-web/src/main/js/helpers/testMocks.ts b/server/sonar-web/src/main/js/helpers/testMocks.ts index eab7d9b809b..dc0809f4413 100644 --- a/server/sonar-web/src/main/js/helpers/testMocks.ts +++ b/server/sonar-web/src/main/js/helpers/testMocks.ts @@ -314,7 +314,7 @@ export function mockRawIssue(withLocations = false, overrides: Partial }; } -export function mockIssue(withLocations = false, overrides: Partial = {}) { +export function mockIssue(withLocations = false, overrides: Partial = {}): Issue { const issue: Issue = { actions: [], component: 'main.js',