From: Pierre <pierre.guillot@sonarsource.com>
Date: Wed, 4 Aug 2021 07:57:57 +0000 (+0200)
Subject: Revert "SONAR-15235 api/system/health add local parameter"
X-Git-Tag: 9.1.0.47736~180
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=c63120be2e7c090ca42d120c756e703e7cc9eaa1;p=sonarqube.git

Revert "SONAR-15235 api/system/health add local parameter"

This reverts commit 605192c1e3436f82224bfb521efbea77eebd1163.
---

diff --git a/server/sonar-webserver-webapi/src/main/java/org/sonar/server/platform/ws/HealthAction.java b/server/sonar-webserver-webapi/src/main/java/org/sonar/server/platform/ws/HealthAction.java
index 809dcb0e186..68c739fe8b7 100644
--- a/server/sonar-webserver-webapi/src/main/java/org/sonar/server/platform/ws/HealthAction.java
+++ b/server/sonar-webserver-webapi/src/main/java/org/sonar/server/platform/ws/HealthAction.java
@@ -28,8 +28,6 @@ import org.sonar.server.user.SystemPasscode;
 import org.sonar.server.user.UserSession;
 import org.sonar.server.ws.WsUtils;
 
-import static org.sonar.server.platform.ws.HealthActionSupport.LOCAL_PARAM;
-
 public class HealthAction implements SystemWsAction {
   private final WebServer webServer;
   private final HealthActionSupport support;
@@ -54,8 +52,7 @@ public class HealthAction implements SystemWsAction {
       throw new ForbiddenException("Insufficient privileges");
     }
 
-    boolean localParam = request.mandatoryParamAsBoolean(LOCAL_PARAM);
-    if (webServer.isStandalone() || localParam) {
+    if (webServer.isStandalone()) {
       WsUtils.writeProtobuf(support.checkNodeHealth(), request, response);
     } else {
       WsUtils.writeProtobuf(support.checkClusterHealth(), request, response);
diff --git a/server/sonar-webserver-webapi/src/main/java/org/sonar/server/platform/ws/HealthActionSupport.java b/server/sonar-webserver-webapi/src/main/java/org/sonar/server/platform/ws/HealthActionSupport.java
index 5272c44126d..f8a2a6a9100 100644
--- a/server/sonar-webserver-webapi/src/main/java/org/sonar/server/platform/ws/HealthActionSupport.java
+++ b/server/sonar-webserver-webapi/src/main/java/org/sonar/server/platform/ws/HealthActionSupport.java
@@ -32,7 +32,6 @@ import org.sonarqube.ws.System;
 import static org.sonar.api.utils.DateUtils.formatDateTime;
 
 public class HealthActionSupport {
-  static final String LOCAL_PARAM = "local";
   private static final Comparator<NodeHealth> NODE_HEALTH_COMPARATOR = Comparator.<NodeHealth>comparingInt(s -> s.getDetails().getType().ordinal())
     .thenComparing(a -> a.getDetails().getName())
     .thenComparing(a -> a.getDetails().getHost())
@@ -44,7 +43,7 @@ public class HealthActionSupport {
   }
 
   void define(WebService.NewController controller, SystemWsAction handler) {
-    WebService.NewAction action = controller.createAction("health")
+    controller.createAction("health")
       .setDescription("Provide health status of SonarQube." +
         "<p>Require 'Administer System' permission or authentication with passcode</p>" +
         "<p> " +
@@ -57,13 +56,6 @@ public class HealthActionSupport {
       .setSince("6.6")
       .setResponseExample(Resources.getResource(this.getClass(), "example-health.json"))
       .setHandler(handler);
-
-    action.createParam(LOCAL_PARAM)
-      .setDescription("True: Provide health for the node only, False: cluster-wide health (Only applies to SonarQube Datacenter Edition)")
-      .setExampleValue(false)
-      .setDefaultValue(false)
-      .setSince("9.1")
-      .setRequired(false);
   }
 
   System.HealthResponse checkNodeHealth() {
diff --git a/server/sonar-webserver-webapi/src/test/java/org/sonar/server/platform/ws/HealthActionTest.java b/server/sonar-webserver-webapi/src/test/java/org/sonar/server/platform/ws/HealthActionTest.java
index 8a4de5eedd0..71bb50131c2 100644
--- a/server/sonar-webserver-webapi/src/test/java/org/sonar/server/platform/ws/HealthActionTest.java
+++ b/server/sonar-webserver-webapi/src/test/java/org/sonar/server/platform/ws/HealthActionTest.java
@@ -54,8 +54,6 @@ import static org.apache.commons.lang.RandomStringUtils.randomAlphanumeric;
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.mockito.ArgumentMatchers.any;
 import static org.mockito.Mockito.mock;
-import static org.mockito.Mockito.never;
-import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.when;
 import static org.sonar.api.utils.DateUtils.formatDateTime;
 import static org.sonar.api.utils.DateUtils.parseDateTime;
@@ -87,7 +85,7 @@ public class HealthActionTest {
     assertThat(definition.since()).isEqualTo("6.6");
     assertThat(definition.isInternal()).isFalse();
     assertThat(definition.responseExample()).isNotNull();
-    assertThat(definition.params()).extracting(WebService.Param::key).containsOnly("local");
+    assertThat(definition.params()).isEmpty();
   }
 
   @Test
@@ -307,23 +305,6 @@ public class HealthActionTest {
       .containsExactly(expected);
   }
 
-  @Test
-  public void request_returns_only_node_health_when_cluster_with_local_parameter_true() {
-    authenticateWithRandomMethod();
-
-    when(webServer.isStandalone()).thenReturn(false);
-    Health.Builder builder = newHealthCheckBuilder().setStatus(Health.Status.GREEN);
-    Health health = builder.build();
-    when(healthChecker.checkNode()).thenReturn(health);
-
-    System.HealthResponse response = underTest.newRequest().setParam("local", "true")
-      .executeProtobuf(System.HealthResponse.class);
-
-    assertThat(response.getHealth().name()).isEqualTo(health.getStatus().name());
-    assertThat(response.getNodes().getNodesList()).isEmpty();
-    verify(healthChecker, never()).checkCluster();
-  }
-
   private NodeHealth randomNodeHealth() {
     NodeHealth.Builder builder = newNodeHealthBuilder()
       .setStatus(NodeHealth.Status.values()[random.nextInt(NodeHealth.Status.values().length)]);
diff --git a/server/sonar-webserver-webapi/src/test/java/org/sonar/server/platform/ws/SafeModeHealthActionTest.java b/server/sonar-webserver-webapi/src/test/java/org/sonar/server/platform/ws/SafeModeHealthActionTest.java
index 02719c45b61..1518c8f8a45 100644
--- a/server/sonar-webserver-webapi/src/test/java/org/sonar/server/platform/ws/SafeModeHealthActionTest.java
+++ b/server/sonar-webserver-webapi/src/test/java/org/sonar/server/platform/ws/SafeModeHealthActionTest.java
@@ -63,7 +63,7 @@ public class SafeModeHealthActionTest {
     assertThat(definition.since()).isEqualTo("6.6");
     assertThat(definition.isInternal()).isFalse();
     assertThat(definition.responseExample()).isNotNull();
-    assertThat(definition.params()).extracting(WebService.Param::key).containsOnly("local");
+    assertThat(definition.params()).isEmpty();
   }
 
   @Test