From: Artur Signell Date: Tue, 2 Mar 2010 12:51:27 +0000 (+0000) Subject: Renamed list to filteredItems X-Git-Tag: 6.7.0.beta1~2003 X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=c6f947a05979ab629ad31ce0c86f14a0e82b7f4f;p=vaadin-framework.git Renamed list to filteredItems svn changeset:11587/svn branch:6.3 --- diff --git a/src/com/vaadin/data/util/BeanItemContainer.java b/src/com/vaadin/data/util/BeanItemContainer.java index 7848de5eed..59ffdbfce1 100644 --- a/src/com/vaadin/data/util/BeanItemContainer.java +++ b/src/com/vaadin/data/util/BeanItemContainer.java @@ -39,7 +39,7 @@ import com.vaadin.data.Property.ValueChangeNotifier; public class BeanItemContainer implements Indexed, Sortable, Filterable, ItemSetChangeNotifier, ValueChangeListener { // filtered and unfiltered item IDs - private ArrayList list = new ArrayList(); + private ArrayList filteredItems = new ArrayList(); private ArrayList allItems = new ArrayList(); private final Map> beanToItem = new HashMap>(); @@ -172,11 +172,11 @@ public class BeanItemContainer implements Indexed, Sortable, Filterable, } public BT getIdByIndex(int index) { - return list.get(index); + return filteredItems.get(index); } public int indexOfId(Object itemId) { - return list.indexOf(itemId); + return filteredItems.indexOf(itemId); } /** @@ -296,7 +296,7 @@ public class BeanItemContainer implements Indexed, Sortable, Filterable, public boolean containsId(Object itemId) { // only look at visible items after filtering - return list.contains(itemId); + return filteredItems.contains(itemId); } public Property getContainerProperty(Object itemId, Object propertyId) { @@ -312,7 +312,7 @@ public class BeanItemContainer implements Indexed, Sortable, Filterable, } public Collection getItemIds() { - return (Collection) list.clone(); + return (Collection) filteredItems.clone(); } public Class getType(Object propertyId) { @@ -321,7 +321,7 @@ public class BeanItemContainer implements Indexed, Sortable, Filterable, public boolean removeAllItems() throws UnsupportedOperationException { allItems.clear(); - list.clear(); + filteredItems.clear(); // detach listeners from all BeanItems for (BeanItem item : beanToItem.values()) { removeAllValueChangeListeners(item); @@ -345,7 +345,7 @@ public class BeanItemContainer implements Indexed, Sortable, Filterable, removeAllValueChangeListeners(getItem(itemId)); // remove item beanToItem.remove(itemId); - list.remove(itemId); + filteredItems.remove(itemId); fireItemSetChange(); return true; } @@ -375,7 +375,7 @@ public class BeanItemContainer implements Indexed, Sortable, Filterable, } public int size() { - return list.size(); + return filteredItems.size(); } public Collection getSortableContainerPropertyIds() { @@ -445,7 +445,7 @@ public class BeanItemContainer implements Indexed, Sortable, Filterable, public void addContainerFilter(Object propertyId, String filterString, boolean ignoreCase, boolean onlyMatchPrefix) { if (filters.isEmpty()) { - list = (ArrayList) allItems.clone(); + filteredItems = (ArrayList) allItems.clone(); } // listen to change events to be able to update filtering for (BeanItem item : beanToItem.values()) { @@ -465,22 +465,22 @@ public class BeanItemContainer implements Indexed, Sortable, Filterable, */ protected void filterAll() { // avoid notification if the filtering had no effect - List originalItems = list; + List originalItems = filteredItems; // it is somewhat inefficient to do a (shallow) clone() every time - list = (ArrayList) allItems.clone(); + filteredItems = (ArrayList) allItems.clone(); for (Filter f : filters) { filter(f); } // check if exactly the same items are there after filtering to avoid // unnecessary notifications // this may be slow in some cases as it uses BT.equals() - if (!originalItems.equals(list)) { + if (!originalItems.equals(filteredItems)) { fireItemSetChange(); } } protected void filter(Filter f) { - Iterator iterator = list.iterator(); + Iterator iterator = filteredItems.iterator(); while (iterator.hasNext()) { BT bean = iterator.next(); if (!f.passesFilter(getItem(bean))) {