From: Grégoire Aubert <gregoire.aubert@sonarsource.com>
Date: Fri, 3 Aug 2018 13:23:27 +0000 (+0200)
Subject: Fix quality flaws
X-Git-Tag: 7.5~613
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=ccf836d2de4bfba561571fb263433c7bdadd2b9f;p=sonarqube.git

Fix quality flaws
---

diff --git a/server/sonar-bitbucketcloud/src/main/ts/components/Config.tsx b/server/sonar-bitbucketcloud/src/main/ts/components/Config.tsx
index d8818f58ac3..eac079cbdcd 100644
--- a/server/sonar-bitbucketcloud/src/main/ts/components/Config.tsx
+++ b/server/sonar-bitbucketcloud/src/main/ts/components/Config.tsx
@@ -198,7 +198,7 @@ export default class Config extends React.PureComponent<Props, State> {
       descriptionComponent = (
         <>
           This repository is already bound to a{' '}
-          <a href={getBaseUrl() + '/dashboard?id=' + encodeURIComponent(projectKey)}>
+          <a href={`${getBaseUrl()}/dashboard?id=${encodeURIComponent(projectKey)}`}>
             SonarCloud project
           </a>
         </>
@@ -227,8 +227,8 @@ export default class Config extends React.PureComponent<Props, State> {
         <>
           <p>
             You don&apos;t have any project on SonarCloud yet:{' '}
-            <a href={getBaseUrl() + '/onboarding'} rel="noopener noreferrer" target="_blank">
-              Analyse a project
+            <a href={getBaseUrl() + '/projects/create'} rel="noopener noreferrer" target="_blank">
+              Create a project
             </a>
           </p>
         </>
diff --git a/server/sonar-bitbucketcloud/src/main/ts/components/__tests__/Config-test.tsx b/server/sonar-bitbucketcloud/src/main/ts/components/__tests__/Config-test.tsx
index 0dee0434d1e..886013dafd6 100644
--- a/server/sonar-bitbucketcloud/src/main/ts/components/__tests__/Config-test.tsx
+++ b/server/sonar-bitbucketcloud/src/main/ts/components/__tests__/Config-test.tsx
@@ -25,7 +25,7 @@ import { isManualBindingAllowed } from '../../utils';
 
 jest.mock('../../utils', () => ({
   displayMessage: jest.fn(),
-  isManualBindingAllowed: jest.fn(() => true)
+  isManualBindingAllowed: jest.fn()
 }));
 
 jest.mock('../../api', () => ({
@@ -48,6 +48,8 @@ const CONTEXT = { jwt: '' };
 beforeEach(() => {
   (bindProject as jest.Mock<any>).mockClear();
   (getMyProjects as jest.Mock<any>).mockClear();
+  (isManualBindingAllowed as jest.Mock<any>).mockClear();
+  (isManualBindingAllowed as jest.Mock<any>).mockReturnValue(true);
 });
 
 it('should display correctly', async () => {
@@ -62,14 +64,12 @@ it('should display correctly', async () => {
 
 it('should display correctly for auto binding', () => {
   (isManualBindingAllowed as jest.Mock<any>).mockReturnValue(false);
-  expect(getWrapper()).toMatchSnapshot();
-  (isManualBindingAllowed as jest.Mock<any>).mockReturnValue(true);
+  expect(getWrapper({ projectKey: undefined })).toMatchSnapshot();
 });
 
 it('should display correctly for auto binding with already a projectKey', () => {
   (isManualBindingAllowed as jest.Mock<any>).mockReturnValue(false);
   expect(getWrapper()).toMatchSnapshot();
-  (isManualBindingAllowed as jest.Mock<any>).mockReturnValue(true);
 });
 
 it('should display the authentication component and the display checkbox', async () => {
diff --git a/server/sonar-bitbucketcloud/src/main/ts/components/__tests__/__snapshots__/Config-test.tsx.snap b/server/sonar-bitbucketcloud/src/main/ts/components/__tests__/__snapshots__/Config-test.tsx.snap
index 1667e404154..032abbe0401 100644
--- a/server/sonar-bitbucketcloud/src/main/ts/components/__tests__/__snapshots__/Config-test.tsx.snap
+++ b/server/sonar-bitbucketcloud/src/main/ts/components/__tests__/__snapshots__/Config-test.tsx.snap
@@ -254,13 +254,14 @@ exports[`should display correctly for auto binding 1`] = `
       className="settings-description"
     >
       <React.Fragment>
-        This repository is already bound to a
+        To display the quality of your repository, you have to
          
         <a
-          href="/dashboard?id=foo"
+          href="/projects/create"
         >
-          SonarCloud project
+          provision
         </a>
+         a project on SonarCloud and trigger an analysis.
       </React.Fragment>
     </p>
     <React.Fragment>