From: Thomas Tanghus <thomas@tanghus.net>
Date: Wed, 4 Jan 2012 22:31:32 +0000 (+0100)
Subject: Wrong permission checking on file save.
X-Git-Tag: v3.0~60^2~21^2~1
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=d80b477ab55c459cc80cf091c80f81082b7d78f9;p=nextcloud-server.git

Wrong permission checking on file save.
---

diff --git a/lib/image.php b/lib/image.php
index 32568a25406..f120328b0e4 100644
--- a/lib/image.php
+++ b/lib/image.php
@@ -143,10 +143,10 @@ class OC_Image {
 			$filepath = null; // Just being cautious ;-)
 		} else {
 			if(!is_writable(dirname($filepath))) {
-				OC_Log::write('core','OC_Image::save. Directory \''.dirname($filepath).'\' is not writable.', OC_Log::ERROR);
+				OC_Log::write('core','OC_Image::_output. Directory \''.dirname($filepath).'\' is not writable.', OC_Log::ERROR);
 				return false;
-			} elseif(is_writable(dirname($filepath)) && !is_writable($filepath)) {
-				OC_Log::write('core','OC_Image::save. File \''.$filepath.'\' is not writable.', OC_Log::ERROR);
+			} elseif(is_writable(dirname($filepath)) && file_exists($filepath) && !is_writable($filepath)) {
+				OC_Log::write('core','OC_Image::_output. File \''.$filepath.'\' is not writable.', OC_Log::ERROR);
 				return false;
 			}
 		}