From: Stas Vilchik <vilchiks@gmail.com>
Date: Fri, 31 Oct 2014 14:43:22 +0000 (+0100)
Subject: SONAR-5718 Improve issue selection UI
X-Git-Tag: 5.0-RC1~436
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=d813ce88894107592a899bfdccd38070b6922213;p=sonarqube.git

SONAR-5718 Improve issue selection UI
---

diff --git a/server/sonar-web/src/main/coffee/issues/component-viewer/main.coffee b/server/sonar-web/src/main/coffee/issues/component-viewer/main.coffee
index dc618fcdf29..2dae2a47be3 100644
--- a/server/sonar-web/src/main/coffee/issues/component-viewer/main.coffee
+++ b/server/sonar-web/src/main/coffee/issues/component-viewer/main.coffee
@@ -151,8 +151,8 @@ define [
 
 
     highlightIssue: (key) ->
-      @$("[data-issue-key]").removeClass 'highlighted'
-      @$("[data-issue-key='#{key}']").addClass 'highlighted'
+      @$("[data-issue-key]").removeClass 'selected'
+      @$("[data-issue-key='#{key}']").addClass 'selected'
 
 
     openFileByIssue: (issue) ->
diff --git a/server/sonar-web/src/main/less/issues.less b/server/sonar-web/src/main/less/issues.less
index fd48b50411a..01de0dc07c3 100644
--- a/server/sonar-web/src/main/less/issues.less
+++ b/server/sonar-web/src/main/less/issues.less
@@ -224,8 +224,12 @@
 }
 
 .issues-workspace-component-viewer {
-  padding: 0 10px;
+  padding: 1px 10px;
   overflow-x: auto;
+
+  .code-issue-modern {
+    margin: 5px 0;
+  }
 }
 
 .issues-workspace-component-viewer-header {
@@ -248,12 +252,18 @@
 
 .issue-box {
   .clearfix;
-  border: 1px solid @barBorderColor;
-  border-left: none;
+  outline: 1px solid @barBorderColor;
+  border-left: 2px solid transparent;
   overflow: hidden;
 
   &.selected {
-    background-color: #e4ecf3;
+    outline-color: @blue;
+    border-color: @blue;
+  }
+
+  .code-issue {
+    border: none;
+    outline: none;
   }
 }
 
@@ -261,17 +271,13 @@
   margin-top: 12px;
 }
 
-.issue-box-component,
-.issue-box-snippet {
-  border-left: 2px solid @red;
-}
-
 .issue-box-details {
 
 }
 
 .code-issue-modern {
-  border-left: 2px solid @red;
+  outline: 1px solid @barBorderColor;
+  border-left: 2px solid transparent;
 
   .code-issue-name,
   .code-issue-actions,
@@ -281,15 +287,12 @@
     background: transparent;
   }
 
-  &.highlighted {
-    background: #E4ECF3;
+  &.selected {
+    outline-color: @blue;
+    border-color: @blue;
   }
 }
 
-.code-source .code-issue-modern {
-  margin: 5px 0;
-}
-
 .issue-box-snippet {
   padding: 3px 0;
   overflow: hidden;