From: Maciej Przepióra <mac@vaadin.com>
Date: Thu, 28 Apr 2016 13:34:33 +0000 (+0300)
Subject: Throw IAE in setExpandRatio() if given ratio is less than 0
X-Git-Tag: 7.7.0.alpha2~15
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=db19b40724d0012697d04e3e70311347a563e9ee;p=vaadin-framework.git

Throw IAE in setExpandRatio() if given ratio is less than 0

Change-Id: Ie7f92edea210c54400f6dce38e1376e3c0eae575
---

diff --git a/server/src/main/java/com/vaadin/ui/AbstractOrderedLayout.java b/server/src/main/java/com/vaadin/ui/AbstractOrderedLayout.java
index f517ab0af5..d6df3f372a 100644
--- a/server/src/main/java/com/vaadin/ui/AbstractOrderedLayout.java
+++ b/server/src/main/java/com/vaadin/ui/AbstractOrderedLayout.java
@@ -328,6 +328,10 @@ public abstract class AbstractOrderedLayout extends AbstractLayout implements
      * @param component
      *            the component in this layout which expand ratio is to be set
      * @param ratio
+     *            new expand ratio (greater or equal to 0)
+     * @throws IllegalArgumentException
+     *             if the expand ratio is negative or the component is not a
+     *             direct child of the layout
      */
     public void setExpandRatio(Component component, float ratio) {
         ChildComponentData childData = getState().childData.get(component);
@@ -335,6 +339,10 @@ public abstract class AbstractOrderedLayout extends AbstractLayout implements
             throw new IllegalArgumentException(
                     "The given component is not a child of this layout");
         }
+        if (ratio < 0.0f) {
+            throw new IllegalArgumentException(
+                    "Expand ratio can't be less than 0.0");
+        }
 
         childData.expandRatio = ratio;
     }