From: Matti Tahvonen <matti.tahvonen@itmill.com>
Date: Wed, 31 Dec 2008 06:44:04 +0000 (+0000)
Subject: fixes maxlength on IE on single line input element
X-Git-Tag: 6.7.0.beta1~3431
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=de2ba855cb04f78fc58e78abdb05ff4141a20e60;p=vaadin-framework.git

fixes maxlength on IE on single line input element

svn changeset:6377/svn branch:trunk
---

diff --git a/src/com/itmill/toolkit/terminal/gwt/client/ui/ITextField.java b/src/com/itmill/toolkit/terminal/gwt/client/ui/ITextField.java
index f8a9a11347..0e342428e8 100644
--- a/src/com/itmill/toolkit/terminal/gwt/client/ui/ITextField.java
+++ b/src/com/itmill/toolkit/terminal/gwt/client/ui/ITextField.java
@@ -105,7 +105,7 @@ public class ITextField extends TextBoxBase implements Paintable, Field,
             if (getElement().getTagName().toLowerCase().equals("textarea")) {
                 // NOP no maxlenght property for textarea
             } else {
-                getElement().setAttribute("maxlength", "" + maxLength);
+                getElement().setPropertyInt("maxLength", maxLength);
             }
         } else if (maxLength != -1) {
             if (getElement().getTagName().toLowerCase().equals("textarea")) {
diff --git a/src/com/itmill/toolkit/tests/tickets/Ticket932.java b/src/com/itmill/toolkit/tests/tickets/Ticket932.java
index c0fd9c69bc..728966f13b 100644
--- a/src/com/itmill/toolkit/tests/tickets/Ticket932.java
+++ b/src/com/itmill/toolkit/tests/tickets/Ticket932.java
@@ -16,10 +16,9 @@ public class Ticket932 extends Application {
         final Window mainWin = new Window("Test app for max length feature");
         setMainWindow(mainWin);
 
-        final TextField tx = new TextField("Textfield with maxlenght 10");
-        mainWin.addComponent(tx);
+        final TextField tx = new TextField(
+                "Textfield with maxlenght 10, single row");
         tx.setImmediate(true);
-        tx.setRows(5);
         tx.setMaxLength(10);
 
         final Label l = new Label();
@@ -35,6 +34,26 @@ public class Ticket932 extends Application {
 
         mainWin.addComponent(tx);
         mainWin.addComponent(b);
+
+        final TextField tx2 = new TextField(
+                "Textfield with maxlenght 10, multirow");
+        mainWin.addComponent(tx2);
+        tx2.setImmediate(true);
+        tx2.setRows(5);
+        tx2.setMaxLength(10);
+
+        Button b2 = new Button("Check value");
+        b2.addListener(new Button.ClickListener() {
+
+            public void buttonClick(ClickEvent event) {
+                l.setValue("Length: " + tx2.getValue().toString().length()
+                        + " Content: " + tx2.getValue());
+            }
+        });
+
+        mainWin.addComponent(tx);
+        mainWin.addComponent(b);
+
         mainWin.addComponent(l);
 
         final RichTextArea rta = new RichTextArea();