From: Paul Bakaus Date: Fri, 13 Feb 2009 12:26:44 +0000 (+0000) Subject: draggable,sortable: if the offset parent is the body, top/left values should always... X-Git-Tag: 1.7~97 X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=e0f3b0ef32eccfbfe1bb333716ace8e656d993c0;p=jquery-ui.git draggable,sortable: if the offset parent is the body, top/left values should always be normalized to 0 (fixes #4141 - margin on body in safari caused bump) --- diff --git a/ui/ui.draggable.js b/ui/ui.draggable.js index 3946a3c36..b2825ca1d 100644 --- a/ui/ui.draggable.js +++ b/ui/ui.draggable.js @@ -221,7 +221,7 @@ $.widget("ui.draggable", $.extend({}, $.ui.mouse, { po.top += this.scrollParent.scrollTop(); } - if((this.offsetParent[0] == document.body && $.browser.mozilla) //Ugly FF3 fix + if((this.offsetParent[0] == document.body) //This needs to be actually done for all browsers, since pageX/pageY includes this information || (this.offsetParent[0].tagName && this.offsetParent[0].tagName.toLowerCase() == 'html' && $.browser.msie)) //Ugly IE fix po = { top: 0, left: 0 }; diff --git a/ui/ui.sortable.js b/ui/ui.sortable.js index a781ea531..aaf753245 100644 --- a/ui/ui.sortable.js +++ b/ui/ui.sortable.js @@ -730,7 +730,7 @@ $.widget("ui.sortable", $.extend({}, $.ui.mouse, { po.top += this.scrollParent.scrollTop(); } - if((this.offsetParent[0] == document.body && $.browser.mozilla) //Ugly FF3 fix + if((this.offsetParent[0] == document.body) //This needs to be actually done for all browsers, since pageX/pageY includes this information || (this.offsetParent[0].tagName && this.offsetParent[0].tagName.toLowerCase() == 'html' && $.browser.msie)) //Ugly IE fix po = { top: 0, left: 0 };