From: Stas Vilchik <vilchiks@gmail.com>
Date: Mon, 19 Jan 2015 11:03:33 +0000 (+0100)
Subject: fix SONAR-6041 update navigator pages
X-Git-Tag: latest-silver-master-#65~186
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=e1d098d6854f9922b7c47c4acd8a0969b917dd55;p=sonarqube.git

fix SONAR-6041 update navigator pages
---

diff --git a/server/sonar-web/src/main/hbs/coding-rules/coding-rules-layout.hbs b/server/sonar-web/src/main/hbs/coding-rules/coding-rules-layout.hbs
index ae396827d7f..01a9f34d8b4 100644
--- a/server/sonar-web/src/main/hbs/coding-rules/coding-rules-layout.hbs
+++ b/server/sonar-web/src/main/hbs/coding-rules/coding-rules-layout.hbs
@@ -5,7 +5,7 @@
   </div>
 </div>
 
-<div class="container-main">
+<div class="container-main face-main">
   <div class="search-navigator-workspace-header"></div>
   <div class="search-navigator-workspace">
     <div class="search-navigator-workspace-list"></div>
diff --git a/server/sonar-web/src/main/hbs/issues/issues-layout.hbs b/server/sonar-web/src/main/hbs/issues/issues-layout.hbs
index e0399a5a2ce..782d2f517c1 100644
--- a/server/sonar-web/src/main/hbs/issues/issues-layout.hbs
+++ b/server/sonar-web/src/main/hbs/issues/issues-layout.hbs
@@ -6,7 +6,7 @@
   </div>
 </div>
 
-<div class="container-main">
+<div class="container-main face-main">
   <div class="search-navigator-workspace-header"></div>
   <div class="search-navigator-workspace">
     <div class="search-navigator-workspace-list"></div>
diff --git a/server/sonar-web/src/main/hbs/issues/issues-workspace-header.hbs b/server/sonar-web/src/main/hbs/issues/issues-workspace-header.hbs
index e29177268b7..09a852bd550 100644
--- a/server/sonar-web/src/main/hbs/issues/issues-workspace-header.hbs
+++ b/server/sonar-web/src/main/hbs/issues/issues-workspace-header.hbs
@@ -1,12 +1,6 @@
 <div class="issues-header-component">
   {{#if state.component}}
     <a class="js-back">{{t 'issues.return_to_list'}}</a>&nbsp;&nbsp;&nbsp;
-
-    {{#with state.component}}
-      {{qualifierIcon 'TRK'}}&nbsp;<a href="{{dashboardUrl project}}" title="{{projectName}}">{{projectName}}</a>
-      &nbsp;&nbsp;
-      {{qualifierIcon qualifier}}&nbsp;<a href="{{dashboardUrl key}}" title="{{name}}">{{name}}</a>
-    {{/with}}
   {{else}}
     &nbsp;
   {{/if}}
diff --git a/server/sonar-web/src/main/js/coding-rules/controller.js b/server/sonar-web/src/main/js/coding-rules/controller.js
index f32b51332a6..1819c98c5a3 100644
--- a/server/sonar-web/src/main/js/coding-rules/controller.js
+++ b/server/sonar-web/src/main/js/coding-rules/controller.js
@@ -127,7 +127,6 @@ define([
       this.app.layout.workspaceDetailsRegion.reset();
       this.app.layout.hideDetails();
       this.app.workspaceListView.bindScrollEvents();
-      this.app.workspaceListView.scrollTo();
     }
 
   });
diff --git a/server/sonar-web/src/main/js/coding-rules/layout.js b/server/sonar-web/src/main/js/coding-rules/layout.js
index c9fa76c5769..b71a89ad59a 100644
--- a/server/sonar-web/src/main/js/coding-rules/layout.js
+++ b/server/sonar-web/src/main/js/coding-rules/layout.js
@@ -16,25 +16,6 @@ define([
       workspaceDetailsRegion: '.search-navigator-workspace-details'
     },
 
-    initialize: function () {
-      var that = this;
-      $(window).on('scroll.search-navigator-layout', function () {
-        that.onScroll();
-      });
-    },
-
-    onClose: function () {
-      $(window).off('scroll.search-navigator-layout');
-    },
-
-    onScroll: function () {
-      var scrollTop = $(window).scrollTop();
-      $('.search-navigator').toggleClass('sticky', scrollTop >= this.topOffset);
-      this.$('.search-navigator-side').css({
-        top: Math.max(0, Math.min(this.topOffset - scrollTop, this.topOffset))
-      });
-    },
-
     showDetails: function () {
       this.scroll = $(window).scrollTop();
       $('.search-navigator').addClass('search-navigator-extended-view');
diff --git a/server/sonar-web/src/main/js/coding-rules/rule-details-view.js b/server/sonar-web/src/main/js/coding-rules/rule-details-view.js
index 95475fe7b5a..ef550bb876d 100644
--- a/server/sonar-web/src/main/js/coding-rules/rule-details-view.js
+++ b/server/sonar-web/src/main/js/coding-rules/rule-details-view.js
@@ -73,7 +73,6 @@ define([
             app: this.options.app,
             model: this.model
           }));
-          this.$el.scrollParent().scrollTop(30);
         },
 
         onClose: function () {
diff --git a/server/sonar-web/src/main/less/components/issues.less b/server/sonar-web/src/main/less/components/issues.less
index e4029858dde..5bcac573202 100644
--- a/server/sonar-web/src/main/less/components/issues.less
+++ b/server/sonar-web/src/main/less/components/issues.less
@@ -24,7 +24,8 @@
 
 .issue-list,
 .issue {
-  max-width: 920px;
+  width: 780px;
+  .box-sizing(border-box);
 }
 
 .issue.selected {
@@ -62,6 +63,8 @@
   line-height: 1.5;
   font-size: @baseFontSize;
   font-weight: 500;
+  word-break: break-all;
+  word-break: break-word;
 }
 
 .issue-tags {
diff --git a/server/sonar-web/src/main/less/components/search-navigator.less b/server/sonar-web/src/main/less/components/search-navigator.less
index 9246d8442d3..b2b74e936e0 100644
--- a/server/sonar-web/src/main/less/components/search-navigator.less
+++ b/server/sonar-web/src/main/less/components/search-navigator.less
@@ -6,41 +6,14 @@
 
 .search-navigator {
   .clearfix;
-
-//  &.sticky {
-//
-//    .search-navigator-workspace-header {
-//      position: fixed;
-//      z-index: 4;
-//      top: 0;
-//      left: @sideWidth;
-//      right: 0;
-//    }
-//
-//    .search-navigator-workspace-list,
-//    .search-navigator-workspace-details {
-//      padding-top: 22px + 5px + 5px + 1px + 10px;
-//    }
-//
-//    .search-navigator-side {
-//      position: fixed;
-//      z-index: 4;
-//      top: 0;
-//      bottom: 0;
-//      overflow-y: auto;
-//    }
-//
-//  }
 }
 
 .search-navigator-side {
   .box-sizing(border-box);
-  background-color: @barBorderColor;
   overflow-x: hidden;
 }
 
 .search-navigator-facet-box {
-  border-top: 1px solid @barBorderColor;
   background-color: @barBackgroundColor;
   font-size: @baseFontSize;
 }
diff --git a/server/sonar-web/src/main/less/issues.less b/server/sonar-web/src/main/less/issues.less
index e3a58587aad..88b13ff20aa 100644
--- a/server/sonar-web/src/main/less/issues.less
+++ b/server/sonar-web/src/main/less/issues.less
@@ -7,14 +7,6 @@
 
 .issues {
 
-//  &.sticky {
-//
-//    .issues-workspace-list,
-//    .issues-workspace-component-viewer {
-//      padding-top: 22px + 5px + 5px + 1px + 10px;
-//    }
-//
-//  }
 }
 
 .issues-workspace-list-component {
@@ -36,7 +28,6 @@
 
 .issues-workspace-component-viewer {
   display: none;
-  padding: 1px 10px;
   min-height: 100vh;
 
   .code-issue-modern {
diff --git a/server/sonar-web/src/main/less/layout-new.less b/server/sonar-web/src/main/less/layout-new.less
index a906046e4b3..4854ccdc009 100644
--- a/server/sonar-web/src/main/less/layout-new.less
+++ b/server/sonar-web/src/main/less/layout-new.less
@@ -13,6 +13,7 @@ html {
 
 body {
   min-width: @pageWidth;
+  min-height: 100vh;
 }
 
 .container {
@@ -52,3 +53,17 @@ body {
   float: left;
   width: @containerWidth - @sideWidth;
 }
+
+.face-bar {
+  background-color: @barBackgroundColor;
+}
+
+.face-main {
+  margin: -10px;
+  padding: 10px;
+  background-color: #fff;
+}
+
+.container-side + .face-main {
+  box-shadow: -6px 0 10px 0 rgba(0, 0, 0, 0.075);
+}
diff --git a/server/sonar-web/src/main/less/layout.less b/server/sonar-web/src/main/less/layout.less
index bb3b65bef9b..236075fc815 100644
--- a/server/sonar-web/src/main/less/layout.less
+++ b/server/sonar-web/src/main/less/layout.less
@@ -131,13 +131,14 @@
 }
 
 #footer {
-  padding: 4px 0;
+  position: relative;
   clear: both;
 }
 
 #body {
   position: relative;
   padding-top: 10px;
+  padding-bottom: 10px;
 }
 
 .with_sidebar {
diff --git a/server/sonar-web/src/main/less/style.less b/server/sonar-web/src/main/less/style.less
index 327357f513a..11b53fbc9d1 100644
--- a/server/sonar-web/src/main/less/style.less
+++ b/server/sonar-web/src/main/less/style.less
@@ -35,10 +35,10 @@
   FOOTER
 */
 #ftlinks {
-  background: #fff;
+  background: @barBackgroundColor;
   color: #262626;
   text-align: center;
-  border-top: 1px solid #fff;
+  border-top: 1px solid @barBackgroundColor;
   font-size: 85%;
   padding: 10px 0;
   line-height: 1.4;
diff --git a/server/sonar-web/src/main/webapp/WEB-INF/app/views/coding_rules/index.html.erb b/server/sonar-web/src/main/webapp/WEB-INF/app/views/coding_rules/index.html.erb
index a7d9e3027b1..bd4e8d94197 100644
--- a/server/sonar-web/src/main/webapp/WEB-INF/app/views/coding_rules/index.html.erb
+++ b/server/sonar-web/src/main/webapp/WEB-INF/app/views/coding_rules/index.html.erb
@@ -2,5 +2,7 @@
   <script>require(['coding-rules/app']);</script>
 <% end %>
 
+<% content_for :body_class do %>face-bar<% end %>
+
 
 <div class="coding-rules search-navigator"></div>
diff --git a/server/sonar-web/src/main/webapp/WEB-INF/app/views/issues/search.html.erb b/server/sonar-web/src/main/webapp/WEB-INF/app/views/issues/search.html.erb
index 5741c2c169a..d7cc60c36bd 100644
--- a/server/sonar-web/src/main/webapp/WEB-INF/app/views/issues/search.html.erb
+++ b/server/sonar-web/src/main/webapp/WEB-INF/app/views/issues/search.html.erb
@@ -2,4 +2,6 @@
   <script>require(['issues/app-new']);</script>
 <% end %>
 
+<% content_for :body_class do %>face-bar<% end %>
+
 <div class="issues search-navigator"></div>
diff --git a/server/sonar-web/src/main/webapp/WEB-INF/app/views/layouts/_head.html.erb b/server/sonar-web/src/main/webapp/WEB-INF/app/views/layouts/_head.html.erb
index be7b6ade97e..95eb64911bd 100644
--- a/server/sonar-web/src/main/webapp/WEB-INF/app/views/layouts/_head.html.erb
+++ b/server/sonar-web/src/main/webapp/WEB-INF/app/views/layouts/_head.html.erb
@@ -43,4 +43,4 @@
   </script>
   <%= yield :script -%>
 </head>
-<body>
+<body class="<%= yield :body_class -%>">