From: Vsevolod Stakhov <vsevolod@highsecure.ru>
Date: Thu, 25 Oct 2018 12:30:22 +0000 (+0100)
Subject: [Minor] Remove assertion as this case can actually happen
X-Git-Tag: 1.8.2~140
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=e1dba059e14afd5c0995d4fb96a2ac7a284d7c93;p=rspamd.git

[Minor] Remove assertion as this case can actually happen
---

diff --git a/src/libserver/symbols_cache.c b/src/libserver/symbols_cache.c
index 17fcb192d..5584d48cf 100644
--- a/src/libserver/symbols_cache.c
+++ b/src/libserver/symbols_cache.c
@@ -1316,9 +1316,11 @@ rspamd_symbols_cache_check_symbol (struct rspamd_task *task,
 
 		g_assert (item->func != NULL);
 		if (CHECK_START_BIT (checkpoint, item)) {
-			msg_err_cache ("critical error: trying to execute already executed symbol %s",
-				item->symbol);
-			g_assert_not_reached ();
+			/*
+			 * This can actually happen when deps span over different layers
+			 */
+
+			return CHECK_FINISH_BIT (checkpoint, item);
 		}
 		/* Check has been started */
 		SET_START_BIT (checkpoint, item);