From: Stas Vilchik Date: Wed, 21 Feb 2018 15:36:42 +0000 (+0100) Subject: create and use Button component (#3087) X-Git-Tag: 7.5~1638 X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=e353cd6f2bd37ea143d5806e9ee85323cddd1f97;p=sonarqube.git create and use Button component (#3087) --- diff --git a/server/sonar-qa-util/src/main/java/org/sonarqube/qa/util/pageobjects/LoginPage.java b/server/sonar-qa-util/src/main/java/org/sonarqube/qa/util/pageobjects/LoginPage.java index a11730125aa..3f765429d47 100644 --- a/server/sonar-qa-util/src/main/java/org/sonarqube/qa/util/pageobjects/LoginPage.java +++ b/server/sonar-qa-util/src/main/java/org/sonarqube/qa/util/pageobjects/LoginPage.java @@ -22,7 +22,6 @@ package org.sonarqube.qa.util.pageobjects; import com.codeborne.selenide.Condition; import com.codeborne.selenide.Selenide; import com.codeborne.selenide.SelenideElement; -import org.openqa.selenium.By; public class LoginPage { @@ -49,7 +48,7 @@ public class LoginPage { public LoginPage submitWrongCredentials(String login, String password) { Selenide.$("#login").val(login); Selenide.$("#password").val(password); - Selenide.$(By.name("commit")).click(); + Selenide.$("[type=submit]").click(); return Selenide.page(LoginPage.class); } @@ -60,7 +59,7 @@ public class LoginPage { private static T submitCredentials(String login, String password, Class expectedResultPage) { Selenide.$("#login").val(login); Selenide.$("#password").val(password); - Selenide.$(By.name("commit")).click(); + Selenide.$("[type=submit]").click(); Selenide.$("#login").should(Condition.disappear); return Selenide.page(expectedResultPage); } diff --git a/server/sonar-web/src/main/js/api/quality-profiles.ts b/server/sonar-web/src/main/js/api/quality-profiles.ts index 736de049edb..e589638ac76 100644 --- a/server/sonar-web/src/main/js/api/quality-profiles.ts +++ b/server/sonar-web/src/main/js/api/quality-profiles.ts @@ -112,7 +112,7 @@ export function getProfileProjects(data: RequestData): Promise { } export function getProfileInheritance(profileKey: string): Promise { - return getJSON('/api/qualityprofiles/inheritance', { profileKey }); + return getJSON('/api/qualityprofiles/inheritance', { profileKey }).catch(throwGlobalError); } export function setDefaultProfile(profileKey: string): Promise { @@ -135,8 +135,10 @@ export function changeProfileParent(profileKey: string, parentKey: string): Prom return post('/api/qualityprofiles/change_parent', { profileKey, parentKey }); } -export function getImporters(): Promise { - return getJSON('/api/qualityprofiles/importers').then(r => r.importers); +export function getImporters(): Promise< + Array<{ key: string; languages: Array; name: string }> +> { + return getJSON('/api/qualityprofiles/importers').then(r => r.importers, throwGlobalError); } export function getExporters(): Promise { diff --git a/server/sonar-web/src/main/js/app/components/nav/settings/SettingsEditionsNotif.tsx b/server/sonar-web/src/main/js/app/components/nav/settings/SettingsEditionsNotif.tsx index e5a5d8dfef4..3c8850a95ef 100644 --- a/server/sonar-web/src/main/js/app/components/nav/settings/SettingsEditionsNotif.tsx +++ b/server/sonar-web/src/main/js/app/components/nav/settings/SettingsEditionsNotif.tsx @@ -21,6 +21,7 @@ import * as React from 'react'; import { FormattedMessage } from 'react-intl'; import NavBarNotif from '../../../../components/nav/NavBarNotif'; import RestartForm from '../../../../components/common/RestartForm'; +import { Button } from '../../../../components/ui/buttons'; import { dismissErrorMessage, Edition, EditionStatus } from '../../../../api/marketplace'; import { translate, translateWithParameters } from '../../../../helpers/l10n'; @@ -86,6 +87,7 @@ export default class SettingsEditionsNotif extends React.PureComponent {edition.name} @@ -95,9 +97,9 @@ export default class SettingsEditionsNotif extends React.PureComponent )} {!preventRestart && ( - + )} {!preventRestart && this.state.openRestart && } diff --git a/server/sonar-web/src/main/js/app/components/nav/settings/__tests__/__snapshots__/SettingsEditionsNotif-test.tsx.snap b/server/sonar-web/src/main/js/app/components/nav/settings/__tests__/__snapshots__/SettingsEditionsNotif-test.tsx.snap index 1b1380978bf..f843a2d29ba 100644 --- a/server/sonar-web/src/main/js/app/components/nav/settings/__tests__/__snapshots__/SettingsEditionsNotif-test.tsx.snap +++ b/server/sonar-web/src/main/js/app/components/nav/settings/__tests__/__snapshots__/SettingsEditionsNotif-test.tsx.snap @@ -30,13 +30,12 @@ exports[`should display a ready notification 1`] = ` marketplace.edition_status.AUTOMATIC_READY - + `; diff --git a/server/sonar-web/src/main/js/apps/account/organizations/CreateOrganizationForm.tsx b/server/sonar-web/src/main/js/apps/account/organizations/CreateOrganizationForm.tsx index 53117d71a12..04254a29e1a 100644 --- a/server/sonar-web/src/main/js/apps/account/organizations/CreateOrganizationForm.tsx +++ b/server/sonar-web/src/main/js/apps/account/organizations/CreateOrganizationForm.tsx @@ -25,6 +25,7 @@ import { createOrganization } from '../../organizations/actions'; import { Organization } from '../../../app/types'; import Modal from '../../../components/controls/Modal'; import { translate } from '../../../helpers/l10n'; +import { SubmitButton, ResetButtonLink } from '../../../components/ui/buttons'; interface DispatchProps { createOrganization: (fields: Partial) => Promise<{ key: string }>; @@ -136,16 +137,16 @@ class CreateOrganizationForm extends React.PureComponent { *
{translate('organization.name.description')} @@ -154,14 +155,14 @@ class CreateOrganizationForm extends React.PureComponent {
{translate('organization.key.description')} @@ -170,13 +171,13 @@ class CreateOrganizationForm extends React.PureComponent {
{translate('organization.avatar.description')} @@ -187,20 +188,20 @@ class CreateOrganizationForm extends React.PureComponent { {translate('organization.avatar.preview')} {':'}
- +
)}