From: Jean-Philippe Lang <jp_lang@yahoo.fr>
Date: Tue, 10 Mar 2015 18:19:51 +0000 (+0000)
Subject: Fixed that #require_login should respond for other request types (#19325).
X-Git-Tag: 3.1.0~214
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=e429d93945e7acaec9ff2f3118a7cd650345e077;p=redmine.git

Fixed that #require_login should respond for other request types (#19325).

git-svn-id: http://svn.redmine.org/redmine/trunk@14069 e93f8b46-1217-0410-a6f0-8f06a7374b81
---

diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb
index 480dfb885..e52cc6186 100644
--- a/app/controllers/application_controller.rb
+++ b/app/controllers/application_controller.rb
@@ -243,10 +243,13 @@ class ApplicationController < ActionController::Base
             redirect_to :controller => "account", :action => "login", :back_url => url
           end
         }
-        format.atom { redirect_to :controller => "account", :action => "login", :back_url => url }
+        format.any(:atom, :pdf, :csv) {
+          redirect_to :controller => "account", :action => "login", :back_url => url
+        }
         format.xml  { head :unauthorized, 'WWW-Authenticate' => 'Basic realm="Redmine API"' }
         format.js   { head :unauthorized, 'WWW-Authenticate' => 'Basic realm="Redmine API"' }
         format.json { head :unauthorized, 'WWW-Authenticate' => 'Basic realm="Redmine API"' }
+        format.any  { head :unauthorized }
       end
       return false
     end
diff --git a/test/integration/application_test.rb b/test/integration/application_test.rb
index befb8fb35..e01b44a72 100644
--- a/test/integration/application_test.rb
+++ b/test/integration/application_test.rb
@@ -87,4 +87,11 @@ class ApplicationTest < Redmine::IntegrationTest
   ensure
     ActionController::Base.allow_forgery_protection = false
   end
+
+  def test_require_login_with_pdf_format_should_not_error
+    with_settings :login_required => '1' do
+      get '/issues/1.pdf'
+      assert_response 302
+    end
+  end
 end